- Engine-commits - oVirt List Archives

Change in jenkins[master]: jobs: ebay-cors-filter
by dcaroest＠redhat.com 12 Feb '15

12 Feb '15

David Caro has submitted this change and it was merged. Change subject: jobs: ebay-cors-filter ...................................................................... jobs: ebay-cors-filter Issue: https://fedorahosted.org/ovirt/ticket/287 Change-Id: I1b9a3e13474a9c7f18704c5c7383d5ff00fd2337 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/ebay-cors-filter/ebay-cors-filter.yaml 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b9a3e13474a9c7f18704c5c7383d5ff00fd2337 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Fixing issue with quoted dists
by dcaroest＠redhat.com 12 Feb '15

12 Feb '15

David Caro has submitted this change and it was merged. Change subject: Fixing issue with quoted dists ...................................................................... Fixing issue with quoted dists Only affects releng jobs Change-Id: Ibca607e34725c414ca7daf6194f47614b7149fcc Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibca607e34725c414ca7daf6194f47614b7149fcc Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adding a helper function to check if table exists
by emesika＠redhat.com 12 Feb '15

12 Feb '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Adding a helper function to check if table exists ...................................................................... engine: Adding a helper function to check if table exists Bug-Url: https://bugzilla.redhat.com/1161012 Change-Id: I9421526de442640cf985cb0302f7fa3d6daa909a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/37421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9421526de442640cf985cb0302f7fa3d6daa909a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: showing the GUID instead of the physical d...
by sbonazzo＠redhat.com 12 Feb '15

12 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: showing the GUID instead of the physical dev on iSCSI setup ...................................................................... packaging: setup: showing the GUID instead of the physical dev on iSCSI setup iSCSI deploy presents to the user the list of available LUNs on the selected target showing also the physical device. That behaviour is not that much coherent on multipath deployments where we found more than one physical devices for each LUN. Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f Bug-Url: https://bugzilla.redhat.com/1177800 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py 2 files changed, 61 insertions(+), 41 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/37494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: guest monitor: add an interval attribute
by alitke＠redhat.com 11 Feb '15

11 Feb '15

Adam Litke has submitted this change and it was merged. Change subject: guest monitor: add an interval attribute ...................................................................... guest monitor: add an interval attribute Expose the monitoring interval as a GuestMonitor attribute. A future patch wants to make use of it. Change-Id: I25e817bbae8e806aad914241831b5e5bbba461e1 Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31590 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/GuestMonitor.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25e817bbae8e806aad914241831b5e5bbba461e1 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Pavlásek <mpavlase(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Expose total RX/TX statistics via REST
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: restapi: Expose total RX/TX statistics via REST ...................................................................... restapi: Expose total RX/TX statistics via REST Exposed the total RX/TX statistics via REST, as part of the corresponding statistical queries. Change-Id: I558fa2369880057296896fea35ecb94cbcaefdec Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostNicStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/NicStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java 9 files changed, 50 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/36477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I558fa2369880057296896fea35ecb94cbcaefdec Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Improve performance of GetAllSnapshotsByStorageDomainId
by tnisan＠redhat.com 11 Feb '15

11 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Improve performance of GetAllSnapshotsByStorageDomainId ...................................................................... core: Improve performance of GetAllSnapshotsByStorageDomainId GetAllSnapshotsByStorageDomainId returns a huge number of duplicate rows. Under load this creates a memory issue. This patch solves this. Change-Id: I87207b3c284c161b0d0dfa72d21fb47593d010b3 Bug-Url: https://bugzilla.redhat.com/1191142 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/snapshots_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/37663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87207b3c284c161b0d0dfa72d21fb47593d010b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce postConstruct for commands
by rgolan＠redhat.com 11 Feb '15

11 Feb '15

Roy Golan has submitted this change and it was merged. Change subject: core: Introduce postConstruct for commands ...................................................................... core: Introduce postConstruct for commands Replace the need to call DbFacade or other interaction with the command dependencies during the constructor. It is ensured (by CommandFactory) that all the command injected dependencies are already in place. so instead of: public DoThisCommand(P p) { DbFacade.getInstance().getVmDao... } we would: @Override protected postConstruct() { dbFacade.getVmDao... } Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/37599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display total RX/TX in interface subtabs
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Display total RX/TX in interface subtabs ...................................................................... webadmin: Display total RX/TX in interface subtabs Display the total RX/TX statistics in the host/interfaces, network/hosts, VM/interfaces and network/VMs subtabs. Change-Id: I21f4f05d79de76f7b058a091e27b3aca6badf94e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/NullableNumberRenderer.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NullableNumberColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterface.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberTextBoxLabel.java 16 files changed, 167 insertions(+), 31 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f4f05d79de76f7b058a091e27b3aca6badf94e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist total RX/TX in compatible hosts/VMs
by lvernia＠redhat.com 11 Feb '15

11 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Persist total RX/TX in compatible hosts/VMs ...................................................................... engine: Persist total RX/TX in compatible hosts/VMs Persist the new total RX/TX values for host/VM interfaces in compatible clusters. Also, if the cluster is compatible, compute rate on our own (so vdsm could drop the computation in future versions). Change-Id: I3063bb36fb7e4d5a545d42c648091688ce1e6964 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilderTest.java 6 files changed, 443 insertions(+), 25 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3063bb36fb7e4d5a545d42c648091688ce1e6964 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0