- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Packages management at customization
by sbonazzo＠redhat.com 29 Jan '15

29 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Packages management at customization ...................................................................... packaging: setup: Packages management at customization Move engine packages management to customization stage. Do most handling only if engine is enabled. Bug-Url: https://bugzilla.redhat.com/1150108 Change-Id: I9ea083958ca3212bc0e36c725dab5966c62e7df1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py 1 file changed, 43 insertions(+), 35 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea083958ca3212bc0e36c725dab5966c62e7df1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: BLL queries for volume snapshots list and count
by kmayilsa＠redhat.com 29 Jan '15

29 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: BLL queries for volume snapshots list and count ...................................................................... gluster: BLL queries for volume snapshots list and count Introduced BLL queries for volume snapshots list and its total count for a given volume. Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotsByVolumeIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/gluster_volume_snapshot_sp.sql A packaging/dbscripts/upgrade/03_06_0820_add_snapshot_count_to_gluster_volume.sql 12 files changed, 161 insertions(+), 8 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use existing 'failCanDoAction' method to fail a CDA
by mlipchuk＠redhat.com 28 Jan '15

28 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use existing 'failCanDoAction' method to fail a CDA ...................................................................... core: Use existing 'failCanDoAction' method to fail a CDA Reuse existing 'failCnDoAction' method instead of writing method logic inline. Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Ala Hino: Verified -- To view, visit http://gerrit.ovirt.org/37231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused imports in Injector class
by mlipchuk＠redhat.com 28 Jan '15

28 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused imports in Injector class ...................................................................... core: Remove unused imports in Injector class Remove unused imports that breakes the engine build Change-Id: I0b532e8fa2486d7265326338c9c8657e788d8907 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/Injector.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b532e8fa2486d7265326338c9c8657e788d8907 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Fix EngineSession DAO failures
by oourfali＠redhat.com 28 Jan '15

28 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Fix EngineSession DAO failures ...................................................................... engine : Fix EngineSession DAO failures EngineSessionDAO tests fail when invoked second time with out reiniting the database. Change-Id: I04ecb20abeaafe7a009efab3bf532a2339267d13 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineSessionDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java 4 files changed, 46 insertions(+), 19 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Maor Lipchuk: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ecb20abeaafe7a009efab3bf532a2339267d13 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: hosts from gluster clusters shouldn't be considered
by laravot＠redhat.com 28 Jan '15

28 Jan '15

Liron Aravot has submitted this change and it was merged. Change subject: core: hosts from gluster clusters shouldn't be considered ...................................................................... core: hosts from gluster clusters shouldn't be considered When moving a domain to maintenance or when handling problematic domain, hosts from gluster clusters were considered although we don't use any monitoring from those hosts which prevents hosts from moving to maintenance or from properly handle a problematic domain. This patch fixes it by loading only the hosts from virt service (which we collect domain monitoring information from) instead of loading all the hosts. Change-Id: I2b89785529ec00114065e350138e05d6c966df44 Bug-Url: https://bugzilla.redhat.com/1186687 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M packaging/dbscripts/vds_sp.sql 6 files changed, 30 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b89785529ec00114065e350138e05d6c966df44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: upload: use low level copy and print a progress bar
by sbonazzo＠redhat.com 28 Jan '15

28 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: use low level copy and print a progress bar ...................................................................... upload: use low level copy and print a progress bar Using python code to copy the file measuring its progress and printing a progress bar. Change-Id: I2a28947cd607be83c51b25bfcdb5ef50a58afbbb Bug-Url: https://bugzilla.redhat.com/1077235 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 38 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/37292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a28947cd607be83c51b25bfcdb5ef50a58afbbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: rename: Use the Hostname class for new name
by sbonazzo＠redhat.com 28 Jan '15

28 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: Use the Hostname class for new name ...................................................................... packaging: rename: Use the Hostname class for new name Change-Id: I22e5f41b138cd212ec2e951d66c175bddd6d3200 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/hostname.py M packaging/setup/plugins/ovirt-engine-common/base/network/__init__.py R packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-setup/base/network/__init__.py 5 files changed, 27 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22e5f41b138cd212ec2e951d66c175bddd6d3200 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add support for CDI in Queries
by rgolan＠redhat.com 28 Jan '15

28 Jan '15

Roy Golan has submitted this change and it was merged. Change subject: core: Add support for CDI in Queries ...................................................................... core: Add support for CDI in Queries Before the use of dependency injection was restricted to Commands. This patch extends this support also for queries. Change-Id: Idf977e9e833effd9b7a0bddaec66acd5a8a5ad65 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/Injector.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Betak: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf977e9e833effd9b7a0bddaec66acd5a8a5ad65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Make Async Tasks Manager aware of child CoCo tasks
by derez＠redhat.com 28 Jan '15

28 Jan '15

Daniel Erez has submitted this change and it was merged. Change subject: engine : Make Async Tasks Manager aware of child CoCo tasks ...................................................................... engine : Make Async Tasks Manager aware of child CoCo tasks Child commands started by AsycTasks should be considered by AsyncTaskManager before invoking the endSuccessfully on the async task. Change-Id: I0d877309fd150280cd7ba6993b341a9044a4572f Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java M packaging/dbscripts/command_entities_sp.sql 11 files changed, 78 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d877309fd150280cd7ba6993b341a9044a4572f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0