- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: fix ClassCastException in StorageModel
by Code Review 17 May '17

17 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: frontend: fix ClassCastException in StorageModel ...................................................................... frontend: fix ClassCastException in StorageModel StorageModel::updateDiscardAfterDelete used to set the Discard After Delete (DAD) entity to false if it's not a block storage domain. This caused DAD's entity changed event to be raised, which should happen only for block domains. This patch removes the redundant call to setEntity on DAD, as it's already being set to false when switching back to a block domain. Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349 Bug-Url: https://bugzilla.redhat.com/1451246 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/76931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Allow TLSv1.2 for external provider communication
by Code Review 17 May '17

17 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow TLSv1.2 for external provider communication ...................................................................... core: Allow TLSv1.2 for external provider communication Allows to use TLSv1.2 for protocol negotiation for external provider communication. Change-Id: I96e22228e5780ad0e63b70fb3d7dcda31c53e41d Bug-Url: https://bugzilla.redhat.com/1421204 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96e22228e5780ad0e63b70fb3d7dcda31c53e41d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use never instead of times(0)
by Code Review 17 May '17

17 May '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use never instead of times(0) ...................................................................... core: Use never instead of times(0) Change-Id: Ib956a82461d862462513a2c7ce08668f09e8ce26 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/76929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib956a82461d862462513a2c7ce08668f09e8ce26 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Refactor SubchainInfo
by Code Review 17 May '17

17 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor SubchainInfo ...................................................................... core: Refactor SubchainInfo SubchainInfo will hold DiskImage instead of just the Guid and will have equals & hashCode, this was done to make this class usable in the new validation process of RemoveSnapshotCommand see commit: e981191a75537756dcc3e19f881a2b4314552aa5 Change-Id: I759d838fea0cfb7b375568f2dd5937b8a245e106 Bug-Url: https://bugzilla.redhat.com/1414472 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/ColdMergeSnapshotSingleDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubchainInfo.java 2 files changed, 63 insertions(+), 19 deletions(-) Approvals: Benny Zlotnik: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759d838fea0cfb7b375568f2dd5937b8a245e106 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: he: Update existing HE VM to use urandom RNG source
by Code Review 17 May '17

17 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: he: Update existing HE VM to use urandom RNG source ...................................................................... he: Update existing HE VM to use urandom RNG source Previously created HE VMs should be updated to use urandom RNG instead of random to match newly created ones. Change-Id: I68702c4ae9f772976ebbdebf5bf8e049b7654494 Bug-Url: https://bugzilla.redhat.com/1413845 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0250_update_rng_to_use_urandom_in_hostedengine_vm.sql 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68702c4ae9f772976ebbdebf5bf8e049b7654494 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Set title on RemoveExternalSubnet dialog
by Code Review 17 May '17

17 May '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: Set title on RemoveExternalSubnet dialog ...................................................................... webadmin: Set title on RemoveExternalSubnet dialog Set title on RemoveExternalSubnet dialog, because if the title is not set, it is shown as the string "undefined". Change-Id: I7f05ad39bc0502fb817c117a85504f5a466ee171 Bug-Url: https://bugzilla.redhat.com/1447635 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveExternalSubnetModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f05ad39bc0502fb817c117a85504f5a466ee171 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveStoragePool - allowed domain statuses
by Code Review 17 May '17

17 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: RemoveStoragePool - allowed domain statuses ...................................................................... core: RemoveStoragePool - allowed domain statuses This patch prevents removing a DC while there's a domain which isn't on Maintenance status. Currently we allow to remove a DC when there's a domain in Inactive status, while it still may be accessed by some of the hosts. This patch changes that and allows to remove a DC only when its domains are on Maintenance status - an Inactive domains must be deactivated prior to removing the DC. Change-Id: I784ad9758de867b5092f06761ba9f0880fd6436d Bug-Url: https://bugzilla.redhat.com/1418020 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 29 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/71399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I784ad9758de867b5092f06761ba9f0880fd6436d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Detach/Remove SD - allowed domain status
by Code Review 17 May '17

17 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: Detach/Remove SD - allowed domain status ...................................................................... core: Detach/Remove SD - allowed domain status This patch prevents detaching/removing a SD while the domain status isn't Maintenance. The PreparingForMaintenance status was added in order to make sure that when a domain moves to Maintenance status it's not accessed by any host in the data center. Currently we allow to detach/remove(a local sd) when the domain status is Inactive, while on that status it still may be accessed by some of the hosts. This patch changes that and allows to detach/remove a SD only when its on Maintenance status - an Inactive domain must be deactivated prior to being detached. Change-Id: I4c18dee175c457aa7aed5ee5bfc8b9803c1aba9d Bug-Url: https://bugzilla.redhat.com/1418020 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/VdcActionUtilsTest.java 4 files changed, 10 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/71398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c18dee175c457aa7aed5ee5bfc8b9803c1aba9d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveStoragePoolCommandTest - shared code/test cases
by Code Review 17 May '17

17 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: RemoveStoragePoolCommandTest - shared code/test cases ...................................................................... core: RemoveStoragePoolCommandTest - shared code/test cases 1. Using shared code to test the different domain statuses. 2. Making the tests generic and undependent in newly added domain statuses. Change-Id: I5fe253b8c53a7c5ba3aa4364a03f17218488470f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommandTest.java 1 file changed, 23 insertions(+), 90 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/76529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fe253b8c53a7c5ba3aa4364a03f17218488470f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix free space validation when performing merge
by Code Review 17 May '17

17 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: fix free space validation when performing merge ...................................................................... core: fix free space validation when performing merge When performing a merge operation on snapshot consisting of multiple disks on the same storage domain, the operation will fail because of IllegalStateException caused by duplicate key, because a separate entry is created for each disk and because they are on the same storage domain, the map will have the same key for multiple entries. This is solved by mapping a storage domain (guid) to a list of SubchainInfo instead, this way all subchains from the same domain will be under the same entry. Change-Id: Ie60744140d84f979732e352559d49a1c1cfbf143 Bug-Url: https://bugzilla.redhat.com/1450866 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java 2 files changed, 18 insertions(+), 11 deletions(-) Approvals: Benny Zlotnik: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60744140d84f979732e352559d49a1c1cfbf143 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0