- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: frontend: display correct provider's certificate fingerprint
by oourfali＠redhat.com 18 Jan '15

18 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: display correct provider's certificate fingerprint ...................................................................... frontend: display correct provider's certificate fingerprint Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182756 Change-Id: I37d8801c57bc6090614a7d014f150b18b99119c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37d8801c57bc6090614a7d014f150b18b99119c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix storage allocation check when creating a VM snapshot
by amureini＠redhat.com 18 Jan '15

18 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix storage allocation check when creating a VM snapshot ...................................................................... core: Fix storage allocation check when creating a VM snapshot Allocation checks for memory and data volumes were done either way - whether the VM is running or not. This patch takes these volumes into consideration only when the VM is running. Change-Id: I085d49dc90053e375f829900c75d2fe72c263161 Bug-Url: https://bugzilla.redhat.com/1053752 Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 4 files changed, 68 insertions(+), 37 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/36889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I085d49dc90053e375f829900c75d2fe72c263161 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix storage allocation check for LSM
by amureini＠redhat.com 18 Jan '15

18 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix storage allocation check for LSM ...................................................................... core: Fix storage allocation check for LSM During LiveMigrateVmDisksCommand , a snapshot is taken on the source domain before actual migration. Validation should be for a new, empty AI (COW, SPARSE), but was done according to the actual disk data, which is not necessarily the above. Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702 Bug-Url: https://bugzilla.redhat.com/1099894 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/36892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: etl: upgraded to Talend DI 5.6.1
by ydary＠redhat.com 18 Jan '15

18 Jan '15

Yaniv Dary has submitted this change and it was merged. Change subject: etl: upgraded to Talend DI 5.6.1 ...................................................................... etl: upgraded to Talend DI 5.6.1 Change-Id: I025834fc15f45eb0b3146a34f5d49c081c7f77dc Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/aggregationtodaily_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/aggregationtohourly_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/configurationsync_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/dailytimekeepingjob_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/deletetimekeepingjob_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/historydelete_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/historyetl_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/hostconfigcheck_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/hourlytimekeepingjob_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/minimalversioncheck_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/osenumupdate_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/samplerunjobs_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/sampletimekeepingjob_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/statisticssync_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/validateinstallation_3_6/contexts/Default.properties M etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_6/AggregationToDaily.java M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_6/AggregationToHourly.java M etl_export/src/ovirt_engine_dwh/configurationsync_3_6/ConfigurationSync.java M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_6/DailyTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_6/DeleteTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/historydelete_3_6/HistoryDelete.java M etl_export/src/ovirt_engine_dwh/historyetl_3_6/HistoryETL.java M etl_export/src/ovirt_engine_dwh/hostconfigcheck_3_6/HostConfigCheck.java M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_6/HourlyTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_6/MinimalVersionCheck.java M etl_export/src/ovirt_engine_dwh/osenumupdate_3_6/OsEnumUpdate.java M etl_export/src/ovirt_engine_dwh/parallelrun_3_6/ParallelRun.java M etl_export/src/ovirt_engine_dwh/samplerunjobs_3_6/SampleRunJobs.java M etl_export/src/ovirt_engine_dwh/sampletimekeepingjob_3_6/SampleTimeKeepingJob.java M etl_export/src/ovirt_engine_dwh/statisticssync_3_6/StatisticsSync.java M etl_export/src/ovirt_engine_dwh/validateinstallation_3_6/ValidateInstallation.java M etl_export/src/routines/DataOperation.java M etl_export/src/routines/Mathematical.java M etl_export/src/routines/Numeric.java M etl_export/src/routines/Relational.java M etl_export/src/routines/StringHandling.java M etl_export/src/routines/TalendDataGenerator.java M etl_export/src/routines/TalendDate.java M etl_export/src/routines/TalendString.java M etl_export/src/routines/system/AssertCatcherUtils.java M etl_export/src/routines/system/BufferedOutput.java M etl_export/src/routines/system/Document.java M etl_export/src/routines/system/FastDateParser.java M etl_export/src/routines/system/FormatterUtils.java M etl_export/src/routines/system/GlobalResource.java A etl_export/src/routines/system/Hex.java M etl_export/src/routines/system/JSONObject.java M etl_export/src/routines/system/LocaleProvider.java M etl_export/src/routines/system/LogCatcherUtils.java M etl_export/src/routines/system/MRRunStat.java M etl_export/src/routines/system/MetterCatcherUtils.java M etl_export/src/routines/system/NestXMLTool.java A etl_export/src/routines/system/NoHeaderObjectInputStream.java A etl_export/src/routines/system/NoHeaderObjectOutputStream.java M etl_export/src/routines/system/ParserUtils.java A etl_export/src/routines/system/PasswordEncryptUtil.java A etl_export/src/routines/system/PigHelper.java M etl_export/src/routines/system/ResumeUtil.java M etl_export/src/routines/system/RunStat.java M etl_export/src/routines/system/RunTrace.java A etl_export/src/routines/system/RuntimeMap.java M etl_export/src/routines/system/RuntimeUtils.java M etl_export/src/routines/system/SharedDBConnection.java M etl_export/src/routines/system/StatCatcherUtils.java M etl_export/src/routines/system/StringUtils.java M etl_export/src/routines/system/TDieException.java M etl_export/src/routines/system/TRunJobException.java M etl_export/src/routines/system/TalendThread.java M etl_export/src/routines/system/TalendThreadPool.java M etl_export/src/routines/system/TalendThreadResult.java M etl_export/src/routines/system/TalendTimestampWithTZ.java A etl_export/src/routines/system/TraceBean.java A etl_export/src/routines/system/TraceDataBean.java A etl_export/src/routines/system/TraceStatusBean.java M etl_export/src/routines/system/TypeConvert.java M tos_project/code/routines/system/TalendDate_0.1.item M tos_project/code/routines/system/TalendDate_0.1.properties M tos_project/code/routines/system/TalendString_0.1.item M tos_project/code/routines/system/TalendString_0.1.properties M tos_project/context/connectionJDBC_3.6.properties M tos_project/process/AggregationToDaily_3.6.item M tos_project/process/AggregationToDaily_3.6.properties M tos_project/process/AggregationToHourly_3.6.item M tos_project/process/AggregationToHourly_3.6.properties M tos_project/process/ConfigurationSync_3.6.item M tos_project/process/ConfigurationSync_3.6.properties M tos_project/process/DailyTimeKeepingJob_3.6.item M tos_project/process/DailyTimeKeepingJob_3.6.properties M tos_project/process/DeleteTimeKeepingJob_3.6.item M tos_project/process/DeleteTimeKeepingJob_3.6.properties M tos_project/process/HistoryDelete_3.6.item M tos_project/process/HistoryDelete_3.6.properties M tos_project/process/HistoryETL_3.6.item M tos_project/process/HistoryETL_3.6.properties M tos_project/process/HostConfigCheck_3.6.item M tos_project/process/HostConfigCheck_3.6.properties M tos_project/process/HourlyTimeKeepingJob_3.6.item M tos_project/process/HourlyTimeKeepingJob_3.6.properties M tos_project/process/MinimalVersionCheck_3.6.item M tos_project/process/MinimalVersionCheck_3.6.properties M tos_project/process/OsEnumUpdate_3.6.item M tos_project/process/OsEnumUpdate_3.6.properties M tos_project/process/ParallelRun_3.6.item M tos_project/process/ParallelRun_3.6.properties M tos_project/process/SampleRunJobs_3.6.item M tos_project/process/SampleRunJobs_3.6.properties M tos_project/process/SampleTimeKeepingJob_3.6.item M tos_project/process/SampleTimeKeepingJob_3.6.properties M tos_project/process/StatisticsSync_3.6.item M tos_project/process/StatisticsSync_3.6.properties M tos_project/process/ValidateInstallation_3.6.item M tos_project/process/ValidateInstallation_3.6.properties M tos_project/talend.project 114 files changed, 9,620 insertions(+), 9,357 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I025834fc15f45eb0b3146a34f5d49c081c7f77dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: replace b7319df0
by ahadas＠redhat.com 18 Jan '15

18 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: replace b7319df0 ...................................................................... core: replace b7319df0 b7319df0447ea5aed80752fdb924482298e3d1f0 introduced a solution for filtering duplicated events for successful hibernate operation. This patch replace it with a simpler implementation. Change-Id: I3f39bff153baef256def7cb405e51336fb571be7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f39bff153baef256def7cb405e51336fb571be7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: iSCSI multipath sub tab when SD is in maintenance.
by tnisan＠redhat.com 18 Jan '15

18 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: iSCSI multipath sub tab when SD is in maintenance. ...................................................................... core: iSCSI multipath sub tab when SD is in maintenance. iSCSI multipath sub tab should be available also when Storage Domains are in maintenance mode. Change-Id: Iafaa1010f500dc7c0ec71863fc20127d525bc4ac Bug-Url: https://bugzilla.redhat.com/1182779 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafaa1010f500dc7c0ec71863fc20127d525bc4ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: missing break
by lvernia＠redhat.com 18 Jan '15

18 Jan '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: missing break ...................................................................... webadmin: missing break Change-Id: I24a4e60e849093401c985ea204f5afcfe922bec4 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a4e60e849093401c985ea204f5afcfe922bec4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 16 Jan '15

16 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 4f0c48e, corresponding to 3.5.1 RC. Change-Id: I6c46ea0e38855fbe0588a94be76226bccf13c8a5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/pom.xml M ovirt-engine-sdk-java/spec.el6.in M ovirt-engine-sdk-java/spec.el7.in M ovirt-engine-sdk-java/spec.fc20.in M ovirt-engine-sdk-java/spec.fc21.in M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Action.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Host.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/HostProtocols.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/SPM.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/SpmStates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/StorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VersionCaps.java 26 files changed, 981 insertions(+), 47 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c46ea0e38855fbe0588a94be76226bccf13c8a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 16 Jan '15

16 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 4f0c48e, corresponding to 3.5.1 RC. Change-Id: Ic25877f641e1e60619131bacf6ddc2515c14a270 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M generator/src/main/resources/api.rsdl M generator/src/main/resources/api.xsd M ovirt-engine-sdk-python.spec.in M setup.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 7 files changed, 619 insertions(+), 43 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25877f641e1e60619131bacf6ddc2515c14a270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve GWT build
by vszocs＠redhat.com 16 Jan '15

16 Jan '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve GWT build ...................................................................... webadmin,userportal: Improve GWT build 1. new Makefile variables with following defaults: # Maven JVM options. BUILD_JAVA_OPTS_MAVEN [-XX:MaxPermSize=512M] # GWT compiler and Dev Mode JVM options. BUILD_JAVA_OPTS_GWT [] Above variables can also be defined using env. variables, so both examples below are valid use cases: $ make clean install-dev [usual options] \ BUILD_JAVA_OPTS_GWT="..." $ export BUILD_JAVA_OPTS_GWT="..." \ && make clean install-dev [usual options] In a typical environment, you'll want to: * leave BUILD_JAVA_OPTS_MAVEN as it is * define BUILD_JAVA_OPTS_GWT only if the build system is low on physical memory, along with -Dgwt.compiler.localWorkers=1 to minimize GWT compiler memory footprint If BUILD_JAVA_OPTS_GWT is empty (default), following fallback value is used implicitly: -Xms1024M -Xmx8192M \ -XX:PermSize=512M -XX:MaxPermSize=1024M This is to ensure reasonable GWT compiler JVM options without the need to customize BUILD_JAVA_OPTS_GWT for each build. 2. in Makefile "maven" target, changed: export MAVEN_OPTS="..." $(MVN) ... to be: MAVEN_OPTS="..." $(MVN) 3. in Makefile "gwt-debug" target, changed: cd "path/to/gwt/module" && $(MVN) ... to be: $(MVN) -pl "path/to/gwt/module" ... 4. in "frontend modules" pom.xml, removed redundant <groupId> as it's inherited from <parent> Maven module anyway. Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M README.developer M frontend/webadmin/modules/pom.xml 3 files changed, 39 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0