- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: MAC pool elements must be optional
by juan.hernandez＠redhat.com 14 Jan '15

14 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: MAC pool elements must be optional ...................................................................... restapi: MAC pool elements must be optional Currently the "allow_duplicates" element of the MAC pool type of the XML schema is mandatory. This means that links to the MAC pools fail XML schema validation. For example, a link like the following will fail validation because it doesn't have the mandatory "allow_duplicates" nested element: <mac_pool href="..." id="..."/> In general all elements of XML complex types that may be used as links need to be optional. This patch changes the XML schema so that the "allow_duplicates" element is optional. Change-Id: Ie35fcae56df17619bdb0464699e7a154b4765d89 Bug-Url: https://bugzilla.redhat.com/1181711 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie35fcae56df17619bdb0464699e7a154b4765d89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: Added makefile for build system
by juan.hernandez＠redhat.com 14 Jan '15

14 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: Added makefile for build system ...................................................................... Added makefile for build system The common build system expects a makefile at the root of the repo with a dist target to generate the tarball. Change-Id: I4a06f04ae75b2e3d6f3d2e174e72b8c9a22accd7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A Makefile M ovirt-engine-sdk-java/Makefile 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/36840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a06f04ae75b2e3d6f3d2e174e72b8c9a22accd7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to co...
by piotr.kliczewski＠gmail.com 14 Jan '15

14 Jan '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to common ...................................................................... packaging: setup: websocket-proxy: SETUP_ATTRS_MODULES to common Without this, utilities other than setup (currently rename) drop wsp constants from postinstall. Bug-Url: https://bugzilla.redhat.com/1181691 Change-Id: I2825c3db19b252464c6fe2dcdad7daa963462399 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 19b50a7dfc25fc98b9d2b9e23a01a9fb2c4b9ac7) --- M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2825c3db19b252464c6fe2dcdad7daa963462399 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: replace ArrayList with List
by ahadas＠redhat.com 14 Jan '15

14 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: frontend: replace ArrayList with List ...................................................................... frontend: replace ArrayList with List In runMultipleActions methods, replace the type of the parameters list to be List instead of ArrayList. Change-Id: Ifca8c85aad72517f02c4a1285211b94ff7b4e874 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifca8c85aad72517f02c4a1285211b94ff7b4e874 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: setup: Changing task cleaner utility to also handle removal ...
by oourfali＠redhat.com 14 Jan '15

14 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: setup: Changing task cleaner utility to also handle removal of commands ...................................................................... setup: Changing task cleaner utility to also handle removal of commands The task cleaner utility now has the ability to present all commands or commands with running tasks, and to erase commands (or commands with running tasks) Bug-Url: https://bugzilla.redhat.com/1161012 Change-Id: I753c6343496ffe7c70c0c66ed8ab3facbcb533e8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 157 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I753c6343496ffe7c70c0c66ed8ab3facbcb533e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: don't reset custom device props if modified
by oourfali＠redhat.com 14 Jan '15

14 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: don't reset custom device props if modified ...................................................................... core: don't reset custom device props if modified This patch changes the upgrade of CustomDeviceProperties such that if a customer changes the value of this configuration and after that upgrades to a new version, the settings for this key for this version will be preserved. This will tale affect only when upgrading to other minor version i.e from 3.5.0 to 3.5.1 for example For a major version, a new key is generated with the default value Change-Id: If77c367ec0fea2c9db8475f659b403fee9ded7e4 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1177803 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If77c367ec0fea2c9db8475f659b403fee9ded7e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix skip fencing if host connected to storage
by oourfali＠redhat.com 14 Jan '15

14 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix skip fencing if host connected to storage ...................................................................... core: Fix skip fencing if host connected to storage Fixes skip fencing if host connected to storage which was broken due to refactoring done in 31cd7918c9c5eb5c2d6ddf5526b366fdb2d0f4bc Change-Id: I84fa56e75adf988ce36b1154269dab8974cf05bf Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 4 files changed, 46 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84fa56e75adf988ce36b1154269dab8974cf05bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.1_rc respin
by ydary＠redhat.com 14 Jan '15

14 Jan '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.1_rc respin ...................................................................... build: post ovirt-engine-reports-3.5.1_rc respin Change-Id: I3f70e149c3bc504e158b9cb15ce2926d91d33689 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f70e149c3bc504e158b9cb15ce2926d91d33689 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.1_rc respin
by ydary＠redhat.com 14 Jan '15

14 Jan '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.1_rc respin ...................................................................... build: ovirt-engine-reports-3.5.1_rc respin build ovirt-engine-reports-3.5.1_rc and added release notes. Change-Id: If8377053186af035e5fc0c3fbafce39806c06a90 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8377053186af035e5fc0c3fbafce39806c06a90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.1_rc respin
by ydary＠redhat.com 14 Jan '15

14 Jan '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5.1_rc respin ...................................................................... build: post ovirt-engine-dwh-3.5.1_rc respin Change-Id: I331f3be959c0c0c5e26da21def8229396ee72f82 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331f3be959c0c0c5e26da21def8229396ee72f82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0