- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core, engine: Do not count sPAPR VLAN devices as PCI
by tnisan＠redhat.com 27 Oct '14

27 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine: Do not count sPAPR VLAN devices as PCI ...................................................................... core, engine: Do not count sPAPR VLAN devices as PCI The checkPciAndIdeLimits function accounted sPAPR VLAN devices as PCI, but these devices have their own bus (the spapr-vio bus). This change skips these devices in the total count of PCI devices done in the VM related commands. Change-Id: Iab14ae25f59cd77e29ef444bb1887911a2dcdb05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076518 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab14ae25f59cd77e29ef444bb1887911a2dcdb05 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine, db: Enable suspend, migration and memory snaps...
by tnisan＠redhat.com 27 Oct '14

27 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine, db: Enable suspend, migration and memory snapshots in ppc64 ...................................................................... core, engine, db: Enable suspend, migration and memory snapshots in ppc64 This patch enables features that are working in PowerKVM: VM suspend, migration and memory snapshots. Change-Id: Ic4e1bddae604f4266af40f45fab40592907b007a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156186 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 11 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e1bddae604f4266af40f45fab40592907b007a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: 'Comment' property of existing VM pool dialog edit...
by tjelinek＠redhat.com 27 Oct '14

27 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: 'Comment' property of existing VM pool dialog editable ...................................................................... webadmin: 'Comment' property of existing VM pool dialog editable The problem was that the PoolEditPopupWidget.disableAllTabs(); disabled all the widgets and the subsequent PoolEditPopupWidget. enableEditPoolFields(object); did not enable it. Fixed by adding the missing commentEditor.setEnabled(true); to enableEditPoolFields Change-Id: I9fe10ea813636a271e1663009d24b6def0072939 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013699 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified -- To view, visit http://gerrit.ovirt.org/34414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fe10ea813636a271e1663009d24b6def0072939 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Fix appmode options order
by tnisan＠redhat.com 27 Oct '14

27 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Fix appmode options order ...................................................................... packaging: setup: Fix appmode options order Modified setup Application Mode options ordering to show 'Both' as last option, after 'Virt' and 'Gluster', as it's more intuitive that way. Change-Id: I194b236c20041187e3b95988069338784328a000 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1147678 --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I194b236c20041187e3b95988069338784328a000 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: changed package name for TransportFactory
by yzaslavs＠redhat.com 27 Oct '14

27 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: changed package name for TransportFactory ...................................................................... core: changed package name for TransportFactory Change-Id: I206f5f425f2de90839f9d350505e14fa8b153d7f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/TransportFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I206f5f425f2de90839f9d350505e14fa8b153d7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: upload: raising an execption on bad gzip files
by sbonazzo＠redhat.com 27 Oct '14

27 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: raising an execption on bad gzip files ...................................................................... upload: raising an execption on bad gzip files Raising an exception to mimic past bahavior Change-Id: I76ae1a09b52a53a09e351c97eccad300952ae539 Bug-Url: https://bugzilla.redhat.com/1156107 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit b79bcd11a2d515dfddb4fc21ac0efc06a334b23e) --- M src/__main__.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76ae1a09b52a53a09e351c97eccad300952ae539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[master]: upload: raising an execption on bad gzip files
by sbonazzo＠redhat.com 27 Oct '14

27 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: raising an execption on bad gzip files ...................................................................... upload: raising an execption on bad gzip files Raising an exception to mimic past bahavior Change-Id: I76ae1a09b52a53a09e351c97eccad300952ae539 Bug-Url: https://bugzilla.redhat.com/1156107 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76ae1a09b52a53a09e351c97eccad300952ae539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: manage-domains: respect ConfigValues.SASL_QOP
by yzaslavs＠redhat.com 27 Oct '14

27 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: manage-domains: respect ConfigValues.SASL_QOP ...................................................................... tools: manage-domains: respect ConfigValues.SASL_QOP in one of the ugliest piece of code I've ever seen. the cli does not respect the configuration of the application. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1156577 Change-Id: I4fad86b7b2a1437607acf9562ac898ac455c10dd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/JndiAction.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KerberosConfigCheck.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ConfigurationProvider.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java 4 files changed, 19 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fad86b7b2a1437607acf9562ac898ac455c10dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent maintenance a host with hard affinity
by gchaplik＠redhat.com 27 Oct '14

27 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: prevent maintenance a host with hard affinity ...................................................................... core: prevent maintenance a host with hard affinity Maintenance a host can break the affinity rule of its running vm The user should be aware of it, and manually handle it: soften the affinity rule or migrate the VMs. Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Bug-Url: https://bugzilla.redhat.com/1084794 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AffinityGroupDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/affinity_groups_sp.sql 10 files changed, 101 insertions(+), 11 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: medium Instance Type mismatch feature page
by tjelinek＠redhat.com 27 Oct '14

27 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: medium Instance Type mismatch feature page ...................................................................... core: medium Instance Type mismatch feature page According to feature page, in medium instance type, total virtual CPUs should be 2, but it is 1. Fixed by updating this property in the DB. The update statement tries to be as specific about the instance type as possible, but since it is not possible to use it's ID which was generated, it relyes on the name/description + some configuration. Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d Bug-Url: https://bugzilla.redhat.com/1142924 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0470_medium_instance_type_has_two_cpus.sql 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0