- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add snapshot id to snapshot preview RSDL
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add snapshot id to snapshot preview RSDL ...................................................................... restapi: Add snapshot id to snapshot preview RSDL The snapshot preview action requires a snapshot id for each disk, but this isn't currently documented in the RSDL metadata. This patch adds the documentation. Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Bug-Url: https://bugzilla.redhat.com/1150071 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b0b4731d127496b1c9622c54fd3fe48309d9f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, frontend: Query to get raw provider certificates
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: core, frontend: Query to get raw provider certificates ...................................................................... core, frontend: Query to get raw provider certificates Currently we have a query that retrieves the certificates of an external provider converted to a string, and this string is displayed to the user. The RESTAPI can't easily consume this text, it should rather get the raw certificates and render them so that callers can decide what information to extract. To make this possible this patch renames the existing query, to make it clear that it returns just the text, and adds a new one that returns the raw certificates, intended for use by the RESTAPI. Change-Id: Ie5270bff9b671943fdea1c31369b7ad1d0dd4f67 Related-To: https://bugzilla.redhat.com/1132259 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainTextQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 4 files changed, 73 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5270bff9b671943fdea1c31369b7ad1d0dd4f67 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add version 3.6
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add version 3.6 ...................................................................... restapi: Add version 3.6 This patch adds version 3.6 to the capabilities resource. Change-Id: I73266b8e38241dece9e3937297bdc397740469b5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73266b8e38241dece9e3937297bdc397740469b5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add collection for operating systems
by juan.hernandez＠redhat.com 23 Oct '14

23 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add collection for operating systems ...................................................................... restapi: Add collection for operating systems This patch adds a new top level "operatingsystems" read only collection: GET /operatingsystems <operating_systems> <operating_system id="0"> <name>other</name> <description>Other OS</description> </operating_system> ... </operating_systems> GET /operatingsystems/0 <operating_system id="0"> <name>other</name> <description>Other OS</description> </operating_system> Change-Id: Ibae9977a6fbfc8728ee66e705f0594f230ff47ba Bug-Url: https://bugzilla.redhat.com/1050243 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/OperatingSystemResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/OperatingSystemsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 10 files changed, 257 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae9977a6fbfc8728ee66e705f0594f230ff47ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: HostKSM: Gracefully handle ksmd pid lookup failure
by alitke＠redhat.com 23 Oct '14

23 Oct '14

Adam Litke has submitted this change and it was merged. Change subject: HostKSM: Gracefully handle ksmd pid lookup failure ...................................................................... HostKSM: Gracefully handle ksmd pid lookup failure In case the pid of ksmd cannot be found we currently fail with a ValueError exception. Check the pidof return code before trying to convert the output to an int. If the pid cannot be found, then report 0 for get_ksmd_jiffies(). Change-Id: Iccd14ee44f4f7d8d9107e692c9faa27e7c487790 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152182 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/34378 Reviewed-by: Francesco Romani <fromani(a)redhat.com> --- M mom/Collectors/HostKSM.py 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccd14ee44f4f7d8d9107e692c9faa27e7c487790 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Fix appmode options order
by sbonazzo＠redhat.com 23 Oct '14

23 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Fix appmode options order ...................................................................... packaging: setup: Fix appmode options order Modified setup Application Mode options ordering to show 'Both' as last option, after 'Virt' and 'Gluster', as it's more intuitive that way. Change-Id: I194b236c20041187e3b95988069338784328a000 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1147678 --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I194b236c20041187e3b95988069338784328a000 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: list Ubuntu 14.04 as an operating system
by tjelinek＠redhat.com 23 Oct '14

23 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: list Ubuntu 14.04 as an operating system ...................................................................... engine: list Ubuntu 14.04 as an operating system Add Ubuntu 14.04 as an operating system to new/edit vms dialog. Change-Id: I38c296b00167821b6f17352c81c5dc260e313070 Bug-Url: https://bugzilla.redhat.com/1101219 Signed-off-by: Rene Koch <rkoch(a)linuxland.at> Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/ubuntu_14_04.jpg A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/ubuntu_14_04.jpg M packaging/conf/osinfo-defaults.properties 4 files changed, 23 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38c296b00167821b6f17352c81c5dc260e313070 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rene Koch <rkoch(a)linuxland.at> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Rene Koch <rkoch(a)linuxland.at> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, restapi, engine: Avoid enabling balloon device on VM edit
by ofrenkel＠redhat.com 23 Oct '14

23 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, restapi,engine: Avoid enabling balloon device on VM edit ...................................................................... core, restapi,engine: Avoid enabling balloon device on VM edit Avoids the creation of a balloon device on every REST API call that changes any of attibute of a VM. Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152991 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Vitor de Lima: Verified Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ba4e286eab5195b763843cd1adaaeb273070de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Events tab message column too narrow
by tnisan＠redhat.com 23 Oct '14

23 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Events tab message column too narrow ...................................................................... webadmin: Events tab message column too narrow The message column in events tab is too narrow in basic view. There is lots of space unused and the message column should use available space in basic view. Change-Id: I10cfae5d4fec96a091981b3768648b3a908aa41a Bug-Url: https://bugzilla.redhat.com/1149491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10cfae5d4fec96a091981b3768648b3a908aa41a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: RemoveDiskSnapshots - sort non-consecutive images
by tnisan＠redhat.com 23 Oct '14

23 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - sort non-consecutive images ...................................................................... core: RemoveDiskSnapshots - sort non-consecutive images RemoveDiskSnapshots -> initTaskHandlers: fix images sorting in case of non consecutive images (e.g. image_index_0, image_index_3, image_index_7). Change-Id: Ia736aa93a76dd8df13bfdcf97587cee82bea6700 Bug-Url: https://bugzilla.redhat.com/1151841 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia736aa93a76dd8df13bfdcf97587cee82bea6700 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0