- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Add uniqueness test to AuditLogValue
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add uniqueness test to AuditLogValue ...................................................................... core: Add uniqueness test to AuditLogValue Since the audit log value is supposed to be unique, this test will enforce the uniqueness of the audit log values Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/AuditLogTypeTest.java 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e3f58d7ccf8a6477fafbac94d6e1057ecefe23a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Change duplicate audit log values to unique ones
by oourfali＠redhat.com 22 Oct '14

22 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Change duplicate audit log values to unique ones ...................................................................... core: Change duplicate audit log values to unique ones Since the audit log value is supposed to be unique, a test will be added to enforce uniqueness of the audit log values prior to that, since we have duplicate values in the AuditLogType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: Ife969c6a094ba8acf4b7b1544be017d8a034485f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 34 insertions(+), 34 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife969c6a094ba8acf4b7b1544be017d8a034485f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing CR char after encoding
by ofrenkel＠redhat.com 22 Oct '14

22 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: removing CR char after encoding ...................................................................... core: removing CR char after encoding Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 14 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Removed "-" from "Data-Centers" in UIConstants
by tnisan＠redhat.com 22 Oct '14

22 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Removed "-" from "Data-Centers" in UIConstants ...................................................................... frontend: Removed "-" from "Data-Centers" in UIConstants To be consistent with the UI's terminology, the phrase "Data-Centers" was replaced with "Data Centers" in two UI constants. Change-Id: I39411ebc018bdc11e4692ebc9c2909ef399f40a7 Bug-Url: https://bugzilla.redhat.com/1141794 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39411ebc018bdc11e4692ebc9c2909ef399f40a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Removed "-" from "Data-Centers" in Err Msg
by tnisan＠redhat.com 22 Oct '14

22 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Removed "-" from "Data-Centers" in Err Msg ...................................................................... frontend: Removed "-" from "Data-Centers" in Err Msg To be consistent with the UI's terminology, the error message "There are no active Data-Centers in the system." was changed to "There are no active Data Centers in the system.". Change-Id: Ie1cdf14e67366b7007a64dc24e127623cfeee2c9 Bug-Url: https://bugzilla.redhat.com/1141794 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cdf14e67366b7007a64dc24e127623cfeee2c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Removed "-" from "Data-Centers" in UIConstants
by tnisan＠redhat.com 22 Oct '14

22 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Removed "-" from "Data-Centers" in UIConstants ...................................................................... frontend: Removed "-" from "Data-Centers" in UIConstants To be consistent with the UI's terminology, the phrase "Data-Centers" was replaced with "Data Centers" in two UI constants. Change-Id: I39411ebc018bdc11e4692ebc9c2909ef399f40a7 Bug-Url: https://bugzilla.redhat.com/1141794 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39411ebc018bdc11e4692ebc9c2909ef399f40a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix visibility issues in VM/Template import confli...
by tnisan＠redhat.com 22 Oct '14

22 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix visibility issues in VM/Template import conflict dialog ...................................................................... webadmin: Fix visibility issues in VM/Template import conflict dialog Change-Id: I5038eab75d71408b1336ae445e8ee2bb93e0cca8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1149490 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.ui.xml 7 files changed, 17 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5038eab75d71408b1336ae445e8ee2bb93e0cca8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Correct text in storage domain maintenance popup
by tnisan＠redhat.com 22 Oct '14

22 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correct text in storage domain maintenance popup ...................................................................... webadmin: Correct text in storage domain maintenance popup Change-Id: Ibbf8cefe6bfebf034789a696750c19e749b00d10 Bug-Url: https://bugzilla.redhat.com/1149476 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbf8cefe6bfebf034789a696750c19e749b00d10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup MigrateVmToServerCommand#canDoAction
by ahadas＠redhat.com 21 Oct '14

21 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup MigrateVmToServerCommand#canDoAction ...................................................................... core: cleanup MigrateVmToServerCommand#canDoAction Change-Id: Ida781a939463a29597944a9c5adf48cf539d621d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida781a939463a29597944a9c5adf48cf539d621d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: build: post ovirt-hosted-engine-ha-1.2.4
by sbonazzo＠redhat.com 21 Oct '14

21 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2.4 ...................................................................... build: post ovirt-hosted-engine-ha-1.2.4 Change-Id: I306bfed439e30ff3c659d07271ddf3a5ab0755c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I306bfed439e30ff3c659d07271ddf3a5ab0755c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0