- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: import CA cert into external provider keystore
by Code Review 09 May '17

09 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: import CA cert into external provider keystore ...................................................................... packaging: import CA cert into external provider keystore Importing the CA cert used to sign the provider cert into the external providers keystore Bug-Url: https://bugzilla.redhat.com/1436154 Change-Id: I82e762f4f531fb70490a049dad44974eda06dcde Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e762f4f531fb70490a049dad44974eda06dcde Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: ovirt-provider-ovn pki setup
by Code Review 09 May '17

09 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-provider-ovn pki setup ...................................................................... packaging: ovirt-provider-ovn pki setup This patch configures the pki infrastructure required by ovirt-provider-ovn: - generate key/csr for: - ovn north db - ovn south db - ovirt-provider-ovn https - create engine CA signed certificates for the above - configure ssl for OVN north and south databases - open ssl connections for OVN north and south databases - configure ovirt-provider-ovn for ssl by modifying the provider conf file Change-Id: I9cf960da30bb1ca6e7637ee06438f226a90d4c86 Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1436154 --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 266 insertions(+), 31 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cf960da30bb1ca6e7637ee06438f226a90d4c86 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Update vnics address and alias after hot plug
by Code Review 09 May '17

09 May '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: Update vnics address and alias after hot plug ...................................................................... engine: Update vnics address and alias after hot plug Bug-Url: https://bugzilla.redhat.com/1436983 Change-Id: I48449fd34008fe8e5d9df7d7703819d128b786c2 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoReturn.java 5 files changed, 71 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48449fd34008fe8e5d9df7d7703819d128b786c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: memory devices should not be added on run vm
by Code Review 09 May '17

09 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: memory devices should not be added on run vm ...................................................................... core: memory devices should not be added on run vm Memory devices are inteded only for hot-plug memory flow, not for run-VM flow. Change-Id: Ic4e511ae2c6f266d2514ad24e2df027f01b8ab95 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/76597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e511ae2c6f266d2514ad24e2df027f01b8ab95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: merge: validate available space before merge
by Code Review 09 May '17

09 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: merge: validate available space before merge ...................................................................... merge: validate available space before merge Introducing StorageDomainValidator#hasSpaceForMerge method for calculating required space when performing live/cold merge. The calculation is performed adhering to these rules when performing new (4.1+) merge operation: | File Domain | Block Domain -----|--------------------------------------------------|-------------- qcow | min(virtual_size(top) * 1.1 - actual_size(base), | | actual_size(top)) | same as file -----|--------------------------------------------------|-------------- raw | min(virtual_size(top) / 1.1, | | virtual_size(base) - actual_size(base)) | 0 | | * The qcow/raw refers to the base snapshot format * base/top - base snapshot/ top snapshot * 1.1 - qcow2 overhead This is made for both live and cold merge 4.1+. If we are performing cold merge pre-4.1, we take min(actual(base) + actual(top), virtual(top)) Change-Id: Ib0f41199708593b2df671e1f0132ae813c2e996d Bug-Url: https://bugzilla.redhat.com/1414472 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java M packaging/dbscripts/disk_images_sp.sql 9 files changed, 214 insertions(+), 14 deletions(-) Approvals: Benny Zlotnik: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0f41199708593b2df671e1f0132ae813c2e996d Gerrit-PatchSet: 42 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Refactor SubchainInfo
by Code Review 09 May '17

09 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Refactor SubchainInfo ...................................................................... core: Refactor SubchainInfo SubchainInfo will hold DiskImage instead of just the Guid and will have equals & hashCode, this was done to make this class usable in the new validation process of RemoveSnapshotCommand see commit: e981191a75537756dcc3e19f881a2b4314552aa5 Change-Id: I759d838fea0cfb7b375568f2dd5937b8a245e106 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/ColdMergeSnapshotSingleDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubchainInfo.java 2 files changed, 63 insertions(+), 19 deletions(-) Approvals: Benny Zlotnik: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759d838fea0cfb7b375568f2dd5937b8a245e106 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove UpdateClusterNetworkClusterValidator
by Code Review 09 May '17

09 May '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove UpdateClusterNetworkClusterValidator ...................................................................... engine: remove UpdateClusterNetworkClusterValidator The change enables adding a detached cluster to a DC Prior the change adding a detached non-empty cluster to a DC, failed with "changing the management network in a non-empty cluster" message. On the other hand after adding a detached cluster with hosts to a DC, the actual network that the engine communicates with the hosts in this cluster might be different from the declared management network. Change-Id: I7525fbf7cc7838192df131321bf1935823e3004d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java 4 files changed, 5 insertions(+), 100 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/75710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7525fbf7cc7838192df131321bf1935823e3004d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: Don't fail automation when no test files exists
by Code Review 09 May '17

09 May '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: automation: Don't fail automation when no test files exists ...................................................................... automation: Don't fail automation when no test files exists The 'rename' operation will exist with code 4 when there where no files to rename. It means that probably no tests ran, and that should not fail the execution. Change-Id: Ie0d72f60e2a3eac7779bab0c0e8b130982efcb3e Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-patch.sh 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Barak Korren: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d72f60e2a3eac7779bab0c0e8b130982efcb3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Initial size in copy template disk flow
by Code Review 08 May '17

08 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: engine: Initial size in copy template disk flow ...................................................................... engine: Initial size in copy template disk flow Fix done in c556b3b1acf4c5 (engine: Initial size in copy template disk flow) was wrongly reverted in dcf953e7334 (Revert "backend: refactoring: Migrate ImagesHandler to CDI"). This patch revert to the original fix. Change-Id: I1e4217f35049a7fec655ab1787c7401b47f8fcf1 Bug-Url: https://bugzilla.redhat.com/1438691 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java 2 files changed, 44 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4217f35049a7fec655ab1787c7401b47f8fcf1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Make disk events creation explicit
by Code Review 08 May '17

08 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Make disk events creation explicit ...................................................................... engine: Make disk events creation explicit Instead of passing various created hashmap for method to create events, the creation of event can be explicit and using the common event api of adding custom values. Change-Id: I278708bb22bcc33dc51c819e206ebfe9dcb63768 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MetadataDiskDescriptionHandler.java 1 file changed, 15 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278708bb22bcc33dc51c819e206ebfe9dcb63768 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0