- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: VmPayload needs to inherit from VmDevice
by shavivi＠redhat.com 07 Oct '14

07 Oct '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: VmPayload needs to inherit from VmDevice ...................................................................... engine: VmPayload needs to inherit from VmDevice It is represent a device and we need the Address and the Id for stable devices. Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Bug-Url: https://bugzilla.redhat.com/1138314 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 13 files changed, 67 insertions(+), 46 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: fail the build if osinfo-defaults.properties fail...
by sbonazzo＠redhat.com 07 Oct '14

07 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ...................................................................... packaging: fail the build if osinfo-defaults.properties fails to parse check the properties file we ship with the exact code that checks it at runtime when the engine loads. this test is hooked into the packaging process and must fail it. Bug-Url: https://bugzilla.redhat.com/1056965 Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M Makefile A build/validations/pom.xml A build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java 3 files changed, 49 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: localize quota strings
by gchaplik＠redhat.com 07 Oct '14

07 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: localize quota strings ...................................................................... userportal: localize quota strings 'unlimited' and 'exceeded' strings are hardcoded. Change-Id: I33f3b3967b7d2db58998428755390714f49ad4a6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f3b3967b7d2db58998428755390714f49ad4a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Set Migrate On Error in Data Center Guide Me
by tjelinek＠redhat.com 07 Oct '14

07 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Set Migrate On Error in Data Center Guide Me ...................................................................... webadmin: Set Migrate On Error in Data Center Guide Me The Add Cluster dialog in the Data Center "Guide Me" was not setting the chosen Migrate On Error action in the VDSGroup instance that is sent to the AddVdsGroup command. Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142658 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Tomas Jelinek: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Prevent duplicates in versionlock
by sbonazzo＠redhat.com 07 Oct '14

07 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Prevent duplicates in versionlock ...................................................................... packaging: setup: Prevent duplicates in versionlock Change-Id: I1f194a8e3162a356d30a4d106bf522dad1c4a79d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/33853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f194a8e3162a356d30a4d106bf522dad1c4a79d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix regression caused by commit bbc92533583a831dbf...
by awels＠redhat.com 06 Oct '14

06 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: frontend: Fix regression caused by commit bbc92533583a831dbfe32fa980772347e6111f76 ...................................................................... frontend: Fix regression caused by commit bbc92533583a831dbfe32fa980772347e6111f76 Forgot to generify ListModelListBoxEditor along with edited model. Change-Id: Ib33f71385aeb9c5459ecb6f391ccf9ddeea8d29d Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib33f71385aeb9c5459ecb6f391ccf9ddeea8d29d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding API for Cluster Fencing Policy
by juan.hernandez＠redhat.com 06 Oct '14

06 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: adding API for Cluster Fencing Policy ...................................................................... core: adding API for Cluster Fencing Policy This patch adds support for get/set/add cluster fencing policy from the REST API clusters retrieved from REST will have now the following section (example): <fencing_policy> <enabled>true</enabled> <skip_if_sd_active> <enabled>false</enabled> </skip_if_sd_active> <skip_if_connectivity_broken> <enabled>false</enabled> <threshold>50</threshold> </skip_if_connectivity_broken> </fencing_policy> Change-Id: I086e70890096b5e25cfeb8d519f235952087aa4f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127592 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/FencingPolicyMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/FencingPolicyMapperTest.java 5 files changed, 100 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I086e70890096b5e25cfeb8d519f235952087aa4f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename fields/setters/getters in VdsStatistics
by ahadas＠redhat.com 06 Oct '14

06 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: rename fields/setters/getters in VdsStatistics ...................................................................... core: rename fields/setters/getters in VdsStatistics Rename the fields, setters & getters in VdsStatistics to conform Java conventions Change-Id: Ib86f2600305d7c8718f1184be5cc3a4c5a3c2b65 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 7 files changed, 247 insertions(+), 247 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86f2600305d7c8718f1184be5cc3a4c5a3c2b65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Changed the PhysDevInitializationError msg
by tnisan＠redhat.com 06 Oct '14

06 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Changed the PhysDevInitializationError msg ...................................................................... core: Changed the PhysDevInitializationError msg Previously, the vdsm PhysDevInitializationError error message did not include the case that the device is not accessible by the host. The error message was changed to include this case. Change-Id: I528544cffa7c82958a18912461840ae276619bfc Bug-Url: https://bugzilla.redhat.com/974859 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/33862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I528544cffa7c82958a18912461840ae276619bfc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: error fix: removed statement negation
by tnisan＠redhat.com 06 Oct '14

06 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: error fix: removed statement negation ...................................................................... core: error fix: removed statement negation statement labelAdded() was mistakenly negated. Change-Id: I00966d8cb83b2d51562dcf4b5c5ab04fd01f448e Bug-Url: https://bugzilla.redhat.com/1134009 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00966d8cb83b2d51562dcf4b5c5ab04fd01f448e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0