- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Unassigned log type should not be logged
by masayag＠redhat.com 08 Sep '14

08 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Unassigned log type should not be logged ...................................................................... engine: Unassigned log type should not be logged The Unassigned log type is used to ignore a logging of an event. Hence, it should not appear in the resource bundle. Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Finalizing step typo
by oourfali＠redhat.com 08 Sep '14

08 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Finalizing step typo ...................................................................... core: Finalizing step typo Removed the full stop from "Finalizing." in order to match "Validating" and "Executing" steps. Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Bug-Url: https://bugzilla.redhat.com/1139311 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: setupNetworks not able to configure bridge
by oourfali＠redhat.com 08 Sep '14

08 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setupNetworks not able to configure bridge ...................................................................... core: setupNetworks not able to configure bridge For 2 calls we use ThreadPoolUtil. It was used to provide async network call for xmlrpc. Jsonrpc is async so from its prespective it makes no sense to use it. In order to keep the communication interface unchanged we need to returned Future. The future checked whether the call was executed not whether the response arrived. This patch makes sure that we wait for response and expose this information correctly. Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 4 files changed, 106 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: setupNetworks not able to configure bridge
by oourfali＠redhat.com 08 Sep '14

08 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setupNetworks not able to configure bridge ...................................................................... core: setupNetworks not able to configure bridge For 2 calls we use ThreadPoolUtil. It was used to provide async network call for xmlrpc. Jsonrpc is async so from its prespective it makes no sense to use it. In order to keep the communication interface unchanged we need to returned Future. The future checked whether the call was executed not whether the response arrived. This patch makes sure that we wait for response and expose this information correctly. Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 4 files changed, 106 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: use blank storage pool when connecting the volumes
by dfediuck＠redhat.com 08 Sep '14

08 Sep '14

Doron Fediuck has submitted this change and it was merged. Change subject: use blank storage pool when connecting the volumes ...................................................................... use blank storage pool when connecting the volumes We're not connected to a pool. To prepare an image when you're not connected to a pool (general HE use case) you should specify a blank pool uuid (00000000-0000-0000-0000-000000000000) Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129261 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Federico Simoncelli: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d7683b8dd10097344cb1d5fd036e549fc25ef8c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: upload stream fails due to explicit cast
by oourfali＠redhat.com 08 Sep '14

08 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: upload stream fails due to explicit cast ...................................................................... upload stream fails due to explicit cast Code assumes that we all the time use xmlrpc and explicitly casts it to VdsServerWrapper to get http client. When host uses jsonrpc it fails with class cast excpetion. This patch uses existing code to build http client and passes it to JsonRpcVdsServer implementation. getHttpClient method is promoted to IVdsServer interface so jsonrpc implementation can expose http client as well. Bug-Url: https://bugzilla.redhat.com/1138986 Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 20 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: need to consider Vlan when getting name from nic.
by lvernia＠redhat.com 08 Sep '14

08 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core: need to consider Vlan when getting name from nic. ...................................................................... core: need to consider Vlan when getting name from nic. Change-Id: Ie504a99aa31c279fc9b3304ca6a860c5d0cf7943 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie504a99aa31c279fc9b3304ca6a860c5d0cf7943 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fail when trying to remove labeled VLAN network.
by lvernia＠redhat.com 08 Sep '14

08 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core: fail when trying to remove labeled VLAN network. ...................................................................... core: fail when trying to remove labeled VLAN network. Vlan related nics cannot have labels, but when I have VLAN enabled non vm network added to nic via label, then this nic will have associated label, and vlan related nic will have associated network. So I have to remove Vlan related nic when updating via setupnetworks, to remove network. So I have to check base interface for label presence when removing network with vlan enabled via removing of vlan related nic. Also it seemed to me like a bug, that if isVlan(nic) is true, but it's base interface nic is present in setupnetworks request(ie. vlan related nic was deleted but base interface was not), vlan related nic is checked for label presence, although it's base resource should have been validated. Change-Id: I132f4ae124e45144beee21f81f69e55ed25cd540 Bug-Url: https://bugzilla.redhat.com/1134380 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I132f4ae124e45144beee21f81f69e55ed25cd540 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: upload stream fails due to explicit cast
by emesika＠redhat.com 08 Sep '14

08 Sep '14

Eli Mesika has submitted this change and it was merged. Change subject: upload stream fails due to explicit cast ...................................................................... upload stream fails due to explicit cast Code assumes that we all the time use xmlrpc and explicitly casts it to VdsServerWrapper to get http client. When host uses jsonrpc it fails with class cast excpetion. This patch uses existing code to build http client and passes it to JsonRpcVdsServer implementation. getHttpClient method is promoted to IVdsServer interface so jsonrpc implementation can expose http client as well. Bug-Url: https://bugzilla.redhat.com/1138986 Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 20 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c1dbb50727172647da10ec4b74f2950057c4bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Re-assign display/migration roles to mgmt network
by masayag＠redhat.com 08 Sep '14

08 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Re-assign display/migration roles to mgmt network ...................................................................... engine: Re-assign display/migration roles to mgmt network While we recently started marking the management network explicitly as display and migration by default, we did not take care of the scenario where the roles are assigned to another network which is then removed - in which case we're left with no explicit display/migration network, and only fall back to the management network implicitly. Now when a network holding the role is removed, it is re-assigned to the management network. Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java 4 files changed, 60 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0