- Engine-commits - oVirt List Archives

Change in otopi[master]: core: Alert if priorities were overridden
by Alon Bar-Lev 08 Sep '14

08 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: Alert if priorities were overridden ...................................................................... core: Alert if priorities were overridden During buildSequence, warn or optionally abort, if the final sequence has methods ordered in reverse to their priorities. This might happen if the priorities conflict with before/after. Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/otopi/context.py 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/29180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove unused field, diskSize, from VmStatic
by ofrenkel＠redhat.com 08 Sep '14

08 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove unused field, diskSize, from VmStatic ...................................................................... core: remove unused field, diskSize, from VmStatic Change-Id: Idb1c7894b1efd5f2cc3132a5f899689288be1ef7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 2 files changed, 0 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1c7894b1efd5f2cc3132a5f899689288be1ef7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix layout of 'MTU' field in Network dialog
by alkaplan＠redhat.com 08 Sep '14

08 Sep '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix layout of 'MTU' field in Network dialog ...................................................................... webadmin: Fix layout of 'MTU' field in Network dialog Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003 Bug-Url: https://bugzilla.redhat.com/1127587 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ExportVmTemplateCommand storage allocations
by amureini＠redhat.com 08 Sep '14

08 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVmTemplateCommand storage allocations ...................................................................... core: ExportVmTemplateCommand storage allocations MoveOrCopyTemplateCommand.canDoAction() small fix: Fixed storage domain space verification. Using StorageDomainValidator for some other storage verification, instead of (p)re-inventing the wheel. ExportVmTemplate inherits and therefore is affected by this. Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06 Bug-Url: https://bugzilla.redhat.com/1136717 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Adding 'DefaultMtu' to engine-config
by tnisan＠redhat.com 07 Sep '14

07 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Adding 'DefaultMtu' to engine-config ...................................................................... engine: Adding 'DefaultMtu' to engine-config Change-Id: Ie45576e4baa5f69ba3fd20ae9a0cad637b7e7b7d Bug-Url: https://bugzilla.redhat.com/1125175 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelper.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelperTest.java M packaging/etc/engine-config/engine-config.properties 3 files changed, 79 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie45576e4baa5f69ba3fd20ae9a0cad637b7e7b7d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: renaming 'DefaultMtu' config value to 'DefaultMTU'
by tnisan＠redhat.com 07 Sep '14

07 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: renaming 'DefaultMtu' config value to 'DefaultMTU' ...................................................................... core: renaming 'DefaultMtu' config value to 'DefaultMTU' Change-Id: Ic57d502a8894757cccbd87df3760ccac852a3ad9 Bug-Url: https://bugzilla.redhat.com/1125175 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/MtuRenderer.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 11 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic57d502a8894757cccbd87df3760ccac852a3ad9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Add separate validation for multicast MAC address
by tnisan＠redhat.com 07 Sep '14

07 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add separate validation for multicast MAC address ...................................................................... engine: Add separate validation for multicast MAC address Split MAC address format validation into two separate ones: 1. Valid MAC address 2. Unicast MAC address Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f Bug-Url: https://bugzilla.redhat.com/1118385 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit 526727ce47d578f958a6f58fdad461c9b55d4c10) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/MacAddressValidationPatterns.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 83 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: build: post ovirt-engine-dwh-3.5_rc2 respin
by ydary＠redhat.com 07 Sep '14

07 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5_rc2 respin ...................................................................... build: post ovirt-engine-dwh-3.5_rc2 respin Change-Id: I83c549bdeb7edd9bac6c838c8f63a32d457ab950 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c549bdeb7edd9bac6c838c8f63a32d457ab950 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.5_rc2 respin
by ydary＠redhat.com 07 Sep '14

07 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5_rc2 respin ...................................................................... build: ovirt-engine-dwh-3.5_rc2 respin Change-Id: I65cd098c6441564a395d01b289e9d12eaf677aa8 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65cd098c6441564a395d01b289e9d12eaf677aa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: build: post ovirt-engine-reports-3.5_rc respin
by ydary＠redhat.com 07 Sep '14

07 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5_rc respin ...................................................................... build: post ovirt-engine-reports-3.5_rc respin Change-Id: I51b4cd243647f4b032026d89f705dec3823fa04c Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51b4cd243647f4b032026d89f705dec3823fa04c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0