- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: select first element on changing list
by awels＠redhat.com 03 Sep '14

03 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: select first element on changing list ...................................................................... userportal,webadmin: select first element on changing list - When removing all elements except one, the code that tries to auto select kicked in and would select the first element of the old list giving an illusion of duplicates for a split second. This patch fixes this by not auto selecting the only element immediately, but deferring it until the operation has completed and the list has been updated. Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131881 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update vms on update of instance type
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: update vms on update of instance type ...................................................................... core: update vms on update of instance type when instance type values are updated, we need to update also all the vms that are using this instance type. also, added audit log for vm update that is done internaly (by system) otherwise log will show "user <unknown>" Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 26 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic229a677bdd61a7f522548d9abf68476fbe219e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Adjust network panel height to fit arrows
by lvernia＠redhat.com 03 Sep '14

03 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Adjust network panel height to fit arrows ...................................................................... webadmin: Adjust network panel height to fit arrows The network panels were a little short compared to the arrows in the Setup Networks dialog, which caused them to go out of alignment (more noticeable as more networks are attached to the same interface). Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Bug-Url: https://bugzilla.redhat.com/1120660 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png 3 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a74d41c71e7153169e077fb61813b916e5d7c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove remains of version 2.2 from FencingPolicyHelper
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove remains of version 2.2 from FencingPolicyHelper ...................................................................... core: Remove remains of version 2.2 from FencingPolicyHelper Removes unnecessary condtions from FencingPolicyHelper class which was needed when 2.2 was containt in Version.ALL list. Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba815fc8a35969917360fea1eccc646e679426b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove version 2.2 from Version and VersionStorageForm...
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove version 2.2 from Version and VersionStorageFormatUtil ...................................................................... core: Remove version 2.2 from Version and VersionStorageFormatUtil Remove last usage of version 2.2 from VersionStorageFormatUtil and Version classes. Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Martin Peřina: Verified Allon Mureinik: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id43f292215cf35c1e2834c2a2fdac6b08a3bdb2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove version 2.2 checks in DataCenterStorageListModel
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove version 2.2 checks in DataCenterStorageListModel ...................................................................... core: Remove version 2.2 checks in DataCenterStorageListModel Removes version 2.2 checks related to storage format type in DataCenterStorageListModel. Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida6c034172e797ab4460cd954958663e4d112c12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Use version 3.0 instead of 2.2 UpdateVmCommandTest ...................................................................... core: Use version 3.0 instead of 2.2 UpdateVmCommandTest Uses version 3.0 instead of 2.2 for minimal supported cluster level version in UpdateVmCommandTest. Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0 Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7caebd147a47e1874e3327ce99df4a2de25c51f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibi...
by oourfali＠redhat.com 03 Sep '14

03 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest ...................................................................... core: Use version 3.0 instead of 2.2 in GetCommandsCompatibilityVersionsQueryTest Uses version 3.0 instead of 2.2 for testing minimal compatibility version in GetCommandsCompatibilityVersionsQueryTest. Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d Bug-Url: https://bugzilla.redhat.com/1127590 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b0236bf3ca6360d3fa483df9f23e5a1fe37457d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fetch cpu profile id for vm object
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fetch cpu profile id for vm object ...................................................................... core: fetch cpu profile id for vm object This field is missing when getting vm from vms view. To be submitted only in 3.5 branch (since there was a refactoring made in vm dao mappers in u/s). Change-Id: Ifbff849008c5e339a6c761a86c5f134e0ad20523 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/32370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbff849008c5e339a6c761a86c5f134e0ad20523 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: use instance type values on update vm
by tnisan＠redhat.com 03 Sep '14

03 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: use instance type values on update vm ...................................................................... core: use instance type values on update vm When updating vm which is using instance-type, the instance-type values cannot be override by the user. this patch use the same code we have for add-vm that use instance-type, to override the correct values. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 3 files changed, 70 insertions(+), 33 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ed838af7052f744dccd015f90032fdfc18cc55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0