- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add some spacing to checkbox cell labels
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add some spacing to checkbox cell labels ...................................................................... webadmin: Add some spacing to checkbox cell labels Some regression occurred in 3.5 where labels in checkbox cells too close to the actual checkbox (presumably due to the Look & Feel patches). This adds some space between them. Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092 Bug-Url: https://bugzilla.redhat.com/1120984 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Control\view Soundcard property
by juan.hernandez＠redhat.com 01 Sep '14

01 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Control\view Soundcard property ...................................................................... restapi: Control\view Soundcard property * Added 'soundcard_enabled' property to REST VM/template/vmpool resource (accessible via 'All-Content' header) * Added support for property in: VM/Template/Instance - Add / Update Pool - Add * Updated rsdl * Updated tests Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460 Bug-Url: https://bugzilla.redhat.com/1021186 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 16 files changed, 172 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: notifier: send sysUpTime in snmp notifications.
by oourfali＠redhat.com 01 Sep '14

01 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: send sysUpTime in snmp notifications. ...................................................................... notifier: send sysUpTime in snmp notifications. Sysuptime is measured since the notification service was started. Time ticks represent a100th of a second. Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131175 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fix watchdog configuration for localized webadmin
by tjelinek＠redhat.com 01 Sep '14

01 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: Fix watchdog configuration for localized webadmin ...................................................................... Fix watchdog configuration for localized webadmin Watchdog settings for type and action were directly translating the possible values. That caused issues during saving as the selected enum value could not be detected due to localization. This updates the code to use the proper way of rendering localized enums. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135467 Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 8 files changed, 100 insertions(+), 96 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/32131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding '...' appender to text columns that overflow
by alkaplan＠redhat.com 01 Sep '14

01 Sep '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding '...' appender to text columns that overflow ...................................................................... webadmin: adding '...' appender to text columns that overflow Using TextOverflow.ELLIPSIS style property to achieve this. Change-Id: Ibabe4f05b92f0f448207fb08700b75afed645de7 Bug-Url: https://bugzilla.redhat.com/1122990 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibabe4f05b92f0f448207fb08700b75afed645de7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make all disk size setting in DiskModel type safe ...................................................................... webadmin: Make all disk size setting in DiskModel type safe Since the size entity in DiskModel is defined as an Integer entity model, all the places that set the new entity should be in Integer type to ensure type safety Change-Id: I2f22ca6865fc7927eb9777986b1844e3b8639141 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f22ca6865fc7927eb9777986b1844e3b8639141 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: New disk dialog does not validate the size value ...................................................................... webadmin: New disk dialog does not validate the size value The size field is defined as as an entity model of type long and so the integer validator does not validate it at all making it possible for numbers less than the minimum (including negative number and zero) as well as numbers higher than the maximum to appear as validated, this was fixed by replacing the entity model for size from type long to integer Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1115471 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 9 files changed, 14 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: SpmStopOnIrs - set result ...................................................................... core: SpmStopOnIrs - set result When executing SpmStopOnIrs we should set the return value to be as the return value of the command that's being executed, otherwise the caller can't tell what actually happend. Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Bug-Url: https://bugzilla.redhat.com/1119852 Bug-Url: https://bugzilla.redhat.com/1130222 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/32193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add logging to SpmStopVDSCommand ...................................................................... core: add logging to SpmStopVDSCommand currently SpmStopVdsCommand performs nothing in case of tasks return by the current spm, this patch just adds logging to that case. Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130766 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/32189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
by tnisan＠redhat.com 31 Aug '14

31 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status ...................................................................... webadmin: disable 'Remove' for OVF store not in ILLEGAL status Currently when OVF store isn't in ILLEGAL status it can't be removed, this patch greys out the remove button in the webadmin in that case. Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa Bug-Url: https://bugzilla.redhat.com/1131845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/32188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0