- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Resize ListModelTypeAheadListBox for consistency
by lvernia＠redhat.com 25 Aug '14

25 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Resize ListModelTypeAheadListBox for consistency ...................................................................... webadmin: Resize ListModelTypeAheadListBox for consistency Resized this widget to be consistent with other widgets. Change-Id: Ib2532daf8390a05f07203140ef8857d1207ba6dd Bug-Url: https://bugzilla.redhat.com/1127582 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2532daf8390a05f07203140ef8857d1207ba6dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fixing typo in RDP connection error dialog
by tjelinek＠redhat.com 25 Aug '14

25 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: Fixing typo in RDP connection error dialog ...................................................................... Fixing typo in RDP connection error dialog Change-Id: I1cbfcd0d334b5461b5bd9508d2085ac483e2b02f Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cbfcd0d334b5461b5bd9508d2085ac483e2b02f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: more coverity fixes
by yzaslavs＠redhat.com 24 Aug '14

24 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: more coverity fixes ...................................................................... aaa: more coverity fixes Topic: AAA Change-Id: Ie25bc66509d1e0986e7b92edc07537c869bd490c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java 3 files changed, 10 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie25bc66509d1e0986e7b92edc07537c869bd490c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: In disks tab/subtab, make the default view to All
by tnisan＠redhat.com 24 Aug '14

24 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: In disks tab/subtab, make the default view to All ...................................................................... webadmin: In disks tab/subtab, make the default view to All In the disks maintab/subtab we have 3 view options - All, Images, LUNs, the default was "Images" and now was changed to "All" Bug-Url: https://bugzilla.redhat.com/878962 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I4f97a8c39053eac961a79141071ee3471825f1df --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f97a8c39053eac961a79141071ee3471825f1df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add CRUD commands and queries for QoS objects (storage)
by tnisan＠redhat.com 24 Aug '14

24 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add CRUD commands and queries for QoS objects (storage) ...................................................................... core: Add CRUD commands and queries for QoS objects (storage) For more information see: http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support Change-Id: I1a9af59277b5055453159f002f19046c00522ddb Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllQosByStoragePoolIdAndTypeQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQosByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddStorageQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/QosCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveQosCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveStorageQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateQosCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateStorageQosCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/QosValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageQosValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QosParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/QosQueryParameterBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 22 files changed, 604 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c00522ddb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: db, core: aggregate qos and storage qos impl
by tnisan＠redhat.com 24 Aug '14

24 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: db, core: aggregate qos and storage qos impl ...................................................................... db, core: aggregate qos and storage qos impl - DB and DAL changes: create qos table to accomodate qos objects and include storage qos and its limits. - added qos_sp.sql to add default sp. For more information see: http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDaoFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/qos_sp.sql A packaging/dbscripts/upgrade/03_05_0940_add_qos_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 16 files changed, 439 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: common: introduce qos package, and storage qos
by tnisan＠redhat.com 24 Aug '14

24 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: common: introduce qos package, and storage qos ...................................................................... common: introduce qos package, and storage qos - Base Qos abstract class, in the future all QoS will inherit it. - QosType (version >= 3.3 network, version >= 3.5 disk, cpu), to distinguish between the types. - StorageQos object as the first implementation. - Handle field validation propeties. For more information see http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 377 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add disk device after disk is added
by tnisan＠redhat.com 24 Aug '14

24 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add disk device after disk is added ...................................................................... core: Add disk device after disk is added Currently, AddDiskCommand adds the device to the DB, before the disk is there, this cause the boot order not to take the new disk into consideration. In this patch the addition of the device is moved after the disk is created by the disk is in the db. Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131018 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: set default plugin for provider
by lvernia＠redhat.com 24 Aug '14

24 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: set default plugin for provider ...................................................................... webadmin: set default plugin for provider set default value of external network provider to 'Open vSwitch' set 'RabbitMQ' as default broker type of Agent config Bug-Url: https://bugzilla.redhat.com/1118253 Change-Id: I52abd0ea1a6a923374e6ab094ff2a81f145f443a Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52abd0ea1a6a923374e6ab094ff2a81f145f443a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add disk device after disk is added
by ofrenkel＠redhat.com 24 Aug '14

24 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Add disk device after disk is added ...................................................................... core: Add disk device after disk is added Currently, AddDiskCommand adds the device to the DB, before the disk is there, this cause the boot order not to take the new disk into consideration. In this patch the addition of the device is moved after the disk is created by the disk is in the db. Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131018 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Omer Frenkel: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f2fc8e6771ed2b352f2bde7b4e313481df76b90 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0