- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix coverity defect CID 1230277
by lvernia＠redhat.com 14 Aug '14

14 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix coverity defect CID 1230277 ...................................................................... webadmin: Fix coverity defect CID 1230277 Not sure why the executeCommand() overload with parameters was overridden here as no command in the dialog accepts parameters. Simplified the code a bit, which should also please Coverity. Change-Id: Ie9fb33a37dd76a27fbc6948018d1ec2a6f495239 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9fb33a37dd76a27fbc6948018d1ec2a6f495239 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProcessOvfUpdate - skip vms/templates without ovf
by laravot＠redhat.com 14 Aug '14

14 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: ProcessOvfUpdate - skip vms/templates without ovf ...................................................................... core: ProcessOvfUpdate - skip vms/templates without ovf When ovf hasn't been generated yet for a vm/template, avoid trying to add it's ovf to the created tar. Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Bug-Url: https://bugzilla.redhat.com/1129258 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4de180c59e7e82b380bfc12f5d72f9b7c2a4f468 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: maxVCpus revised
by tnisan＠redhat.com 14 Aug '14

14 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: maxVCpus revised ...................................................................... core: maxVCpus revised we need to make sure must be result of cores * socket otherwise the VM will fail to load by libvirt for: c = 12 // cores maxSocket = 16 //config maxVCpu = 160 // config maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156 prior to this fix vdsm would end up with <vcpu current=12>160</vcpu> <topology cores=12 socket=13 thread=1> and 160 couldn't be fulfilled by cores * socket, 156 Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Bug-Url: https://bugzilla.redhat.com/1126797 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: missing vms link under affinity groups
by oourfali＠redhat.com 14 Aug '14

14 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: missing vms link under affinity groups ...................................................................... restapi: missing vms link under affinity groups Change-Id: Ia913bee64669db435be49463821ae68fe61978be Bug-Url: https://bugzilla.redhat.com/1128461 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit b8feb5728bf72b50df230af5915c3c1544ccb3ab) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupsResource.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia913bee64669db435be49463821ae68fe61978be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: maxVCpus revised
by ofrenkel＠redhat.com 14 Aug '14

14 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: maxVCpus revised ...................................................................... core: maxVCpus revised we need to make sure must be result of cores * socket otherwise the VM will fail to load by libvirt for: c = 12 // cores maxSocket = 16 //config maxVCpu = 160 // config maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156 prior to this fix vdsm would end up with <vcpu current=12>160</vcpu> <topology cores=12 socket=13 thread=1> and 160 couldn't be fulfilled by cores * socket, 156 Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Bug-Url: https://bugzilla.redhat.com/1070890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: collect /etc/rhevm
by sbonazzo＠redhat.com 14 Aug '14

14 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: collect /etc/rhevm ...................................................................... sos: collect /etc/rhevm Due to a bug in sos /etc/rhevm was not collected. This patch introduces a workaround by collecting its content. Change-Id: Iebee3f58a987921e7919a42810659f57cc96cae9 Bug-Url: https://bugzilla.redhat.com/1129698 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f1ec62cd69e355d6acd1bcd47bbfa70b318a460c) (cherry picked from commit fb987b490fc693c035a643e64c24d305de333984) --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebee3f58a987921e7919a42810659f57cc96cae9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update support of ppc cpus
by tnisan＠redhat.com 14 Aug '14

14 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: update support of ppc cpus ...................................................................... core: update support of ppc cpus Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129631 Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Roy Golan: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/31462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75ea7ce447853f653cc45044cbf8ede64c0a8bb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: Require bzip2
by tnisan＠redhat.com 14 Aug '14

14 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: spec: Require bzip2 ...................................................................... packaging: spec: Require bzip2 engine-backup needs bzip2. Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Bug-Url: https://bugzilla.redhat.com/1129671 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: Require bzip2
by oourfali＠redhat.com 14 Aug '14

14 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: spec: Require bzip2 ...................................................................... packaging: spec: Require bzip2 engine-backup needs bzip2. Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Bug-Url: https://bugzilla.redhat.com/1129671 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c20ef5393b20336cfe38c2405a000a8b58e8c62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Default to 'No' on cleanup questions
by sbonazzo＠redhat.com 14 Aug '14

14 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Default to 'No' on cleanup questions ...................................................................... packaging: setup: Default to 'No' on cleanup questions Align with the generic group questions. Change-Id: Ied98a782f75d08da0addd67920748d78140d3e9b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied98a782f75d08da0addd67920748d78140d3e9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0