- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Unplugging state of hot mem unplug button
by Code Review 21 Apr '17

21 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Unplugging state of hot mem unplug button ...................................................................... webadmin: Unplugging state of hot mem unplug button When memory hot unplug action is confirmed the "Hot unplug" button is disabled and relabeled to "Unplugging ..." for 15 seconds. This informs user that the action is in progress and prevents him from re-invoking it. "Hot unplug" button is disabled if corresponding VM is not in state 'UP' or if memory hot unplug is disabled by ConfigValues#HotUnplugMemorySupported. * New entity VmDeviceFeEntity introduced to be able to hold frontend specific state of VmDevice - #isBeingUnplugged. It inherits from VmDevice. * VmDevicesListModel and related classes use VmDeviceFeEntity instead of VmDevice. * backend part: VmDevice has copy constructor and inheritance friendly toString() method. Change-Id: I78a0eba2dd80a01f2f5f695b4ea1034b2b9e40b4 Bug-Url: https://bugzilla.redhat.com/1228543 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/utils/ExpiringSet.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDeviceFeEntity.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDevicesListModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineVmDevicePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineVmDevicesView.java 17 files changed, 288 insertions(+), 76 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a0eba2dd80a01f2f5f695b4ea1034b2b9e40b4 Gerrit-PatchSet: 61 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add generic writer
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add generic writer ...................................................................... Add generic writer Currently the SDK doesn't have any mechanism to generate an XML document from an object whose type isn't known. This patch adds a new 'Writer.write' method that decides what is the specific writer to use based on the type of the object, so that the caller doesn't need to explicitly select it. Change-Id: I42d697b840a7b4ee2a197e881678e389f7cab919 Bug-Url: https://bugzilla.redhat.com/1444114 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e868377781ba2940aea026b9b1d6ca9fc3f215af) --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/ext/ov_xml_writer.c M sdk/lib/ovirtsdk4/writer.py M sdk/tests/test_writer.py 4 files changed, 274 insertions(+), 20 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42d697b840a7b4ee2a197e881678e389f7cab919 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add generic writer
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add generic writer ...................................................................... Add generic writer Currently the SDK doesn't have any mechanism to generate an XML document from an object whose type isn't known. This patch adds a new 'Writer.write' method that decides what is the specific writer to use based on the type of the object, so that the caller doesn't need to explicitly select it. Change-Id: I42d697b840a7b4ee2a197e881678e389f7cab919 Bug-Url: https://bugzilla.redhat.com/1444114 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/ext/ov_xml_writer.c M sdk/lib/ovirtsdk4/writer.py M sdk/tests/test_writer.py 4 files changed, 274 insertions(+), 20 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42d697b840a7b4ee2a197e881678e389f7cab919 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Add pin VM example
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add pin VM example ...................................................................... Add pin VM example This patch adds an example that shows how to modify the placement policy of a virtual machine so that it will always run in an specific host. Change-Id: Iedaec61abd96ca20683ba91d20662fb62bffcf44 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6678935a9c678205f8f0092eefa73eecca5c061f) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/PinVm.java 1 file changed, 70 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedaec61abd96ca20683ba91d20662fb62bffcf44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add pin VM example
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add pin VM example ...................................................................... Add pin VM example This patch adds an example that shows how to modify the placement policy of a virtual machine so that it will always run in an specific host. Change-Id: If4332d3539868d9ed113b382d15a5417ee288ef8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d2d886f9d41466a5c608e3370575eb2814f1d163) --- A sdk/examples/pin_vm.py 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4332d3539868d9ed113b382d15a5417ee288ef8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add pin VM example
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add pin VM example ...................................................................... Add pin VM example This patch adds an example that shows how to modify the placement policy of a virtual machine so that it will always run in an specific host. Change-Id: If4332d3539868d9ed113b382d15a5417ee288ef8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/pin_vm.py 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4332d3539868d9ed113b382d15a5417ee288ef8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add pin VM example
by Code Review 21 Apr '17

21 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add pin VM example ...................................................................... Add pin VM example This patch adds an example that shows how to modify the placement policy of a virtual machine so that it will always run in an specific host. Change-Id: Iedaec61abd96ca20683ba91d20662fb62bffcf44 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/PinVm.java 1 file changed, 70 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedaec61abd96ca20683ba91d20662fb62bffcf44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: pm: Wait for host to boot when executing start operation
by Code Review 21 Apr '17

21 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: pm: Wait for host to boot when executing start operation ...................................................................... pm: Wait for host to boot when executing start operation Previously when start fence action was executed we didn't wait for the host to boot. This may cause an issue when the host take too long to boot, so the host monitoring code will be re-executing the fence operation and the host will never boot. This patch handle the issue, so we now wait ServerRebootTimeout, after the 'start' operation is executed and after this timeout the host status is changed properly. Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Bug-Url: https://bugzilla.redhat.com/1423657 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StartVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: don't fail when listing vm session of non-existing ...
by Code Review 21 Apr '17

21 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: restapi: don't fail when listing vm session of non-existing user ...................................................................... restapi: don't fail when listing vm session of non-existing user When VM console sessions are listed and the there is session for user which don't exist in oVirt database, we should not fail and return 404, but we should just don't fetch additional data about this user. Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473 Bug-Url: https://bugzilla.redhat.com/1440861 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java 5 files changed, 41 insertions(+), 45 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Check content type only when really needed
by Code Review 21 Apr '17

21 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Check content type only when really needed ...................................................................... Check content type only when really needed Currently the SDK checks the content type of all responses, even of responses where the content type doesn't need to be provided. For example, when a 404 error code is generated by the application server, or by the web server, the content type may not be present, or may be HTML. In these situations the SDK is not reacting correctly, as the message that explains that the content type isn't correct is hiding other more important messages, like the HTTP result code. To avoid that this patch changes the SDK so that it will check the content type only when it really tries to parse the response body. In addition, the patch also changes the generated messages, so that the HTTP details, including the HTTP error code, will appear in the message in all cases. Change-Id: I0a41409f985c82452447dcc9f99445338a253b4f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 16b4932438f8974b9622ea04119bb5cc0bd05068) --- M sdk/lib/ovirtsdk4/connection.rb M sdk/lib/ovirtsdk4/service.rb M sdk/spec/service_spec.rb M sdk/spec/vm_service_spec.rb 4 files changed, 152 insertions(+), 75 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a41409f985c82452447dcc9f99445338a253b4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0