- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Re-extract validation to parent command.
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Re-extract validation to parent command. ...................................................................... core: Re-extract validation to parent command. Re-extract the same validation logic from ImportVm and ImportVmTemplate configuration, to be used in one method at MoveOrCopyTemplateCommand. Change-Id: Ic25f6f086fe3a8a55de33529a6fb92728d3e0d74 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 3 files changed, 27 insertions(+), 41 deletions(-) Approvals: Maor Lipchuk: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25f6f086fe3a8a55de33529a6fb92728d3e0d74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Support MSD when importing a VM from configuration
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support MSD when importing a VM from configuration ...................................................................... core: Support MSD when importing a VM from configuration Using validation for active storage domain on all the Storage Domains which the images are based on. Also adding support for unregistered Template/VM with disks on MSD. Change-Id: I067b6186c2a2b7d77394e9cb0a4e8f023c168e4b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M packaging/dbscripts/unregistered_OVF_data_sp.sql 6 files changed, 60 insertions(+), 32 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I067b6186c2a2b7d77394e9cb0a4e8f023c168e4b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use validation on entites related to one SD.
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use validation on entites related to one SD. ...................................................................... core: Use validation on entites related to one SD. Remove all the entities which are related to multiple Storage Domains from the list of Vms/Templates which we validate. VM/Template with multiple disks on different Storage Domain will not be deleted from the engine but instead will be kept in the engine without the disks related to it. Change-Id: I9bc46616a164e6d6ec87fbd4ac67f84823bec4de Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 18 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc46616a164e6d6ec87fbd4ac67f84823bec4de Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Force remove should not delete VMs/Tempaltes with MSD.
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Force remove should not delete VMs/Tempaltes with MSD. ...................................................................... core:Force remove should not delete VMs/Tempaltes with MSD. When the admin chooses to force destroy a storage domain, the operation should remove all the entities related to the Data Storage Domain. Since version 3.1 we have added the ability for VMs to have disks on multiple storage domains. Today, when using force reomve on Storage Domain, we also remove VMs/Templates with disks on multiple storage domains, those disks on the other data storage domains are left as floating disks in the system, even though they might contain snapshots of the deleted VM/Template. This patch fix this behaviour by leaving the VMs/Templates with disks on MSD, when using force remove. It also deletes the devices which are related to those VMs/Templates, since until now those devices were deleted also with the VM/Template. Change-Id: Ic222ee55a711ea9101bf20ac812219714f70aab3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1108242 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/storages_sp.sql 1 file changed, 43 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic222ee55a711ea9101bf20ac812219714f70aab3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove business logic of MSD validation for detach
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove business logic of MSD validation for detach ...................................................................... core: Remove business logic of MSD validation for detach Remove message and validation for entities with disks on multiple storage domains, since this should be valid now. Change-Id: Ieb0115e4c8fb22f61c69f2cdd0c92c06adb2bcd5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 58 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb0115e4c8fb22f61c69f2cdd0c92c06adb2bcd5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Add validation for Vm memory hard limits
by oourfali＠redhat.com 12 Jun '14

12 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add validation for Vm memory hard limits ...................................................................... core: Add validation for Vm memory hard limits The vdc options VM64BitMaxMemorySizeInMB and VM64BitMaxMemorySizeInMB were not checked at all, only the os-info were used to issue a warning. Now we check those against the appropriate cluster version at the VM run. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1104774 Change-Id: I46c22acc77867abc79cd54ef6113ab2da005fd94 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 62 insertions(+), 1 deletion(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46c22acc77867abc79cd54ef6113ab2da005fd94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Support creation of Vms with 4000GB of memory
by oourfali＠redhat.com 12 Jun '14

12 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Support creation of Vms with 4000GB of memory ...................................................................... core: Support creation of Vms with 4000GB of memory Change-Id: I13a40b21db18e98c02d11fe7ff158a299cd7bc1c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1104774 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13a40b21db18e98c02d11fe7ff158a299cd7bc1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: api: Fixing RSDL issue
by juan.hernandez＠redhat.com 12 Jun '14

12 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: api: Fixing RSDL issue ...................................................................... api: Fixing RSDL issue Master was broken and gluster's RSDL was returned also in "virt only" and "all" modes. This patch fixes the issues Change-Id: I03f836e0784ce3a1b86fd7fc410acf07f4d5c8e1 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/SessionProcessor.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/28628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03f836e0784ce3a1b86fd7fc410acf07f4d5c8e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: fklsnr: Introduce standalone fence_kdump listener
by oourfali＠redhat.com 12 Jun '14

12 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: fklsnr: Introduce standalone fence_kdump listener ...................................................................... fklsnr: Introduce standalone fence_kdump listener Introduces standalone fence_kdump listener. Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36 Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in A packaging/etc/ovirt-fence-kdump-listener.conf.d/README.in A packaging/services/ovirt-fence-kdump-listener/__init__.py A packaging/services/ovirt-fence-kdump-listener/config.py.in A packaging/services/ovirt-fence-kdump-listener/db.py A packaging/services/ovirt-fence-kdump-listener/listener.py A packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.conf.in A packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py A packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.systemd.in A packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.sysv.in 12 files changed, 924 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec3bad47bbba860a52a9ff4e2eb7f61277f4e36 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add VdsKdumpStatus entity
by oourfali＠redhat.com 12 Jun '14

12 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add VdsKdumpStatus entity ...................................................................... core: Add VdsKdumpStatus entity 1) Creates vds_kdump_status table 2) Adds stored procedure to access vds_kdump_status table 3) Adds DAO to access the entity Change-Id: I58696ddefa8602b1daa5f55ab4dc11bdc565e265 Bug-Url: https://bugzilla.redhat.com/1079821 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/KdumpFlowStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsKdumpStatus.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsKdumpStatusDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsKdumpStatusDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsKdumpStatusDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_0650_add_vds_kdump_status.sql A packaging/dbscripts/vds_kdump_status_sp.sql 10 files changed, 538 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58696ddefa8602b1daa5f55ab4dc11bdc565e265 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0