- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: pm: Wait for host to boot when executing start operation
by Code Review 20 Apr '17

20 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: pm: Wait for host to boot when executing start operation ...................................................................... pm: Wait for host to boot when executing start operation Previously when start fence action was executed we didn't wait for the host to boot. This may cause an issue when the host take too long to boot, so the host monitoring code will be re-executing the fence operation and the host will never boot. This patch handle the issue, so we now wait ServerRebootTimeout, after the 'start' operation is executed and after this timeout the host status is changed properly. Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Bug-Url: https://bugzilla.redhat.com/1423657 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StartVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin:Filter out duplicate LUN id exposed through multipl...
by Code Review 20 Apr '17

20 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin:Filter out duplicate LUN id exposed through multiple targets. ...................................................................... webadmin:Filter out duplicate LUN id exposed through multiple targets. Connecting the same LUN through multiple targets using the GUI sends the same LUN id multiple times for each target. Duplicate LUN ids should be filtered out before the engine calls createVG. Change-Id: I696bfdb660f3361d47427c610cda53c6c0942d11 Bug-Url: https://bugzilla.redhat.com/1441706 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/75596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I696bfdb660f3361d47427c610cda53c6c0942d11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: deps: gdeploy: changed copr repository
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: deps: gdeploy: changed copr repository ...................................................................... deps: gdeploy: changed copr repository Ramesh left Red Hat and will not be maintaining his repository any longer. Sac is the main developer of Gdeploy and is working on getting the package in Fedora before it can get included in the CentOS Storage SIG. Until the packages are in the repositories from the distributions, the COPR at https://copr.fedorainfracloud.org/coprs/sac/gdeploy/ contains the latest builds. Change-Id: I07f08892b3f3ffa7f9719e99993c2a7b199ac81f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-ppc64le-deps.repo.in M ovirt-el7-x86_64-deps.repo.in M ovirt-f25-deps.repo.in 3 files changed, 12 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Niels de Vos: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07f08892b3f3ffa7f9719e99993c2a7b199ac81f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Niels de Vos <ndevos(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: added new reports: free mem, overridden compatibility_version
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: added new reports: free mem, overridden compatibility_version ...................................................................... added new reports: free mem, overridden compatibility_version • every hosts will report vds.mem_available • if there is at least one VM, which has different vds_group_compatibility_version/cluster_compatibility_version than one defined in related vds_group/cluster record, new section "VMs with overridden cluster compatibility version" will be added to report, reporting all such networks Change-Id: I01e1929b42904b98ba905cd5eb3d9d0c0e8a28f6 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport.sh 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01e1929b42904b98ba905cd5eb3d9d0c0e8a28f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Publishers: standard publisher- Added support to export find...
by Code Review 20 Apr '17

20 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Publishers: standard publisher- Added support to export findbugs.xml ...................................................................... Publishers: standard publisher- Added support to export findbugs.xml Instead of having separated job for findbugs, this will integrate the plugin with all of the std ci jobs. Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-536 Change-Id: Ie24ad7d533e2c037fb569cf8172061107c24703f Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/yaml/publishers/standard.yaml 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/75459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie24ad7d533e2c037fb569cf8172061107c24703f Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: vdsm: fix config decorator
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix config decorator ...................................................................... vdsm: fix config decorator With patch https://gerrit.ovirt.org/53531 a OVIRT_VINTAGE_NODE specific condition has been introduced but it wasn't effective since the old decorator was still in place. With patch https://gerrit.ovirt.org/71599 the initial decorator has been removed but now it raises an issue with AIO plugin for oVirt Live. Restoring the initial decorator. Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Bug-Url: https://bugzilla.redhat.com/1443064 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/config.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: aaa: User can no longer use API having password with special...
by Code Review 19 Apr '17

19 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: User can no longer use API having password with special character "+" ...................................................................... aaa: User can no longer use API having password with special character "+" The request parameters are automatically decoded to UTF-8 format when content type and encoding are specified in the request. It is not necessary to decode them on the SSO end again. Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4 Bug-Url: https://bugzilla.redhat.com/1443645 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 2 files changed, 5 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: drop 4.0 publisher
by Code Review 19 Apr '17

19 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: publisher: drop 4.0 publisher ...................................................................... publisher: drop 4.0 publisher 4.0 has gone EOL long ago, no further development is planned for 4.0 branches. Removing the publisher as first step toward removing all 4.0 jobs. Change-Id: I5359419c9757ef7a0b3c11d03c4521abe67f379c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 2 files changed, 0 insertions(+), 178 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5359419c9757ef7a0b3c11d03c4521abe67f379c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: fix config decorator
by Code Review 19 Apr '17

19 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix config decorator ...................................................................... vdsm: fix config decorator With patch https://gerrit.ovirt.org/53531 a OVIRT_VINTAGE_NODE specific condition has been introduced but it wasn't effective since the old decorator was still in place. With patch https://gerrit.ovirt.org/71599 the initial decorator has been removed but now it raises an issue with AIO plugin for oVirt Live. Restoring the initial decorator. Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Bug-Url: https://bugzilla.redhat.com/1443064 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/config.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: running create_functions.sql upon setup
by Code Review 19 Apr '17

19 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: running create_functions.sql upon setup ...................................................................... core: running create_functions.sql upon setup This patch fix an issue when only create_functions.sql was modified (for example adding a new function) In the case that this is the only change, the engine-setup will not recognize the change and the new function will not be created. The fix adds the create_functions.sql file to the list of files of which we have a MD5 sum that is used to track changes in thoise files. Change-Id: I60222b1fb61e2ef76788774cd59d096d4a1b4a31 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1432095 Signed-off-by: emesika <emesika(a)redhat.com> (cherry picked from commit b5a819de8216b2d226cf370ecd83914303584956) --- M packaging/dbscripts/dbfunc-common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60222b1fb61e2ef76788774cd59d096d4a1b4a31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0