- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Block change to old cluster if network properties set
by lvernia＠redhat.com 30 Apr '14

30 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Block change to old cluster if network properties set ...................................................................... engine: Block change to old cluster if network properties set Since we currently don't update VDSM upon cluster change in a host, there is no way to wipe existing network custom properties on a host's interfaces when moving to a cluster that doesn't support network custom properties, and the operation should be blocked. Change-Id: I16622d0374bde7ab2e440d81d82e830ad8d81949 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16622d0374bde7ab2e440d81d82e830ad8d81949 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Consider custom properties in Setup Networks
by lvernia＠redhat.com 30 Apr '14

30 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Consider custom properties in Setup Networks ...................................................................... engine: Consider custom properties in Setup Networks Added code to validate network custom properties as part of the Setup Networks command, to mark networks as modified if their custom properties have changed, and to serialize them for VDSM. Persistence of the custom properties of a network is performed right before sending the VDSM command; the alternative is to persist the data when collecting network data after the VDSM command has finished running, but at the moment VDSM doesn't report custom properties. Change-Id: Ic607fb6073f2c4c0a4790763d9a09dc7879f11ca Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 185 insertions(+), 5 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic607fb6073f2c4c0a4790763d9a09dc7879f11ca Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: packaging: Include python unit test files
by vfeenstr＠redhat.com 30 Apr '14

30 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: packaging: Include python unit test files ...................................................................... packaging: Include python unit test files Change-Id: I65b246a05192d5898e2e122b8c90cf1a7160b50b Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M tests/Makefile.am 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b246a05192d5898e2e122b8c90cf1a7160b50b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: agent: Report Windows fake cached/buffers memory entries
by vfeenstr＠redhat.com 30 Apr '14

30 Apr '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: Report Windows fake cached/buffers memory entries ...................................................................... agent: Report Windows fake cached/buffers memory entries To unifiy the OS report structure this has to be reported for Windows as well. Change-Id: Id71a250084aa6a5efc9583f757accdde772128be Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Amador Pahim: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id71a250084aa6a5efc9583f757accdde772128be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsNetworkInterface to support empty properties map
by lvernia＠redhat.com 30 Apr '14

30 Apr '14

Lior Vernia has submitted this change and it was merged. Change subject: core: VdsNetworkInterface to support empty properties map ...................................................................... core: VdsNetworkInterface to support empty properties map Instead of implicitly assuming that custom properties are either null or a meaningful collection, a method is added to check whether meaningful properties exist, and the DAO is updated as well to not trash the DB with empty collections. Change-Id: Ie1cad7133800b4b8c2b7eb7e8be0be80a1e5cb9b Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cad7133800b4b8c2b7eb7e8be0be80a1e5cb9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: declare constant member as static
by derez＠redhat.com 30 Apr '14

30 Apr '14

Daniel Erez has submitted this change and it was merged. Change subject: core: declare constant member as static ...................................................................... core: declare constant member as static GetAllDiskSnapshotsByStorageDomainIdQueryTest -> snapshotDescription: member should be static. Change-Id: I7a301dd037496f56e9251709c0efb1e00d7dab2d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDiskSnapshotsByStorageDomainIdQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/27223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a301dd037496f56e9251709c0efb1e00d7dab2d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter.DAY_IN_MILLIS
by amureini＠redhat.com 30 Apr '14

30 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseConditionFieldAutoCompleter.DAY_IN_MILLIS ...................................................................... core: BaseConditionFieldAutoCompleter.DAY_IN_MILLIS Removed unused constant. Change-Id: Id24dd250b4649d3338a584dde5ddc376a5bb7ea6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/27211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id24dd250b4649d3338a584dde5ddc376a5bb7ea6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: RestoraAllSnapshotsCommand suppressions
by amureini＠redhat.com 30 Apr '14

30 Apr '14

Allon Mureinik has submitted this change and it was merged. Change subject: findbugs: RestoraAllSnapshotsCommand suppressions ...................................................................... findbugs: RestoraAllSnapshotsCommand suppressions Removed suppression for SF warnings for RestoreAllSnapshotsCommand. This issue was fixed in commit d354933191a171b8f06d07938fbd6fae5674af93, and there is no longer a need to continue suppressing it. Change-Id: Iac65c2d550b2607fad959d22aa830641927c9302 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/27212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac65c2d550b2607fad959d22aa830641927c9302 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove unused imports
by alkaplan＠redhat.com 30 Apr '14

30 Apr '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove unused imports ...................................................................... engine: remove unused imports Change-Id: Id2c7dc0e2143acc947ebcc2e61658c3088dc3955 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2c7dc0e2143acc947ebcc2e61658c3088dc3955 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Replace the call to deprecated UpdateDispla...
by masayag＠redhat.com 30 Apr '14

30 Apr '14

Moti Asayag has submitted this change and it was merged. Change subject: engine,webadmin: Replace the call to deprecated UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one ...................................................................... engine,webadmin: Replace the call to deprecated UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one 1. Replace call to UpdateDisplayToVdsGroup command with UpdateNetworkOnCluster one in ClusterNetworkListModel.setDisplay() method. 2. Remove deprecated UpdateDisplayToVdsGroup and the related command class as those aren't in use anymore. Change-Id: I9f103f0db10a06b0b2689298d3bfa505f4615577 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateDisplayToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java 4 files changed, 7 insertions(+), 75 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/26505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f103f0db10a06b0b2689298d3bfa505f4615577 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0