- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Block adding of mixed domain to a pool if not supp...
by oourfali＠redhat.com 29 Apr '14

29 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Block adding of mixed domain to a pool if not supported by version ...................................................................... webadmin: Block adding of mixed domain to a pool if not supported by version When adding a new storage domain via webadmin where the compatibility version does not support mixed storage types we might encounter a situation where the domain is created and the attach to the data center is failing and the setup is left with an unattached domain, to prevent that we now disallow addition from a storage type (block/file) to a data center that does not support mixed types and already have attached domains of another storage type (e.g. adding an iSCSI storage domain to a v3.3 data center V3.3 with an NFS domain attached will be prohibited) Change-Id: Ib31884e6fd5a7868e9bb21c9566bcd2e445de52a Bug-Url: https://bugzilla.redhat.com/1085395 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java 3 files changed, 74 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31884e6fd5a7868e9bb21c9566bcd2e445de52a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added GetAllDiskSnapshotsByStorageDomainIdQuery
by derez＠redhat.com 28 Apr '14

28 Apr '14

Daniel Erez has submitted this change and it was merged. Change subject: core: added GetAllDiskSnapshotsByStorageDomainIdQuery ...................................................................... core: added GetAllDiskSnapshotsByStorageDomainIdQuery Added GetAllDiskSnapshotsByStorageDomainIdQuery for fetching all volumes (non-active) according to a specific storage domain. Change-Id: I389579e4120cb33edca594caa762a8bad63362b7 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDiskSnapshotsByStorageDomainIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDiskSnapshotsByStorageDomainIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 173 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I389579e4120cb33edca594caa762a8bad63362b7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: spiceProxyOverrideEnabled label overlapped in spanish
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: spiceProxyOverrideEnabled label overlapped in spanish ...................................................................... webadmin: spiceProxyOverrideEnabled label overlapped in spanish Fixed by setting the label big enough so the translated text fits in Change-Id: I1e02bd278e79d2571eb99b7dab70bab1c775bc81 Bug-Url: https://bugzilla.redhat.com/1088868 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e02bd278e79d2571eb99b7dab70bab1c775bc81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Set Sysprep domain to editable field
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set Sysprep domain to editable field ...................................................................... core: Set Sysprep domain to editable field Currently we have a close list of domains (which is set via engine-manage-domains tool) Change-Id: I0370e63593035e80851852dca40a480fdccf46fa Bug-Url: https://bugzilla.redhat.com/1072414 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 12 files changed, 81 insertions(+), 118 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/26678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0370e63593035e80851852dca40a480fdccf46fa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Forget HTTP session after invalidate
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Forget HTTP session after invalidate ...................................................................... restapi: Forget HTTP session after invalidate Currently when the RESTAPI receives a request that contains a valid session identifier, but that doesn't require persistent authentication we invalidate the session. This is correct, but we also try to use that invalidated session later, which generates exceptions. To avoid that this patch makes sure that when the session is invalidated the variable that references it is also set to null. Change-Id: I88dcd37f80eb1fa85aa0441c3cbdfed18e84d5f3 Bug-Url: https://bugzilla.redhat.com/1091371 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 638ec287b306c04ffbac7ba6122364d5b015e4ae) --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88dcd37f80eb1fa85aa0441c3cbdfed18e84d5f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Added a query to fetch storage types in a storage pool
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Added a query to fetch storage types in a storage pool ...................................................................... core: Added a query to fetch storage types in a storage pool Added a query that fetches all the storage types of the data storage domains contained in a certain pool Change-Id: I97447e0fc3e087958101156947bded12c1fb9418 Bug-Url: https://bugzilla.redhat.com/1085395 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageTypesInPoolByPoolIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M packaging/dbscripts/storages_sp.sql 6 files changed, 101 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97447e0fc3e087958101156947bded12c1fb9418 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: dal: Added a mixed storage pool to fixtures.xml
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: dal: Added a mixed storage pool to fixtures.xml ...................................................................... dal: Added a mixed storage pool to fixtures.xml Added a mixed storage pool to fixtures.xml file to allow dao tests to test cases of mixed storage pools also Change-Id: I285c420902ce8d28cb7e8bfcc2ad3a11c225c0fb Bug-Url: https://bugzilla.redhat.com/1085395 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkQosDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNicDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 6 files changed, 82 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I285c420902ce8d28cb7e8bfcc2ad3a11c225c0fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Replaced the check of whether a storage pool contains ...
by oourfali＠redhat.com 28 Apr '14

28 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Replaced the check of whether a storage pool contains mixed type ...................................................................... core: Replaced the check of whether a storage pool contains mixed type Replaced the check of whether a storage pool contains storage domains of mixed types to use a designated query that fetches distinct storage types instead of fetching all the storage domains and filtering by that, in that way we are fetching less data and eliminating the use for logic in engine to determine if the domain is mixed thus resulting in better performance Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd Bug-Url: https://bugzilla.redhat.com/1083560 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86cf1512655865831de3cbd16c10a7bc243f08cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: don't die when trying to convert None to float
by msivak＠redhat.com 28 Apr '14

28 Apr '14

Martin Sivák has submitted this change and it was merged. Change subject: don't die when trying to convert None to float ...................................................................... don't die when trying to convert None to float Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1091360 Change-Id: I1c0e5906a2708d546dcb5c8e1d68e07294edaa69 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/27071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0e5906a2708d546dcb5c8e1d68e07294edaa69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix issue with GetStorageDomainByNameQuery
by emesika＠redhat.com 28 Apr '14

28 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix issue with GetStorageDomainByNameQuery ...................................................................... core: Fix issue with GetStorageDomainByNameQuery Commit 88756e3897ba467eb50055a7dda0c1afb11295d0 introduced function GetStorageDomainByNameQuery which faults at vm export. This patch fixes this issue. Change-Id: Ifae06739c658a1f602421081590790b11bba5806 Bug-Url: https://bugzilla.redhat.com/1087028 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/27088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae06739c658a1f602421081590790b11bba5806 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0