- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "aaa: Introducing attach_user_to_su_role"
by yzaslavs＠redhat.com 07 Apr '14

07 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "aaa: Introducing attach_user_to_su_role" ...................................................................... Revert "aaa: Introducing attach_user_to_su_role" Topic: AAA This reverts commit 10bcb8e08cd9f8b6bd944d79cbe34047d9be0c6f. Change-Id: I3aa24e6781fb0efcd539a44a0adf2aefb897c3d3 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java M ovirt-engine.spec.in D packaging/bin/ovirt-engine-role.sh M packaging/dbscripts/common_sp.sql 4 files changed, 28 insertions(+), 128 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aa24e6781fb0efcd539a44a0adf2aefb897c3d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Introducing attach_user_to_su_role
by yzaslavs＠redhat.com 07 Apr '14

07 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Introducing attach_user_to_su_role ...................................................................... aaa: Introducing attach_user_to_su_role 1. Introducing a function to attach role for user on system object 2. Removed attach_user_to_su_role 3. Moved generation of permission id to DB (changed manage domains code) 4. Introduced ovirt-engine-role.sh script to add role to authz user. Change-Id: I7c6e25aa5f187ae06bd105f5493acacda355730a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java M ovirt-engine.spec.in A packaging/bin/ovirt-engine-role.sh M packaging/dbscripts/common_sp.sql 4 files changed, 128 insertions(+), 28 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6e25aa5f187ae06bd105f5493acacda355730a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: Add executePipe
by Alon Bar-Lev 07 Apr '14

07 Apr '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: Add executePipe ...................................................................... core: Add executePipe Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Related-To: https://bugzilla.redhat.com/1059286 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/__init__.py M src/otopi/plugin.py 3 files changed, 424 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 22 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: core: expose preexec_fn at command execution
by Alon Bar-Lev 07 Apr '14

07 Apr '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: expose preexec_fn at command execution ...................................................................... core: expose preexec_fn at command execution Change-Id: I807b8bb6b09e7c16ad767a33f54b1e4a2f1f6eed Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/plugin.py 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I807b8bb6b09e7c16ad767a33f54b1e4a2f1f6eed Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: rename _eventNotificationTypeMap eventNotificationT...
by oourfali＠redhat.com 07 Apr '14

07 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: rename _eventNotificationTypeMap eventNotificationTypeMap. ...................................................................... backend: rename _eventNotificationTypeMap eventNotificationTypeMap. Change-Id: I81460dd81dfa7f49336b1c53d5531c0b46129417 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81460dd81dfa7f49336b1c53d5531c0b46129417 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: syntactic change in AddEventNotificationEntry.
by oourfali＠redhat.com 07 Apr '14

07 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: backend: syntactic change in AddEventNotificationEntry. ...................................................................... backend: syntactic change in AddEventNotificationEntry. This change should have no behavioural effect. Change-Id: Ibec58bf005801c99b5afb061705379e8b5378251 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibec58bf005801c99b5afb061705379e8b5378251 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine : Changing cluster during oVirtNode approve throws un...
by oourfali＠redhat.com 07 Apr '14

07 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Changing cluster during oVirtNode approve throws unsupported CPU exception ...................................................................... engine : Changing cluster during oVirtNode approve throws unsupported CPU exception Changing oVirt node cluster during approve host causes failure with error "Host CPU type is not supported in this cluster compatibility version or is not supported at all" Change-Id: I6f485ce0512ae9c35be5b3f803b7ca1c35dea4f9 Bug-Url: https://bugzilla.redhat.com/1079834 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f485ce0512ae9c35be5b3f803b7ca1c35dea4f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: ovirt-node reinstall/approve should use root user
by gchaplik＠redhat.com 07 Apr '14

07 Apr '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: ovirt-node reinstall/approve should use root user ...................................................................... webadmin: ovirt-node reinstall/approve should use root user While admin is local node user that should not be used remotely when upgrading or reinstalling oVirt Node. Change-Id: Ia85bf1cfb96513f22629d9cb8fb3028c4446b5d2 Bug-Url: https://bugzilla.redhat.com/1080976 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia85bf1cfb96513f22629d9cb8fb3028c4446b5d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: prevent session fixation
by awels＠redhat.com 07 Apr '14

07 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: prevent session fixation ...................................................................... userportal, webadmin: prevent session fixation - This patch creates a new session when a user attempts to log in. This is to prevent session fixation attacks. Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df427683c924f10cb59f4af1dd067fcfd21a8f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools : engine-config is over writing the previous values
by emesika＠redhat.com 07 Apr '14

07 Apr '14

Eli Mesika has submitted this change and it was merged. Change subject: tools : engine-config is over writing the previous values ...................................................................... tools : engine-config is over writing the previous values 'engine-config -s' is over writing the existing values with the new ones from command line. A new option to merge the new values provided with the values in the database has been added. 'engine-config -m' or 'engine-config --merge' This concatenates the new value with the exisiting value in the database. Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Bug-Url: https://bugzilla.redhat.com/1069768 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 83 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Yair Zaslavsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0