- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: docs other languages
by awels＠redhat.com 03 Apr '14

03 Apr '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: docs other languages ...................................................................... engine: docs other languages - If you try to load a manual document in a locale that doesn't exist, you will get a 404 instead of a warning message that the language is not available. - Fixed issue in the path of the link that would forward you to the english documentation. - Fixed issue in the cookie path that would store if you had been shown the warning message yet. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083528 Change-Id: Iaa26e9a95eff3aa117517ec53d3d97c8ac5ba703 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/DocsServlet.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa26e9a95eff3aa117517ec53d3d97c8ac5ba703 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: NFS config on update change
by sbonazzo＠redhat.com 03 Apr '14

03 Apr '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: NFS config on update change ...................................................................... packaging: setup: NFS config on update change Allow user to override the new behavior of not re-configuring NFS while upgrading. User may now override the default behavior by setting otopi environment variable: OVESETUP_SYSTEM/nfsConfigEnabled Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Related-To: http://gerrit.ovirt.org/26043 Bug-Url: https://bugzilla.redhat.com/1056777 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 2 files changed, 15 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fb4a9eb4af5e811a1fa1a63b8c11126b01ae56c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Static IP is set as none bootproto for cloud-init
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Static IP is set as none bootproto for cloud-init ...................................................................... core: Static IP is set as none bootproto for cloud-init 1. Setting the bootproto for static if not dhcp (was set as none) 2. Adding display name for NetworkBootProtocol enum 3. Fix CloudInitHandler for sending nulls for ip and subnet on dhcp bootproto. Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Bug-Url: https://bugzilla.redhat.com/1036013 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkBootProtocol.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 3 files changed, 21 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53159a6ead92d890f7abe2ec78196bb967994a5f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Sysprep - Add user specify Active Directory OU
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Sysprep - Add user specify Active Directory OU ...................................................................... core: Sysprep - Add user specify Active Directory OU Change-Id: Ibb63316e8505affd5d78edd90881b2c7cd83e05f Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k3 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w7 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8 M packaging/conf/sysprep/sysprep.w8x64 M packaging/conf/sysprep/sysprep.xp A packaging/dbscripts/upgrade/03_05_0200_vm_init_add_active_directory_ou.sql M packaging/dbscripts/vms_sp.sql 21 files changed, 81 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb63316e8505affd5d78edd90881b2c7cd83e05f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable user defined Windows Sysprep file
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Enable user defined Windows Sysprep file ...................................................................... core: Enable user defined Windows Sysprep file Change-Id: I7d257f70784a11f2e1e678d5fc4cd13bb4337a76 Bug-Url: https://bugzilla.redhat.com/1080002 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 5 files changed, 54 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d257f70784a11f2e1e678d5fc4cd13bb4337a76 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable log-in for a regular user via cloud-init
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Enable log-in for a regular user via cloud-init ...................................................................... core: Enable log-in for a regular user via cloud-init Cloud-Init oVirt currently support only root user. This patch add the ability to select any user name or use the default username (by leaving the field blank) or using the root user (by setting the user name as root) Change-Id: Iebfe44ec68e8bcfae5087504bf5cd29b29aad49b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java A packaging/dbscripts/upgrade/03_05_0190_vm_init_add_user_name.sql M packaging/dbscripts/vms_sp.sql 12 files changed, 70 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebfe44ec68e8bcfae5087504bf5cd29b29aad49b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: RFE: set locale language and keyboard via Sysprep
by shavivi＠redhat.com 03 Apr '14

03 Apr '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: RFE: set locale language and keyboard via Sysprep ...................................................................... engine: RFE: set locale language and keyboard via Sysprep We want to add ability for the user to specify the language layout via Windows Sysprep, added 4 new fields that represented the following Sysprep data: <InputLocale>en-US</InputLocale> <UILanguage>en-US</UILanguage> <SystemLocale>en-US</SystemLocale> <UserLocale>en-US</UserLocale> Change-Id: I414c1d097a7cf8e23b322ca0f23dcb9d66ac0691 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromCloudInitVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w7 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8 M packaging/conf/sysprep/sysprep.w8x64 A packaging/dbscripts/upgrade/03_05_0180_vm_init_add_sysprep_locale.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vms_sp.sql 29 files changed, 365 insertions(+), 157 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I414c1d097a7cf8e23b322ca0f23dcb9d66ac0691 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Proper VM SystemTab Validation
by tjelinek＠redhat.com 03 Apr '14

03 Apr '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Proper VM SystemTab Validation ...................................................................... frontend: Proper VM SystemTab Validation UnitVmModel#validate() used async query to get max valid mem size and thus caused race with submiting the Vm dialog so the memory was not validated at all. Added missing validation for whole SystemTab. Removed unused AsyncDataProvider methods to get various memory-limit related ConfigValues and corresponding (also unused) UnitVmModel fields. Added support for TB memory size in MemorySizeParser and disabled parsing of garbled input '12a30 MB' as longest valid prefix ('12 MB'). Removed ByteSizeValidation since it didn't validate anything. It validated only String entities and the memory size is an EntityModel<Integer>. All validation is performed in validateMemorySize in conjuction with MemorySizeParser. Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069628 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/parser/MemorySizeParser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ByteSizeValidation.java 5 files changed, 51 insertions(+), 198 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/26268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: rerun HA VMs on manual fence using AutoStartVmsRunner
by oourfali＠redhat.com 03 Apr '14

03 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: rerun HA VMs on manual fence using AutoStartVmsRunner ...................................................................... core: rerun HA VMs on manual fence using AutoStartVmsRunner Same as 1269b60ae6ab8caf42bc2fb5ff06c0403b0b7562 but for manual fence. Change-Id: Ia40853abb8b985da93ab1c43146ec5d227c8cf88 Bug-Url: https://bugzilla.redhat.com/1080961 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia40853abb8b985da93ab1c43146ec5d227c8cf88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: make ClearNonResponsiveVdsVms non-transactive
by oourfali＠redhat.com 03 Apr '14

03 Apr '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: make ClearNonResponsiveVdsVms non-transactive ...................................................................... core: make ClearNonResponsiveVdsVms non-transactive ClearNonResponsiveVdsVmsCommand basically do the following things: 1. Change all the VMs that ran on the host to DOWN 2. Update the VDS attributes as if no VM is running on the host 3. Run HA VMs that ran on the host Since this command used to be transactive, the DOWN state on the VMs was not committed at stage #3. The RunVmCommands triggered in stage #3 still worked because we were doing the canDoAction checks in the same transaction (in the multiple action runner). If on the other hand we were just executing the command one-by-one it would not work because RunVmCommand is non-transactive so in the canDoAction checks we were thinking the VMs are in UNKNOWN state - and this is wrong. There is no real reason for this command to be transactive since after the user confirmed that the host has been booted, we assume the VMs are DOWN anyway so the right thing to do is changed their status to DOWN. The only problematic case of changing the status of the VMs outside of a transaction scope will be if the host was powered off and we didn't reach stage #3 (run the HA VMs) after doing stage #1 (this is very unlikely to happen though) - The VMs will be DOWN and their runningOnVds field will be blank so VURTI won't try to rerun them when the host will go up. The good side is that the user will be able to run them manually if the host is not going to restart (as opposed to keep them in UNKNOWN state). So for a conclusion: this patch is not ideal, it solved an issue and creates another minor issue which is very not likely to happen, and should probably be fixed by another mechanism that will rerun HA VMs which are DOWN because of an error and AutoStartVmsRunner didn't try to rerun. Change-Id: Ia8728e56f21ff6dcf6e103b1d450eecfaa36e809 Bug-Url: https://bugzilla.redhat.com/1080961 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java 1 file changed, 10 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8728e56f21ff6dcf6e103b1d450eecfaa36e809 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0