- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fail deletion of template/template disk with derived d...
by laravot＠redhat.com 09 Mar '14

09 Mar '14

Liron Ar has submitted this change and it was merged. Change subject: core: fail deletion of template/template disk with derived disks ...................................................................... core: fail deletion of template/template disk with derived disks *When a template disk has derived disks on the selected domain for deletion, the deletion should fail with a proper message. *When deleting a template with derived disks, the deletion should fail with proper message. Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9 Bug-Url: https://bugzilla.redhat.com/953492 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 100 insertions(+), 2 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: adding missing exclude-filters.xml
by yzaslavs＠redhat.com 09 Mar '14

09 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: adding missing exclude-filters.xml ...................................................................... adding missing exclude-filters.xml adding missing exclude-filter.xml and fixing pom.xml to point to exclude-filters general Change-Id: Ifdacdcb11ecb50b98377e6b273f36d8baf6fe38e Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/exclude-filters.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdacdcb11ecb50b98377e6b273f36d8baf6fe38e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Introducing extensions module
by yzaslavs＠redhat.com 09 Mar '14

09 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Introducing extensions module ...................................................................... aaa: Introducing extensions module This module will hold all the relevant API needed to develop extensions. Currently it holds the Extension interface Topic: AAA Change-Id: If373ef883588fdf363f5800fa8fc74c7836838cd Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/ovirt/engine/api/ovirt-engine-extensions-api/main/module.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/internal/InternalDirectory.java M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml R backend/manager/modules/aaa/src/main/resources/META-INF/services/org.ovirt.engine.api.extensions.Extension M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalDirectory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java R backend/manager/modules/bll/src/main/resources/META-INF/services/org.ovirt.engine.api.extensions.Extension M backend/manager/modules/extension-manager/pom.xml M backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java M backend/manager/modules/extension-manager/src/main/modules/org/ovirt/engine/core/extension-manager/main/module.xml A backend/manager/modules/extensions-api-root/extensions-api/pom.xml R backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Extension.java A backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M ovirt-engine.spec.in M pom.xml 23 files changed, 134 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If373ef883588fdf363f5800fa8fc74c7836838cd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Display network must have boot protocol
by masayag＠redhat.com 08 Mar '14

08 Mar '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Display network must have boot protocol ...................................................................... engine: Display network must have boot protocol The scheduler should not select a host which the display network is configured on without a proper settings for IP address (i.e. only DHCP or Static boot protocol are allowed). Change-Id: I14e5a0edae8524a7334609e58934880a722ca87f Bug-Url: https://bugzilla.redhat.com/955429 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 104 insertions(+), 78 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e5a0edae8524a7334609e58934880a722ca87f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve setup networks failure message
by masayag＠redhat.com 08 Mar '14

08 Mar '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve setup networks failure message ...................................................................... engine: Improve setup networks failure message Change-Id: Id25f864970df7e7f420f760fa8e8c78c1104d64e Bug-Url: https://bugzilla.redhat.com/ Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 14 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25f864970df7e7f420f760fa8e8c78c1104d64e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve cannot label bond message
by masayag＠redhat.com 08 Mar '14

08 Mar '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve cannot label bond message ...................................................................... engine: Improve cannot label bond message Change-Id: I250c56d0f6a70dbe8da89a3aa5b28592f9a0a995 Bug-Url: https://bugzilla.redhat.com/1054187 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 12 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I250c56d0f6a70dbe8da89a3aa5b28592f9a0a995 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix findbugs warning
by mlipchuk＠redhat.com 08 Mar '14

08 Mar '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fix findbugs warning ...................................................................... core: fix findbugs warning Remove unused snapshot parameter and method Change-Id: Ic67cf42c652972a34580d613bbf0da5ed204c7f3 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/25525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic67cf42c652972a34580d613bbf0da5ed204c7f3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, engine, webadmin: Retrieve Capabilities for each Archi...
by rgolan＠redhat.com 08 Mar '14

08 Mar '14

Roy Golan has submitted this change and it was merged. Change subject: core, engine, webadmin: Retrieve Capabilities for each Architecture ...................................................................... core, engine, webadmin: Retrieve Capabilities for each Architecture This change introduces code to determine if a certain processor architecture supports live migration, memory snapshots or suspension. This is used in changes #21522, #21523, #21657, #21658, #21643, #21644, #24015 and #24016 to block unsupported features in the ppc64 architecture. Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057178 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ArchCapabilitiesParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 306 insertions(+), 1 deletion(-) Approvals: Vitor de Lima: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: root: Add maven-eclipse-plugin generated stuff to .gitignore
by vszocs＠redhat.com 07 Mar '14

07 Mar '14

Vojtech Szocs has submitted this change and it was merged. Change subject: root: Add maven-eclipse-plugin generated stuff to .gitignore ...................................................................... root: Add maven-eclipse-plugin generated stuff to .gitignore Using recent version of maven-eclipse-plugin (root pom.xml doesn't specify <version> for this plugin!), I've ended up having some extra generated stuff that should be ignored by git. Seems like .externalToolBuilders + maven-eclipse.xml are generated due to <resource> declarations in pom.xml files, i.e. maven-eclipse-plugin adds custom Ant builder for Eclipse IDE for purpose of Maven <resource> processing. Change-Id: I8863bafd25b5dc5dc45378939b7e54adc727ce74 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8863bafd25b5dc5dc45378939b7e54adc727ce74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: locale in jsps not used
by awels＠redhat.com 07 Mar '14

07 Mar '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: locale in jsps not used ...................................................................... engine: locale in jsps not used - Fixed issue where the user selected locale was not being used in the translated messages on the page for non branded messages. Change-Id: Ief357cf989325402d84efe9d786584373566b0fc Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief357cf989325402d84efe9d786584373566b0fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0