- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core, ui: fix broken update template
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core, ui: fix broken update template ...................................................................... core, ui: fix broken update template Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: I302eb7754d2abe6a3073cd44885c82809a868178 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Omer Frenkel: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I302eb7754d2abe6a3073cd44885c82809a868178 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Missing storage options in data center "Guide me"
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Missing storage options in data center "Guide me" ...................................................................... webadmin: Missing storage options in data center "Guide me" In data center model, when clicking the "Add More Storage" options lacked some storage types that exists in the new storage dialog under storage tab this patch fixes that Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Bug-Url: https://bugzilla.redhat.com/1065970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 3 files changed, 60 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add ISO domain option in data center "Guide me" is...
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add ISO domain option in data center "Guide me" is missing ...................................................................... webadmin: Add ISO domain option in data center "Guide me" is missing A bug in the guide me model caused the add ISO domain option in the data center guide me to be only visible in case there is no ISO domain in the whole setup, this is wrong since the user should be able to add a new ISO to a data center regardless to whether another ISO already exists in the system Change-Id: I76c61f65e6cf7dbdaf631e2c9b7663f9dfffd16a Bug-Url: https://bugzilla.redhat.com/1070152 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 23 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c61f65e6cf7dbdaf631e2c9b7663f9dfffd16a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core, restapi: Missing domain field on VM\Template object
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core, restapi: Missing domain field on VM\Template object ...................................................................... core, restapi: Missing domain field on VM\Template object BE is not returning VmInit for the collection of VM and Templates (since it use the search query). Added a GetVmsInitQuery to set the VmInit for Templates and VMs collections. Bug-Url: https://bugzilla.redhat.com/1069201 Change-Id: Icf43cb1a0d25d89ef68f21bc47b82c2cd6fdf19d Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsInitQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M packaging/dbscripts/vms_sp.sql 13 files changed, 174 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Michal Skrivanek: Verified -- To view, visit http://gerrit.ovirt.org/25181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf43cb1a0d25d89ef68f21bc47b82c2cd6fdf19d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, ui: fix broken update template
by ofrenkel＠redhat.com 27 Feb '14

27 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, ui: fix broken update template ...................................................................... core, ui: fix broken update template Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: I302eb7754d2abe6a3073cd44885c82809a868178 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I302eb7754d2abe6a3073cd44885c82809a868178 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, restapi: Missing domain field on VM\Template object
by shavivi＠redhat.com 27 Feb '14

27 Feb '14

Shahar Havivi has submitted this change and it was merged. Change subject: core, restapi: Missing domain field on VM\Template object ...................................................................... core, restapi: Missing domain field on VM\Template object BE is not returning VmInit for the collection of VM and Templates (since it use the search query). Added a GetVmsInitQuery to set the VmInit for Templates and VMs collections. Bug-Url: https://bugzilla.redhat.com/1069201 Change-Id: Icf43cb1a0d25d89ef68f21bc47b82c2cd6fdf19d Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsInitQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmInitDAODbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M packaging/dbscripts/vms_sp.sql 13 files changed, 175 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf43cb1a0d25d89ef68f21bc47b82c2cd6fdf19d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core : VMs do not appear in virtual machine tab if host is s...
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core : VMs do not appear in virtual machine tab if host is selected in side pane ...................................................................... core : VMs do not appear in virtual machine tab if host is selected in side pane Vms do not appear in 'virtual machine' main tab if host is selected in webadmin side pane. screen shows empty (0 item) despite there are large number of vms running on the host. Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Bug-Url: https://bugzilla.redhat.com/1069898 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/25081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Extending SAN storage caused an NPE for a storage deta...
by iheim＠redhat.com 27 Feb '14

27 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Extending SAN storage caused an NPE for a storage detached from a pool ...................................................................... core: Extending SAN storage caused an NPE for a storage detached from a pool Extending a SAN storage domain that is detached from a storage pool caused an NPE due to a bug in the CDA part which caused the CDA evaluation to continue even though the status validation failed Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Bug-Url: https://bugzilla.redhat.com/1061121 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f6687bfe8390142519c2d641badc79fe6a1e0db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: setting destination cluster when importing glance ...
by oourfali＠redhat.com 27 Feb '14

27 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: setting destination cluster when importing glance templates ...................................................................... webadmin: setting destination cluster when importing glance templates When importing glance templates it is useful to allow selecting a cluster for this template. This patch adds this functionality Change-Id: I828590dae0b68b9bb3da9fc136084c9673cd4c8d Bug-Url: https://bugzilla.redhat.com/1070394 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportRepoImageParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ExportRepoImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.ui.xml 8 files changed, 131 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828590dae0b68b9bb3da9fc136084c9673cd4c8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Missing storage options in data center "Guide me"
by tnisan＠redhat.com 27 Feb '14

27 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Missing storage options in data center "Guide me" ...................................................................... webadmin: Missing storage options in data center "Guide me" In data center model, when clicking the "Add More Storage" options lacked some storage types that exists in the new storage dialog under storage tab this patch fixes that Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Bug-Url: https://bugzilla.redhat.com/1065970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 3 files changed, 60 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0