- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: findbugs possible null pointer dereference
by rgolan＠redhat.com 16 Feb '14

16 Feb '14

Roy Golan has submitted this change and it was merged. Change subject: engine: findbugs possible null pointer dereference ...................................................................... engine: findbugs possible null pointer dereference fix from commit d46ebd8712f369b924e199b82197e59568a686ff Change-Id: Icb9829514f49cb7f371b31acc018112beda477fb Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb9829514f49cb7f371b31acc018112beda477fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Change ListModel items from Iterable to Collection
by tnisan＠redhat.com 16 Feb '14

16 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Change ListModel items from Iterable to Collection ...................................................................... frontend: Change ListModel items from Iterable to Collection Due to a legacy the items in ListModel was of type Iterable which is a very limited type, since all of the multiple entity results from the backend come as either a List or a Set, it is safe to change the type to be a Collection and have the extra functionality from this type Change-Id: I69fcf4a6340aa74e8fa048d2a1f68bfc8eb99b24 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RolePermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TimeZoneModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 42 files changed, 100 insertions(+), 61 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69fcf4a6340aa74e8fa048d2a1f68bfc8eb99b24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Unite broken lines in AppErrors.properties
by iheim＠redhat.com 16 Feb '14

16 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Unite broken lines in AppErrors.properties ...................................................................... webadmin: Unite broken lines in AppErrors.properties The entry for LABELED_NETWORK_ATTACHED_TO_WRONG_INTERFACE is split into two lines. Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f Bug-Url: https://bugzilla.redhat.com/1065713 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: History: Fixed ad_domain datatype
by ydary＠redhat.com 16 Feb '14

16 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: History: Fixed ad_domain datatype ...................................................................... History: Fixed ad_domain datatype Made a mistake in configuring the datatype in views to preserve the views legacy. This fixes the issue. Change-Id: I49708d50e29e04a11e343c8f69508301dfe67254 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_views_3_0.sql M packaging/dbscripts/create_views_3_1.sql M packaging/dbscripts/create_views_3_2.sql M packaging/dbscripts/create_views_3_3.sql 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49708d50e29e04a11e343c8f69508301dfe67254 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: moved release number up
by ydary＠redhat.com 16 Feb '14

16 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: moved release number up ...................................................................... packaging: moved release number up Change-Id: Ia97e46cd3cc75ea9d662e972067b7d021cb41f89 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia97e46cd3cc75ea9d662e972067b7d021cb41f89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix event message when removing a LUN disk
by iheim＠redhat.com 16 Feb '14

16 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix event message when removing a LUN disk ...................................................................... core: Fix event message when removing a LUN disk When removing a disk, the event message included the domain name parameter in case the disk is a LUN disk there is no storage domain and the message appeared incorrectly, added a new type of event message for LUN disks that displays the same message without the storage domain parameter Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-url: https://bugzilla.redhat.com/910733 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 10 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Permissions of group are not inherited when adding a user
by iheim＠redhat.com 16 Feb '14

16 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Permissions of group are not inherited when adding a user ...................................................................... core: Permissions of group are not inherited when adding a user When adding a user, the group_ids column at the users table is not modified, so all the related stored procedures that calculate the permissions do not calculate the correct set of permissions. Bug-Url: https://bugzilla.redhat.com/1065615 Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove redundant classes from uioverrides
by tnisan＠redhat.com 16 Feb '14

16 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove redundant classes from uioverrides ...................................................................... frontend: Remove redundant classes from uioverrides Change-Id: I2f3f4cebe5cad4d0c038225ddfe8b2a9b2b38878 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/lang/InterruptedException.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/lang/Thread.java 2 files changed, 0 insertions(+), 74 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f3f4cebe5cad4d0c038225ddfe8b2a9b2b38878 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix admin@internal permissions
by emesika＠redhat.com 16 Feb '14

16 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix admin@internal permissions ...................................................................... core: Fix admin@internal permissions Fix permissions for admin@internal user by setting last_admin_check_status to true. The same is done in AddPermissionCommand if admin role is assigned to user. Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43 Bug-Url: https://bugzilla.redhat.com/1057087 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0630_fix_admin_internal_permissions.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Unite broken lines in AppErrors.properties
by masayag＠redhat.com 16 Feb '14

16 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Unite broken lines in AppErrors.properties ...................................................................... webadmin: Unite broken lines in AppErrors.properties The entry for LABELED_NETWORK_ATTACHED_TO_WRONG_INTERFACE is split into two lines. Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f Bug-Url: https://bugzilla.redhat.com/1065713 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d140e1dbe20e7945bc04b85cd9010441c643f6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0