- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Utilize Builders in VmListModels
by tjelinek＠redhat.com 28 Jan '14

28 Jan '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Utilize Builders in VmListModels ...................................................................... frontend: Utilize Builders in VmListModels * Refactoring of duplicate and very error-prone mapping of VM/Template fields in UserPortalListModel, TemplateListModel, PoolListModel, VmListModel and VmSnapshotListModel. * Utilizing the Builder infrastructure with minor additions the mappings were extractend into encapsulated builder classes either of type UnitVmModel -> VmBase or VmBase -> VmBase (depending on whether we are mapping properties from UnitVmModel or an existing VM) * These builders form a composition hierarchy at root of which sits the CoreUnitToVmBuilder. When adding new VmBase fields one should strive to add the appropriate mapping to only one place - that is to to most general builder. In most cases this will precisely be the root CoreUnitToVmBuilder. This builder is also used in PoolListModel, so if it is not desirable to map this new field for pool VMs yout need to add it to one some builder that is composed of CoreUnitToVmBuilder. Most notable examples are: - CommonUnitToVmBaseBuilder - FullUnitToVmBaseBuilder where Common contains mappings to be performed in onNewTemplate methods and Full contains Common + all remainging mappings used in onSave *ListModel methods. * General principle is that there should be at most one reference to a Vm setter in UiCommonWeb and the mapping from model to entity should be encapsulated in an appropriate builder. (If there is more complex logic to that mapping a separate simple builder derived from BaseSyncBuilder encapsulating that logic would be appropriate). Change-Id: I7cbd0f8c79ae13dd368a7542262397168c363f57 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/CompositeBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/DedicatedVmForVdsUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/DedicatedVmForVdsVmBaseToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/FullUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/KernelParamsUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/KernelParamsVmBaseToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationOptionsUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationOptionsVmBaseToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NameUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/QuotaUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/UsbPolicyUnitToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/UsbPolicyVmBaseToVmBaseBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/VmSpecificUnitToVmBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/pools/BaseVmListModelTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModelTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModelTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModelTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModelTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModelTest.java 27 files changed, 844 insertions(+), 415 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/23474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cbd0f8c79ae13dd368a7542262397168c363f57 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: build: fix routines version
by ydary＠redhat.com 28 Jan '14

28 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: build: fix routines version ...................................................................... packaging: build: fix routines version Broke at 525316a1bec Change-Id: I547d926d874e6abf49e9f3fb864ac0bac44aa27e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-dwh/advancedPersistentLookupLib/pom.xml M ovirt-engine-dwh/dependencies/pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I547d926d874e6abf49e9f3fb864ac0bac44aa27e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: put uninstall files in own group
by ydary＠redhat.com 28 Jan '14

28 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: put uninstall files in own group ...................................................................... packaging: setup: put uninstall files in own group Change-Id: I8a06ca7eb902f0bed9c145d5633985018350d088 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py 4 files changed, 32 insertions(+), 9 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a06ca7eb902f0bed9c145d5633985018350d088 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: set jasper database within master configur...
by ydary＠redhat.com 28 Jan '14

28 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: set jasper database within master configuration ...................................................................... packaging: setup: set jasper database within master configuration Change-Id: I99c6712f51c46bd015b17ac10069e13ac3e33676 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/jasper-master.properties.in M packaging/legacy-setup/ovirt-engine-reports-setup.py 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c6712f51c46bd015b17ac10069e13ac3e33676 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: rename authentication.properties->sso.prop...
by ydary＠redhat.com 28 Jan '14

28 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rename authentication.properties->sso.properties ...................................................................... packaging: setup: rename authentication.properties->sso.properties better name for our mini sso. Change-Id: Ia481911dcd2111dad054ca3bad8b1eef996ff695 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/jasper-customizations/WEB-INF/applicationContext-ovirt-override.xml.in M packaging/legacy-setup/ovirt-engine-reports-setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia481911dcd2111dad054ca3bad8b1eef996ff695 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in jasperreports-server-rpm[master]: Inhibit writing into /usr
by ydary＠redhat.com 28 Jan '14

28 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: Inhibit writing into /usr ...................................................................... Inhibit writing into /usr Change-Id: I51ef687a72840cd1f56aa551695a99b6eff20318 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A jasperreports-server-5.5.0-write-own.patch M jasperreports-server.spec 2 files changed, 42 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51ef687a72840cd1f56aa551695a99b6eff20318 Gerrit-PatchSet: 1 Gerrit-Project: jasperreports-server-rpm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: typo Datbase -> Database
by iheim＠redhat.com 28 Jan '14

28 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: typo Datbase -> Database ...................................................................... packaging: setup: typo Datbase -> Database Change-Id: I29ba0ec6e7472ded8bd1151b2e5c96fd85568fb6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29ba0ec6e7472ded8bd1151b2e5c96fd85568fb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Preserve labels when setup networks is sent
by iheim＠redhat.com 28 Jan '14

28 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Preserve labels when setup networks is sent ...................................................................... restapi: Preserve labels when setup networks is sent The setup networks api doesn't use the patch mechanism to preserve any interface's properties that wasn't sent by the user. Instead, it creates a new interface entity and set only the provided nic attributes. Since labels are maintained as a sub-collection on the nic entity, it should not be deleted for each setup networks request. This logic cannot reside on the engine side, since there will be no distinction between setup networks sent by the UI, in which the labels can be provided or removed, to the rest in which labels cannot be provided and should be preserved. Change-Id: Ic2b728a4797d03d6718e6c9b0b6adec6dcf3bbff Bug-Url: https://bugzilla.redhat.com/1055441 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/23524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2b728a4797d03d6718e6c9b0b6adec6dcf3bbff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Prepare for next release
by juan.hernandez＠redhat.com 28 Jan '14

28 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next release ...................................................................... sdk: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: I49be75a5da6a464e0aa9a8764e4e5750bceed43c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49be75a5da6a464e0aa9a8764e4e5750bceed43c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Release 3.4.0.3
by juan.hernandez＠redhat.com 28 Jan '14

28 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.4.0.3 ...................................................................... sdk: Release 3.4.0.3 Change-Id: Ie27e751117d63f22a808899a3707b0de094e7bd8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in M setup.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie27e751117d63f22a808899a3707b0de094e7bd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0