- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin : Fixed rendering issue in DetailsRenderer
by kmayilsa＠redhat.com 16 Jan '14

16 Jan '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fixed rendering issue in DetailsRenderer ...................................................................... webadmin : Fixed rendering issue in DetailsRenderer Fixed rendering issue in DetailsRenderer Change-Id: I49662e7e367889516d0667f27b801927bd0a1357 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49662e7e367889516d0667f27b801927bd0a1357 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add Reboot VM action button
by ofrenkel＠redhat.com 16 Jan '14

16 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: Add Reboot VM action button ...................................................................... webadmin: Add Reboot VM action button Added new button for Reboot VM to webadmin and userportal. This command should be enabled only when the GuestAgent is present because that is currently the only supported means of reboot in VDSM. Change-Id: I4a30dad6f2d3b909457e39ac15510f0468c2b1a1 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResources.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/BorderedCompositeCell.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/Reboot-24X24.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/actions/Reboot-disabled-24X24.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/Reboot-13X13.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/Reboot-disabled-13X13.png 19 files changed, 264 insertions(+), 124 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a30dad6f2d3b909457e39ac15510f0468c2b1a1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: osinfo: move sysprep defaults out of /etc
by sbonazzo＠redhat.com 16 Jan '14

16 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: osinfo: move sysprep defaults out of /etc ...................................................................... packaging: osinfo: move sysprep defaults out of /etc when moved to using conf.d structure, there is no reason why storing sysprep files in /etc as user can install his own osinfo config and overwrite product defaults reference with his own. this simplifies pushing product changes without the rpmsave/rpmnew hell and enables support to understand site customization. upgrade is comparing current install sysprep files and keep these that are different from product default at existing location, creating osinfo configuration for these. the move to osinfo neglected the ability of user to specify different setting for sysprep in database, we also fix that. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1043206 Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in M packaging/conf/osinfo-defaults.properties R packaging/conf/sysprep/sysprep.2k12x64 R packaging/conf/sysprep/sysprep.2k3 R packaging/conf/sysprep/sysprep.2k8 R packaging/conf/sysprep/sysprep.2k8x64 R packaging/conf/sysprep/sysprep.w7 R packaging/conf/sysprep/sysprep.w7x64 R packaging/conf/sysprep/sysprep.w8 R packaging/conf/sysprep/sysprep.w8x64 R packaging/conf/sysprep/sysprep.xp M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py 15 files changed, 223 insertions(+), 82 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: rewrite
by ydary＠redhat.com 16 Jan '14

16 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rewrite ...................................................................... packaging: setup: rewrite missing is checking the MinimalETLVersion during setup, it is not really required as setup is merged now, and it is easy to add this in future if required. read-only user creation is removed, it is not part of setup, we can provide a script to do so. Change-Id: Ic3cceaac390d5d373d2d1f5e46171305ae590b51 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine-dwh.spec.in A packaging/conf/settings.properties.in D packaging/legacy-setup/common_utils.py D packaging/legacy-setup/decorators.py D packaging/legacy-setup/ovirt-engine-dwh-setup.py M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.py A packaging/setup/ovirt_engine_setup/dwhconfig.py.in A packaging/setup/ovirt_engine_setup/dwhconstants.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/misc.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/service.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/pgpass.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/core/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/core/service.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/clear.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/config.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/jboss.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/service.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/distro-rpm/packages.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/provisioning/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/provisioning/postgres.py 35 files changed, 2,589 insertions(+), 2,357 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3cceaac390d5d373d2d1f5e46171305ae590b51 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: osinfo: do not use absolute paths
by sbonazzo＠redhat.com 16 Jan '14

16 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: utils: osinfo: do not use absolute paths ...................................................................... utils: osinfo: do not use absolute paths Project should always used build time customization for all paths. This enables working at devenv mode and at different distributions and settings. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1043206 Change-Id: I51be14104b73214602c491383fde6b34ef4f094c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M packaging/conf/osinfo-defaults.properties 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51be14104b73214602c491383fde6b34ef4f094c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: locale-independent log list of packages
by iheim＠redhat.com 16 Jan '14

16 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: locale-independent log list of packages ...................................................................... packaging: setup: locale-independent log list of packages Bug-Url: https://bugzilla.redhat.com/1044478 Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/ovirt-engine-log-setup-event.sh.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/23283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7eadd2aa2fafcc91d7efa3cf550ef89638f7b81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add Reboot VM action
by juan.hernandez＠redhat.com 16 Jan '14

16 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add Reboot VM action ...................................................................... restapi: Add Reboot VM action Added reboot action for VM. Change-Id: I072dd2e8292c21f1ad7f4794c7f273cfc5a670cb Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 5 files changed, 43 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/22745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072dd2e8292c21f1ad7f4794c7f273cfc5a670cb Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: services: ovirt-engine: support absolute path at ...
by sbonazzo＠redhat.com 16 Jan '14

16 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: support absolute path at ENGINE_APPS ...................................................................... packaging: services: ovirt-engine: support absolute path at ENGINE_APPS this enables to deploy wars of other packages without touching /usr Change-Id: I71f5b8850987372d1d785adceebf020d39a474eb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.py 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71f5b8850987372d1d785adceebf020d39a474eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Add RebootVmCommand
by ofrenkel＠redhat.com 16 Jan '14

16 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Add RebootVmCommand ...................................................................... backend: Add RebootVmCommand Added RebootVmCommand and corresponding RebootVmVDSCommand that utilizes the new boolean parameter of VDSM shutdown verb. Note: Currently, the VDSM will only attempt to perform reboot using guest-agent. Change-Id: I0693943c01e204da877268c02957f3b936cf3fa2 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RebootVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A packaging/dbscripts/upgrade/03_04_0470_add_reboot_command.sql 14 files changed, 124 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0693943c01e204da877268c02957f3b936cf3fa2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enables empty value in custom properties
by yzaslavs＠redhat.com 16 Jan '14

16 Jan '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Enables empty value in custom properties ...................................................................... core: Enables empty value in custom properties Enables empty values in custom VM and device properties. Change-Id: Id5ff5b2a839e8f1f5a56c9c1258252e3f24a08df Bug-Url: https://bugzilla.redhat.com/1046611 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/SimpleCustomPropertiesUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java 6 files changed, 36 insertions(+), 27 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5ff5b2a839e8f1f5a56c9c1258252e3f24a08df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0