- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add checkstyle rule EqualsHashCode
by oourfali＠redhat.com 18 Dec '13

18 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add checkstyle rule EqualsHashCode ...................................................................... engine: Add checkstyle rule EqualsHashCode Checks that classes that override equals() also override hashCode(). http://checkstyle.sourceforge.net/config_coding.html Change-Id: Id7f270aa850529e1894fe3fd6198930b1844402b Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f270aa850529e1894fe3fd6198930b1844402b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use getVm() or getTemplate instead of DAO access
by rgolan＠redhat.com 18 Dec '13

18 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: core: use getVm() or getTemplate instead of DAO access ...................................................................... core: use getVm() or getTemplate instead of DAO access use the internal caching of entities for the enclosing command and its descendants. Change-Id: Ia97195939c010b31ba26dcad4cc7347c3c25185f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia97195939c010b31ba26dcad4cc7347c3c25185f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, uicompat - supress several findbugs warnings.
by oourfali＠redhat.com 18 Dec '13

18 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine, uicompat - supress several findbugs warnings. ...................................................................... engine, uicompat - supress several findbugs warnings. Those warnings are false alarm, hence should be excluded from analysis. Change-Id: I08ef8c99afaa0a1cb66b3d8e5ca3e19e0ba8f78d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml M frontend/webadmin/modules/uicompat/exclude-filters.xml 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08ef8c99afaa0a1cb66b3d8e5ca3e19e0ba8f78d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Declare a multiple runner for PersistentSetupNetworks
by masayag＠redhat.com 18 Dec '13

18 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Declare a multiple runner for PersistentSetupNetworks ...................................................................... engine: Declare a multiple runner for PersistentSetupNetworks Executing a multiple PersistentSetupNetworks should be invoked in a separate thread per command, therefore a dedicated multiple action runner is set for the PersistentSetupNetworks. Change-Id: I92b4c7a31adbe2d7384a8857d2deba2ad0809d63 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92b4c7a31adbe2d7384a8857d2deba2ad0809d63 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduce PersistentSetupNetworksCommand
by masayag＠redhat.com 18 Dec '13

18 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Introduce PersistentSetupNetworksCommand ...................................................................... engine: Introduce PersistentSetupNetworksCommand The new command combines a sequence of 2 commands: 1. SetupNetworksCommand and upon successful execution: 2. CommitNetworkChangesCommand The command will be used internally only, when a network changes to multiple hosts are required, and the changes should be persisted. Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cleanup VdsActionParameters
by masayag＠redhat.com 18 Dec '13

18 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Cleanup VdsActionParameters ...................................................................... core: Cleanup VdsActionParameters Adjust visibility of host id and use proper naming convention. Change-Id: I2a2bc822842d05c6fc7a16902e46f4eccf143e9c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsActionParameters.java 1 file changed, 14 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a2bc822842d05c6fc7a16902e46f4eccf143e9c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: sdk: arguments name fixing
by mpastern＠redhat.com 18 Dec '13

18 Dec '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: arguments name fixing ...................................................................... sdk: arguments name fixing Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java 2 files changed, 14 insertions(+), 14 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, frontend: show template name also for cloned VMs
by tjelinek＠redhat.com 18 Dec '13

18 Dec '13

Tomas Jelinek has submitted this change and it was merged. Change subject: core,frontend: show template name also for cloned VMs ...................................................................... core,frontend: show template name also for cloned VMs If the template provisioning of the VM is clone, the general subtab of the VM/Pool shows that the "Template"'s value is Blank. This patch changes this to the following behavior: - for cloned provisioning the "Template" field shows: "templateName (Clone/Independent)" - for thin provisioning the "Template" field shows: "templateName (Thin/Dependent)" - for VMs created from Blank template the "Template" field shows: "templateName" - for VMs created before this feature added the "Template" field shows: "templateName" Same logic apply for the Storage main tab -> VM Import subtab -> Template column The implementation: Two new fields added to the vm_static table: - original_template_id: never changes - original_template_name: changes when the template on which this VM is based on changes the name. This is checked during VM/template import and during template update The original_template_name field is there and maintained "by hand" (instead of having a reference to the template in original_template_id) is because this field has to be shown even after the original template has been deleted. Change-Id: Ieea4ad7c1ed845d3ff57aaafc19f0830ab72b2d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1042784 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmTemplateNameRenderer.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_04_0280_add_original_template_to_vm_static.sql M packaging/dbscripts/vms_sp.sql 22 files changed, 263 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieea4ad7c1ed845d3ff57aaafc19f0830ab72b2d1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: rest: fix xsd validation for Payload
by mpastern＠redhat.com 18 Dec '13

18 Dec '13

Michael Pasternak has submitted this change and it was merged. Change subject: rest: fix xsd validation for Payload ...................................................................... rest: fix xsd validation for Payload volume id is optional parameter for payload, so setting minOccurs to 0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031960 Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Block profile creation even if network's flushed
by iheim＠redhat.com 18 Dec '13

18 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Block profile creation even if network's flushed ...................................................................... webadmin: Block profile creation even if network's flushed A previous fix neglected the fact that the Edit Network dialog could be flushed but remain open, e.g. as in the case of a failed backend action. This patch disables the profile creation logic in that case as well. Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1 Bug-Url: https://bugzilla.redhat.com/1043386 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/22508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0