- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Automatically replace bad tokens
by Code Review 30 Mar '17

30 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Automatically replace bad tokens ...................................................................... Automatically replace bad tokens Currently when the token used by the SDK is no longer valid, because it is expired or for any other reason, the following requests just fail. The only way to recover is to close the connection and open a new one. That isn't convenient for long running applications. To improve that this patch modifies the SDK so that it automatically replaces bad tokens, requesting new ones from the SSO service. Change-Id: I5af5069dbd4ae3adbe9aa726053edc21bcbdfda7 Bug-Url: https://bugzilla.redhat.com/1434831 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ae2554a954976739a51334409e6935f3f8fe9637) --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af5069dbd4ae3adbe9aa726053edc21bcbdfda7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Fix typo in missing 'href' message
by Code Review 30 Mar '17

30 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix typo in missing 'href' message ...................................................................... Fix typo in missing 'href' message Change-Id: Id791c196dc0f854860ba4eeff1ecfa48a9134d4b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit f78d9098f9fec4f72edbcb13fa13c778dd3f36ad) --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id791c196dc0f854860ba4eeff1ecfa48a9134d4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add example that list host statistics
by Code Review 30 Mar '17

30 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example that list host statistics ...................................................................... Add example that list host statistics This patch adds an example that shows how to list the statistics associated to a host. Change-Id: Iea971c70091d5ef30651584c3cbee31518f4c352 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6f88c3d21709b6dbc367c824fc084fad2e7552d0) --- A sdk/examples/list_host_statistics.rb 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea971c70091d5ef30651584c3cbee31518f4c352 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example that list host statistics
by Code Review 30 Mar '17

30 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example that list host statistics ...................................................................... Add example that list host statistics This patch adds an example that shows how to list the statistics associated to a host. Change-Id: Iea971c70091d5ef30651584c3cbee31518f4c352 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_host_statistics.rb 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea971c70091d5ef30651584c3cbee31518f4c352 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix typo in missing 'href' message
by Code Review 30 Mar '17

30 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix typo in missing 'href' message ...................................................................... Fix typo in missing 'href' message Change-Id: Id791c196dc0f854860ba4eeff1ecfa48a9134d4b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id791c196dc0f854860ba4eeff1ecfa48a9134d4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Localize all user facing sso messages
by Code Review 30 Mar '17

30 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Localize all user facing sso messages ...................................................................... aaa: Localize all user facing sso messages All message sent to browser from SSO needs to be localized. Change-Id: I84a56bdf76566da639763e6d22415f6752372f13 Bug-Url: https://bugzilla.redhat.com/1435140 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNextAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/resources/AppMessages.properties 4 files changed, 37 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a56bdf76566da639763e6d22415f6752372f13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add sso client command line registration tool
by Code Review 30 Mar '17

30 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add sso client command line registration tool ...................................................................... aaa: Add sso client command line registration tool Add a command line registration tool ovirt-register-sso-client to register new sso clients. On running the tool user is prompted to enter the client id, callback prefix and the certificate location. A new entry is created in the sso_clients table if one does not exist or the existing one with the same client id is updated. The client_secret which is written to the command line should be noted and used by the client. The client secret in the sso_clients table is in encrypted format and is for sso internal use only. Change-Id: I3b3d5a7c97ff806735f6abc2635cdcf12aadf3f9 Bug-Url: https://bugzilla.redhat.com/1425935 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M Makefile M backend/manager/pom.xml A backend/manager/sso-client-registration-tool/exclude-filters.xml A backend/manager/sso-client-registration-tool/pom.xml A backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/core/ExitException.java A backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/core/SsoLocalConfig.java A backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/core/SsoRegistrationToolExecutor.java A backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/db/DBUtils.java A backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/db/StandaloneDataSource.java A backend/manager/sso-client-registration-tool/src/main/modules/org/ovirt/engine/core/sso-client-registration-tool/main/module.xml A backend/manager/sso-client-registration-tool/src/main/resources/org/ovirt/engine/ssoreg/core/arguments.properties M ovirt-engine.spec.in A packaging/bin/ovirt-register-sso-client-tool.sh A packaging/conf/ovirt-register-sso-client-tool-logging.properties 14 files changed, 686 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b3d5a7c97ff806735f6abc2635cdcf12aadf3f9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: improve Discard After Delete UX
by Code Review 30 Mar '17

30 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: improve Discard After Delete UX ...................................................................... webadmin: improve Discard After Delete UX When creating/editing a block storage domain, the user is not warned when the value of Discard After Delete (DAD) is illegal (the storage domain contains at least one lun that doesn't support discard). Since the error comes from the backend, the user doesn't get the chance to fix the configuration before the popup is closed. This patch adds UI verifications for DAD to gain a better UX: 1. When enabling DAD, or when selecting a lun while DAD is already enabled - if the configuration is illegal then a warning message is shown above the view. 2. When clicking on "ok", DAD is validated so that if the configuration is illegal then the DAD checkbox is highlighted and the operation is blocked in the UI level. Change-Id: I3024fb3ba46ed568cfa0d9d84c15c416da7e335f Bug-Url: https://bugzilla.redhat.com/1436160 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 4 files changed, 68 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/74882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3024fb3ba46ed568cfa0d9d84c15c416da7e335f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: extract lun's discard logic to the LUNs class
by Code Review 30 Mar '17

30 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: extract lun's discard logic to the LUNs class ...................................................................... core: extract lun's discard logic to the LUNs class This patch extracts duplicated code about discard support to two new methods in Luns: supportsDiscard and hasDiscardZeroesTheDataSupport. Change-Id: I521ce2f96f074418fce604a4e25ea388860215e1 Related-To: https://bugzilla.redhat.com/1436160 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskVmElementValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 4 files changed, 19 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/74881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521ce2f96f074418fce604a4e25ea388860215e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: make SanStorageModelBase.getAddedLuns reusable
by Code Review 30 Mar '17

30 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: make SanStorageModelBase.getAddedLuns reusable ...................................................................... webadmin: make SanStorageModelBase.getAddedLuns reusable getAddedLuns used to return only the newly added luns, without the included ones (those which were already selected before). This patch adds a new method, getLuns, that receives parameters that indicate which luns to return - the added and the included ones. Change-Id: I67717bd3d9ec8c3332e94c0004f567e52294a264 Related-To: https://bugzilla.redhat.com/1436160 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/74880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67717bd3d9ec8c3332e94c0004f567e52294a264 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0