- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: rest: fix rsdl for cloud-init parameters
by iheim＠redhat.com 04 Dec '13

04 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: rest: fix rsdl for cloud-init parameters ...................................................................... rest: fix rsdl for cloud-init parameters fix error with brackets in cloud init parameters for run vm rsdl definition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990572 Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove restriction of vnic profile's network
by masayag＠redhat.com 04 Dec '13

04 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Remove restriction of vnic profile's network ...................................................................... restapi: Remove restriction of vnic profile's network The schema shouldn't restrict the minimal occurrences of the vnic profile's network property. Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Bug-Url: https://bugzilla.redhat.com/1031925 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typos in comments
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix typos in comments ...................................................................... core: fix typos in comments Change-Id: I83a7bd55f84379d63355fa144698c4cb1db60c6d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83a7bd55f84379d63355fa144698c4cb1db60c6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix uppercase methods
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix uppercase methods ...................................................................... core: fix uppercase methods This patch renames OnTimer to onTimer in different scheduled tasks in the engine. Change-Id: I5028bc025c540c1eefec00f63e512e5ec8d91c8a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 4 files changed, 15 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5028bc025c540c1eefec00f63e512e5ec8d91c8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: supress 2 findbugs in ConfigDaoImpl
by oourfali＠redhat.com 04 Dec '13

04 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine: supress 2 findbugs in ConfigDaoImpl ...................................................................... engine: supress 2 findbugs in ConfigDaoImpl Supress (exclude) 2 findbugs warnings in ConfigDaoImpl since they are not correct. Change-Id: I979843feb986b5424d986f00abdd0d442817c066 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/tools/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Alissa Bonas: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979843feb986b5424d986f00abdd0d442817c066 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Revert "Adding support for user types cleanup"
by iheim＠redhat.com 04 Dec '13

04 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: Revert "Adding support for user types cleanup" ...................................................................... Revert "Adding support for user types cleanup" This reverts commit d953002370f78293ee5e9783f60e30aa0a5336d1. The user_defined_types view was added in 9.2 only , we shall find a workaround for that in versions below 9.2 http://www.postgresql.org/docs/9.2/static/infoschema-user-defined-types.html Change-Id: I6f9cf106759da4e2fb2ca632c3d8a5acf86b50a9 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/dbfunctions.sh M packaging/setup/ovirt_engine_setup/database.py 3 files changed, 6 insertions(+), 23 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f9cf106759da4e2fb2ca632c3d8a5acf86b50a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore "class too big" findbug on ApplicationConst...
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: frontend: ignore "class too big" findbug on ApplicationConstants ...................................................................... frontend: ignore "class too big" findbug on ApplicationConstants Add to excluded warnings filter the "class too big" warning generated on ApplicationConstants class. Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/exclude-filters.xml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: rest: fix rsdl for cloud-init parameters
by ofrenkel＠redhat.com 04 Dec '13

04 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: rest: fix rsdl for cloud-init parameters ...................................................................... rest: fix rsdl for cloud-init parameters fix error with brackets in cloud init parameters for run vm rsdl definition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990572 Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in BaseHandler
by yzaslavs＠redhat.com 03 Dec '13

03 Dec '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: rename method to lowercase in BaseHandler ...................................................................... core: rename method to lowercase in BaseHandler Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Add support for maintenance mode reporting
by sbonazzo＠redhat.com 03 Dec '13

03 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add support for maintenance mode reporting ...................................................................... Add support for maintenance mode reporting Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034323 Change-Id: Ib21774d33fd50bc1da47a60b6fd48859ca27cfda Signed-off-by: Martin Sivak <mars(a)montik.net> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib21774d33fd50bc1da47a60b6fd48859ca27cfda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0