- Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[ovirt-host-deploy-1.1]: packaging: ovirt-host-deploy-1.1.2
by Alon Bar-Lev 01 Dec '13

01 Dec '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.1.2 ...................................................................... packaging: ovirt-host-deploy-1.1.2 Change-Id: Ib64ca00b0e778adf6431dc72f69857fa0e2e86f2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy.spec.in 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64ca00b0e778adf6431dc72f69857fa0e2e86f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename 2 methods in VdsHandler to lowercase
by tnisan＠redhat.com 01 Dec '13

01 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename 2 methods in VdsHandler to lowercase ...................................................................... core: rename 2 methods in VdsHandler to lowercase Fix to start with lowercase per java naming standard, cleans findbugs warnings. Change-Id: Id6536bf050ec09077aa36412cc99bd93c168f32e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6536bf050ec09077aa36412cc99bd93c168f32e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactor VdsUpdateRunTimeInfo to use diamond operator
by ofrenkel＠redhat.com 01 Dec '13

01 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor VdsUpdateRunTimeInfo to use diamond operator ...................................................................... core: refactor VdsUpdateRunTimeInfo to use diamond operator VdsUpdateRunTimeInfo class has many members which are data structures. Initialize them using the diamond operator makes the code a bit more organized and shorter. Change-Id: Ieb0d5f931aee3749a2aad46e34991b97e46ccf8e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 17 insertions(+), 20 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb0d5f931aee3749a2aad46e34991b97e46ccf8e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: delete unused class TypeUtil
by tnisan＠redhat.com 01 Dec '13

01 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: frontend: delete unused class TypeUtil ...................................................................... frontend: delete unused class TypeUtil Change-Id: I91c87ea65c7e3813127ddb23e5b6e16d2af55181 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91c87ea65c7e3813127ddb23e5b6e16d2af55181 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Allow enabling/disabling SSO
by ofrenkel＠redhat.com 01 Dec '13

01 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: frontend: Allow enabling/disabling SSO ...................................................................... frontend: Allow enabling/disabling SSO This small feature allows controlling SSO per VM. Changes: - new radio buttons in New/Edit VM/Template/VmPool dialog. Change-Id: I213110a1554cd67b6cd8560477b5d7551e89f24e Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1035279 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 16 files changed, 113 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I213110a1554cd67b6cd8560477b5d7551e89f24e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Allow enabling/disabling SSO
by ofrenkel＠redhat.com 01 Dec '13

01 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Allow enabling/disabling SSO ...................................................................... core: Allow enabling/disabling SSO This small feature allows controlling SSO per VM. Changes: - new attribute of VM/Template/Pool SsoMethod - SsoMethod is an enum that describes which sso method will be used (for now only two options are possible [disable sso/use guest agent]). In future this can be extended. Default sso method is to use guest agent. Change-Id: I175ecd61c35b8354706d6dedda1e211bf2400c54 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1035279 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_04_0140_add_sso_method_to_vm_static.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 17 files changed, 107 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I175ecd61c35b8354706d6dedda1e211bf2400c54 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by derez＠redhat.com 01 Dec '13

01 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is a third patch following http://gerrit.ovirt.org/#/c/21838/ Change-Id: Ie4ded6654051a23f5abb1bdfb7cf6a142bdfd78a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ded6654051a23f5abb1bdfb7cf6a142bdfd78a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: doc: update ChangeLog
by Alon Bar-Lev 01 Dec '13

01 Dec '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: update ChangeLog ...................................................................... doc: update ChangeLog Change-Id: Ie66d8f9de84e90cc0309ab50bd07423acd7dbfcf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie66d8f9de84e90cc0309ab50bd07423acd7dbfcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: VM dialog Host tab for Local SD
by iheim＠redhat.com 01 Dec '13

01 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: VM dialog Host tab for Local SD ...................................................................... webadmin: VM dialog Host tab for Local SD In vm/template/pool dialog Host tab will be visible for local SD data center (to show other host fields, used to be hidden). In local DC Migration fields will be disabled and set to non-migratable and pinned. Change-Id: I490f19a9a66c78d9f0d81bf5fb009d2a8eec38a4 Bug-Url: https://bugzilla.redhat.com/1018201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 4 files changed, 16 insertions(+), 28 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I490f19a9a66c78d9f0d81bf5fb009d2a8eec38a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: packaging: setup: postgres provision: generate only ASCII pa...
by sbonazzo＠redhat.com 01 Dec '13

01 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: postgres provision: generate only ASCII password ...................................................................... packaging: setup: postgres provision: generate only ASCII password python string module is locale aware, so generating letter in non unicode locale will result non unicode password, unreadable by java. instead of using the string module, use hardcoded known good characters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035932 Change-Id: I1b27d8eb26c777617ff3bf625b979a75bc3225c6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b27d8eb26c777617ff3bf625b979a75bc3225c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0