- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove compat from OVF.
by Code Review 26 Mar '17

26 Mar '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove compat from OVF. ...................................................................... core: Remove compat from OVF. Using compat version in the OVF might be misleading since the compat version of a QCOW volume is determined internally by the storage domain's version. Showing a QCOW version in the OVF might mislead the user to think that previewing this snapshot will create a volume with this QCOW compat. Change-Id: I02cf7913653d095012d2f001921dda0e16e8354d Bug-Url: https://bugzilla.redhat.com/1430447 Bug-Url: https://bugzilla.redhat.com/1432493 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 8 files changed, 76 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/74008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02cf7913653d095012d2f001921dda0e16e8354d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in preview snapshot command
by Code Review 26 Mar '17

26 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in preview snapshot command ...................................................................... core: minor cleanup in preview snapshot command 1. Better format in a comment 2. Improve log message 3. Reduce the visibility of the validateCinder method Change-Id: Id43c3a18d237c68d2e7bb6544edd19de61751fcf Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/74636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id43c3a18d237c68d2e7bb6544edd19de61751fcf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add missing validation in previewing a snapshot
by Code Review 26 Mar '17

26 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: add missing validation in previewing a snapshot ...................................................................... core: add missing validation in previewing a snapshot Need to validate the VM exists. Change-Id: Idc702f920c4b59bef96822e9e5f9706b5c296267 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/74637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc702f920c4b59bef96822e9e5f9706b5c296267 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: jenkins: split scan_security_and_license job
by Code Review 26 Mar '17

26 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins: split scan_security_and_license job ...................................................................... jenkins: split scan_security_and_license job As part of the effort to enable using the 'jenkins' repo to create different jobs for different Jenkins instances, I'm splitting some jobs that are defined inside the YAML dir instead of the 'standard' definition of 'project' and 'job template' Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1264 Change-Id: I82bd1b845cafff4ccdd315517be2b65961592d5b Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- A jobs/confs/projects/ovirt-engine/scan_security_and_license.yaml R jobs/confs/yaml/templates/scan_security_and_license_ovirt-engine_master-template.yaml 2 files changed, 14 insertions(+), 7 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82bd1b845cafff4ccdd315517be2b65961592d5b Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: jenkins: Removed dcaro & vishnu from email alerts
by Code Review 26 Mar '17

26 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins: Removed dcaro & vishnu from email alerts ...................................................................... jenkins: Removed dcaro & vishnu from email alerts Change-Id: I9eca4df30293357df965811e8def1a4b1b4ecc0b Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/system/system_gerrit-alert-old-patches.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests; Ready for merge Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/74569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eca4df30293357df965811e8def1a4b1b4ecc0b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: jenkins: moved system jobs to /projects/system/
by Code Review 26 Mar '17

26 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins: moved system jobs to /projects/system/ ...................................................................... jenkins: moved system jobs to /projects/system/ As part of the effort to enable using the 'jenkins' repo to create different jobs for different Jenkins instances, I'm splitting some jobs that are defined inside the YAML dir instead of the 'standard' definition of 'project' and 'job template' Change-Id: If08126b1d2d8854ae412500bc70e457246b68ca0 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- R jobs/confs/projects/system/system_gerrit-alert-old-patches.yaml R jobs/confs/projects/system/system_jobs.yaml 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If08126b1d2d8854ae412500bc70e457246b68ca0 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: jenkins: Split ovirt-engine-_coverity-analysis job
by Code Review 26 Mar '17

26 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins: Split ovirt-engine-_coverity-analysis job ...................................................................... jenkins: Split ovirt-engine-_coverity-analysis job As part of the effort to enable using the 'jenkins' repo to create different jobs for different Jenkins instances, I'm splitting some jobs that are defined inside the YAML dir instead of the 'standard' definition of 'project' and 'job template' Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1264 Change-Id: I666f261b6cbd250290341317528c467db21ff83a Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- A jobs/confs/projects/ovirt-engine/ovirt-engine_coverity-analysis.yaml M jobs/confs/shell-scripts/coverity_analysis.sh D jobs/confs/yaml/jobs/ovirt-engine_master_coverity-analysis.yaml M jobs/confs/yaml/scms/ovirt-engine.yaml A jobs/confs/yaml/templates/ovirt-engine_coverity-analysis.yaml 5 files changed, 50 insertions(+), 29 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/74550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I666f261b6cbd250290341317528c467db21ff83a Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Template name limited for 40 characters
by Code Review 26 Mar '17

26 Mar '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: Template name limited for 40 characters ...................................................................... core: Template name limited for 40 characters There is no need for that since the DB and VM are limited for 255 chars. Change-Id: I9f94f85b098f499734570e96dada007fc2c27336 Bug-Url: https://bugzilla.redhat.com/1416306 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java 3 files changed, 15 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f94f85b098f499734570e96dada007fc2c27336 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: add active hosts caching in NetworkClusterHelper
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: add active hosts caching in NetworkClusterHelper ...................................................................... engine: add active hosts caching in NetworkClusterHelper Change-Id: I4ca0a3a1d7979ce7017d37cb3dc982464e20be26 Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 2 files changed, 98 insertions(+), 49 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca0a3a1d7979ce7017d37cb3dc982464e20be26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: use vdsDynamicDao instead of vdsDao
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: use vdsDynamicDao instead of vdsDao ...................................................................... engine: use vdsDynamicDao instead of vdsDao Avoid using vdsDao as it uses very complicated vds view. Change-Id: I54eaaf3cb49296da8378eab37504be0064e3810b Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54eaaf3cb49296da8378eab37504be0064e3810b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0