- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: add disk: quota fix
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: add disk: quota fix ...................................................................... webadmin: add disk: quota fix Quota should be populated according to selected storage domain Change-Id: I5a26d46af003ff2f0c95dff6abcb8b7880aea72e Bug-Url: https://bugzilla.redhat.com/1004677 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a26d46af003ff2f0c95dff6abcb8b7880aea72e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix QoS dialog indentation
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fix QoS dialog indentation ...................................................................... webadmin: fix QoS dialog indentation Labels will be positions above the fields, instead of next to it (to avoid other locale issues). Also fixed unnecessary dialog scroll bars, and adjusted dialog width. Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Bug-Url: https://bugzilla.redhat.com/1001546 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml 2 files changed, 74 insertions(+), 57 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbcfa6849284d2e087c6884aa79cd77d9f4c3096 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: translated string broken into two lines
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: translated string broken into two lines ...................................................................... webadmin: translated string broken into two lines [zh_CN][Admin Portal] Translated string of 'Last' broken into two lines in the 'Enabled Filters' field of 'Edit Cluster Policy' dialog. Change-Id: Iae00929423d617117158c5ca3e5f942eaa3a98de Bug-Url: https://bugzilla.redhat.com/1001415 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae00929423d617117158c5ca3e5f942eaa3a98de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Do not fail on upgrade from 3.2 to 3.3
by emesika＠redhat.com 29 Sep '13

29 Sep '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Do not fail on upgrade from 3.2 to 3.3 ...................................................................... engine: Do not fail on upgrade from 3.2 to 3.3 In case there are more than one VM or template configured for port mirroring, the inner stored procedure used to fail. The patch modifies the STP to support network with several VMs or Templates using port mirroring. Change-Id: I1b995dcde32ddf99b841bbddb19edf67d7061731 Bug-Url: https://bugzilla.redhat.com/1013341 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M packaging/dbscripts/upgrade/03_03_0710_add_profile_to_network_interface.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b995dcde32ddf99b841bbddb19edf67d7061731 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: scheduling: remove migration filter
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: scheduling: remove migration filter ...................................................................... core: scheduling: remove migration filter it seems that without migration filter (filters out the 'migration from' host), the scheduler can select the same source host. solution: remove the migration filter, and in migrate vm add the source host to the scheduler host black list. Change-Id: Ibd1007bbc5be01043203cd4eff1aa52c6fb03a13 Bug-Url: https://bugzilla.redhat.com/1008153 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A packaging/dbscripts/upgrade/03_03_0910_remove_migration_filter.sql 3 files changed, 12 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1007bbc5be01043203cd4eff1aa52c6fb03a13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add foreign key to quota_id
by gchaplik＠redhat.com 29 Sep '13

29 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: add foreign key to quota_id ...................................................................... core: add foreign key to quota_id problem: quota_id field (in vm_static and images) isn't linked to quota table, therefore when removing a quota, it doesn't clear the quota_id ref. solution: set quota_id fields as foreign keys and use set NULL on delete. Currently there is extensive usage of Guid.Empty to indicate null, removed that in relevant DAOs. Upgrade: - set NULL instead of Guid.Empty - set NULL instead of non-existing quota ids - add the foreign key constraint Change-Id: I5092a3070937719009fa1fb4fb9ecb792f03b969 Bug-Url: https://bugzilla.redhat.com/1003839 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java A packaging/dbscripts/upgrade/03_03_0900_quota_id_foreign_key.sql 6 files changed, 16 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5092a3070937719009fa1fb4fb9ecb792f03b969 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Force uniform capitalization of "vNIC"
by masayag＠redhat.com 29 Sep '13

29 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Force uniform capitalization of "vNIC" ...................................................................... webadmin: Force uniform capitalization of "vNIC" There were several variations of capitalization, made them all the same. Change-Id: I4c8dd1c43f7d3e9fe38fa3c1b1b2592488e0090b Bug-Url: https://bugzilla.redhat.com/970900 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c8dd1c43f7d3e9fe38fa3c1b1b2592488e0090b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: ovirt-live: replace build.sh with a Makefile
by obasan＠redhat.com 29 Sep '13

29 Sep '13

Ohad Basan has submitted this change and it was merged. Change subject: ovirt-live: replace build.sh with a Makefile ...................................................................... ovirt-live: replace build.sh with a Makefile Change-Id: Ib83cf9e56b151c7f2b5392d7bfd6ebed2df04ac9 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- A centos/.gitignore A centos/Makefile D centos/build.sh 3 files changed, 70 insertions(+), 16 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83cf9e56b151c7f2b5392d7bfd6ebed2df04ac9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Expand nics filter criteria
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Expand nics filter criteria ...................................................................... engine: Expand nics filter criteria The engine query for retrieving the host nics should consider nics which aren't bonds either by VdsNetworkInterface.getBonded() being equal to null or to Boolean.False. Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Bug-Url: https://bugzilla.redhat.com/1011486 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I587e51efaf935fafbfbe814bb4a1f1dea1a5ab94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Increased width of provider field
by iheim＠redhat.com 29 Sep '13

29 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Increased width of provider field ...................................................................... webadmin: Increased width of provider field Line would get broken in Japanese. Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Bug-Url: https://bugzilla.redhat.com/1009807 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1ecee2c861eda31adac7be26756d8f65250da0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0