- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Prevent NPE with cobertura
by masayag＠redhat.com 25 Sep '13

25 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Prevent NPE with cobertura ...................................................................... core: Prevent NPE with cobertura The NetworkDaoDbFacadeImpl contains an abstract row mapper and then two derived ones, and all of them, including the abstract one contain a singleton. The singleton in the abstract one is never used, and it causes a NPE if used. Some tools, like cobertura, generate code that uses all the fields, and thus reveal this hidden NPE. This patch just removes the unused field. Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3]: Add a controlling TTY for ausearch
by sbonazzo＠redhat.com 25 Sep '13

25 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add a controlling TTY for ausearch ...................................................................... Add a controlling TTY for ausearch The ausearch command required a controlling TTY in order to finish execution propely. This fix adds the '-t' flag to the ssh command used in the log-collector Signed-off-by: James W. Mills <jamills(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1010472 Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf --- M src/__main__.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: Add a controlling TTY for ausearch
by sbonazzo＠redhat.com 25 Sep '13

25 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add a controlling TTY for ausearch ...................................................................... Add a controlling TTY for ausearch The ausearch command required a controlling TTY in order to finish execution propely. This fix adds the '-t' flag to the ssh command used in the log-collector Signed-off-by: James W. Mills <jamills(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1010472 Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf --- M src/__main__.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved James W. Mills: Verified -- To view, visit http://gerrit.ovirt.org/19471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: James W. Mills <jamills(a)redhat.com> Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Rebalance status display bug correction
by kmayilsa＠redhat.com 25 Sep '13

25 Sep '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Rebalance status display bug correction ...................................................................... webadmin : Rebalance status display bug correction Due to NPE Rebalance status popup was displayed some times only. This is now corrected. Change-Id: I1116cf62df0aeffef26e91c7de63639d20f9b1d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011778 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1116cf62df0aeffef26e91c7de63639d20f9b1d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: revert the existing solution for bz 878041
by ofrenkel＠redhat.com 25 Sep '13

25 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: revert the existing solution for bz 878041 ...................................................................... core: revert the existing solution for bz 878041 Before having the auto-start VMs runner job, the problem of HA VMs that could not be restarted when failing during live snapshot operation was solved by comparing the state of the VM at the end of the live snapshot operation with its state when the command started, and if we saw that the VM went down unintentionally we ran it at the end of the live snapshot command. That solution was wrong since it was specific to live snapshot operation and it required to put large portion of the code in endVmCommand method inside new transaction scope. Now that we lock the VM for the entire live snapshot operation and we have the auto-start VMs runner job that keep trying to restart failed HA VM while it is locked, which is a more general and clean solution that solves this case as well, we can revert the previous solution. Change-Id: I242a2278c9c23139026b58564ee35967e5258bfe Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java 2 files changed, 41 insertions(+), 85 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I242a2278c9c23139026b58564ee35967e5258bfe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: lock VM for whole live snapshot process
by ofrenkel＠redhat.com 25 Sep '13

25 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: lock VM for whole live snapshot process ...................................................................... core: lock VM for whole live snapshot process VM was used to be locked for the entire live snapshot process only in case the snapshot contained memory. If the snapshot did not contain memory, the lock was released in the execute state of the command. This patch changes that, such that the VM will be locked for the entire live snapshot process in any case. By keeping the VM locked for the entire process, we prevent other operations which should not run in parallel to run, as long as they also try to lock the VM. Change-Id: Ib455a3b27d7b032c6a706753a6e58e07d3a1bc14 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib455a3b27d7b032c6a706753a6e58e07d3a1bc14 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: ovirt-live: build from stable repo
by obasan＠redhat.com 25 Sep '13

25 Sep '13

Ohad Basan has submitted this change and it was merged. Change subject: ovirt-live: build from stable repo ...................................................................... ovirt-live: build from stable repo Change-Id: I4f2e516a8dc0c331e363cd042284b24cf679e3c2 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M centos/kickstart/ovirt-live-base.ks.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2e516a8dc0c331e363cd042284b24cf679e3c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: fix default filemod in copyFile
by oschreib＠redhat.com 25 Sep '13

25 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fix default filemod in copyFile ...................................................................... packaging: fix default filemod in copyFile copyFile used to call os.chmod(file, filemod) with filemod defaulting to '-1'. Older linux kernels kept the mode unchanged in such a case, but newer ones don't. More details in the "Bug-Url" link below. This change defaults filemod to None and only calls os.chown if filemod is set. Bug-Url: https://bugzilla.redhat.com/1011616 Change-Id: I9e436d72e8ffb8d48e05201727d5b46797881556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/19557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e436d72e8ffb8d48e05201727d5b46797881556 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Improve CommandsFactory exception logging
by yzaslavs＠redhat.com 25 Sep '13

25 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improve CommandsFactory exception logging ...................................................................... core: Improve CommandsFactory exception logging Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed dead code
by masayag＠redhat.com 24 Sep '13

24 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Removed dead code ...................................................................... webadmin: Removed dead code Was there originally to enable removing a VNIC if hotplug was available, but then the removal was disabled to make users explicitly unplug VNIC first. The code stayed there, some of it was removed due to findbugs findings but some was left. Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0