- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: utils: cleanup: ignore File.xxx() return value
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: ignore File.xxx() return value ...................................................................... utils: cleanup: ignore File.xxx() return value make coverity happy. Change-Id: I294b37963c74148f388db2ea37bcdc542ee47998 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java 2 files changed, 24 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I294b37963c74148f388db2ea37bcdc542ee47998 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: cleanup: TarTest: File.getParent() may return null
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: TarTest: File.getParent() may return null ...................................................................... utils: cleanup: TarTest: File.getParent() may return null unlikely in this context, but make coverity happy. Change-Id: Id4b0c1a9b5a8a7ab024c8065cbdf237b964bde9d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java 1 file changed, 6 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4b0c1a9b5a8a7ab024c8065cbdf237b964bde9d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: ssh: move transfer test to try with resources
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: move transfer test to try with resources ...................................................................... utils: ssh: move transfer test to try with resources Change-Id: If11e822c8cdc17791062d4d0bec318e4c7452cb9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java 1 file changed, 7 insertions(+), 17 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If11e822c8cdc17791062d4d0bec318e4c7452cb9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: cleanup: ssh: move inner classes to be static
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: ssh: move inner classes to be static ...................................................................... utils: cleanup: ssh: move inner classes to be static Change-Id: I8cbe799df5722643936388ff4a6074dbcfe48d7f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cbe799df5722643936388ff4a6074dbcfe48d7f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: cleanup: MockEngineLocalConfigRule remove unused member
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: MockEngineLocalConfigRule remove unused member ...................................................................... utils: cleanup: MockEngineLocalConfigRule remove unused member Change-Id: I00857fdc81ca00f176f33e53b5f819b9010c9ab1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEngineLocalConfigRule.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00857fdc81ca00f176f33e53b5f819b9010c9ab1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: cleanup: LocalConfig: relay on File.listFiles() retur...
by yzaslavs＠redhat.com 17 Sep '13

17 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: LocalConfig: relay on File.listFiles() return value ...................................................................... utils: cleanup: LocalConfig: relay on File.listFiles() return value make coverity happy by not check if file is directory before listFiles, but relay on the listFiles return code. Change-Id: I2308e1e58ffb778aea5100df577d636d96acfa8f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2308e1e58ffb778aea5100df577d636d96acfa8f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix confusing getStorageDomainDao() method
by amureini＠redhat.com 17 Sep '13

17 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix confusing getStorageDomainDao() method ...................................................................... core: Fix confusing getStorageDomainDao() method Removed getStorageDomainDao() and used the pre-existing getStorageDoaminDAO() instead. Change-Id: I7f4b339849f8e8aa13c9d4ad26b34a1fb63cdf32 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Lee Yarwood: Looks good to me, but someone else must approve Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f4b339849f8e8aa13c9d4ad26b34a1fb63cdf32 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: sanlock: creates metadata file
by sbonazzo＠redhat.com 17 Sep '13

17 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: sanlock: creates metadata file ...................................................................... sanlock: creates metadata file Creates the metadata file is shared by all hosts participating in the engine high availability cluster. Each host is assigned a 4KiB chunk according to its host id, with a corresponding offset of host_id*4KiB. The initial 4KiB of the file are reserved for shared state such as a global engine ha maintenance bit. Change-Id: I8862209fe2fd783aaeab04d2c655afd9e1a10396 Bug-Url: https://bugzilla.redhat.com/1008501 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 3 files changed, 19 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8862209fe2fd783aaeab04d2c655afd9e1a10396 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Calculate 'procedureName' just once.
by amureini＠redhat.com 16 Sep '13

16 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Calculate 'procedureName' just once. ...................................................................... engine: Calculate 'procedureName' just once. Change-Id: Ia79e6b239f99416e4d2e21cf44d002f1447e9b70 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia79e6b239f99416e4d2e21cf44d002f1447e9b70 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to start with lowercase
by amureini＠redhat.com 16 Sep '13

16 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename method to start with lowercase ...................................................................... core: rename method to start with lowercase Change-Id: I55adeeec30119d3ef307628bdf753c4786f8b754 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55adeeec30119d3ef307628bdf753c4786f8b754 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0