- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: setup: fix for DB creation in non default locale
by ydary＠redhat.com 09 Sep '13

09 Sep '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix for DB creation in non default locale ...................................................................... packaging: setup: fix for DB creation in non default locale Change-Id: I016d1503ede16c2128cf8a1905bf420c99a2a4ce Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I016d1503ede16c2128cf8a1905bf420c99a2a4ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Restricted VNIC names to ASCII characters
by gchaplik＠redhat.com 09 Sep '13

09 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Restricted VNIC names to ASCII characters ...................................................................... webadmin: Restricted VNIC names to ASCII characters Used to allow Unicode characters as well, which meant it was more permissive than the backend validation. Change-Id: Id85f0cec55ab073eff0a26acc884350d0977a1a0 Bug-Url: https://bugzilla.redhat.com/1002146 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NoSpecialCharactersWithDotValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 17 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85f0cec55ab073eff0a26acc884350d0977a1a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Disallow endless authentication session #1005749
by mpastern＠redhat.com 09 Sep '13

09 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Disallow endless authentication session #1005749 ...................................................................... restapi: Disallow endless authentication session #1005749 Change-Id: I3cabe1d9e42f390ee944d29f0dd78246689107dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005749 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cabe1d9e42f390ee944d29f0dd78246689107dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Disallow endless authentication session #1005749
by mpastern＠redhat.com 09 Sep '13

09 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Disallow endless authentication session #1005749 ...................................................................... restapi: Disallow endless authentication session #1005749 Change-Id: I3cabe1d9e42f390ee944d29f0dd78246689107dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005749 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cabe1d9e42f390ee944d29f0dd78246689107dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add job that runs HA VMs which failed to run
by ofrenkel＠redhat.com 09 Sep '13

09 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add job that runs HA VMs which failed to run ...................................................................... core: add job that runs HA VMs which failed to run This patch adds quartz job which is responsible to run highly available VMs which are down. As a first step it would run HA VMs that could not run because they were locked on last attempt. This patch solves the following problem: when trying to run highly available VM that went down during live storage migration, the RunVmCommand fails because the VM is locked during the migration and the VM won't be started again automatically. Now, when the lock could not be acquired, the newly added job will periodically try to run the VM and when the live storage migration will end, the VM will start. Change-Id: I3d563d05efc6dae40f0de8e7f4b7e47aa84bd787 Bug-Url: https://bugzilla.redhat.com/891634 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 80 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d563d05efc6dae40f0de8e7f4b7e47aa84bd787 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added DC ID to profiles in Edit Network
by gchaplik＠redhat.com 09 Sep '13

09 Sep '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Added DC ID to profiles in Edit Network ...................................................................... webadmin: Added DC ID to profiles in Edit Network The DC ID had formerly ben set to null, so when new profiles were added the QoS list appeared empty. Change-Id: I07f542510323a1ff1fa77436821ebbe9216b588c Bug-Url: https://bugzilla.redhat.com/1005548 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07f542510323a1ff1fa77436821ebbe9216b588c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: fix for remote DB installation over otopi
by ydary＠redhat.com 09 Sep '13

09 Sep '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix for remote DB installation over otopi ...................................................................... packaging: setup: fix for remote DB installation over otopi Change-Id: I4d5a50c158ebdf262283d18af8559c670d97e184 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 17 insertions(+), 16 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d5a50c158ebdf262283d18af8559c670d97e184 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix log when detecting HA VM went down
by ofrenkel＠redhat.com 09 Sep '13

09 Sep '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix log when detecting HA VM went down ...................................................................... core: fix log when detecting HA VM went down The previous log message noted that there was an error while starting the VM everytime the monitoring detects that HA VM went down. This might be wrong since the VM might already be UP before it went down. Thus, this patch corrects the log message. Change-Id: I563d914d9adfa7e555b1c5d21d39c10d5b1d4b41 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I563d914d9adfa7e555b1c5d21d39c10d5b1d4b41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Ignoring specParams when serialization
by rgolan＠redhat.com 09 Sep '13

09 Sep '13

Roy Golan has submitted this change and it was merged. Change subject: core: Ignoring specParams when serialization ...................................................................... core: Ignoring specParams when serialization SpecParams isn't needed in serialization and fails the desialization due to abstract type usage (java.util.Map) JsonIgnore on a getter method simply doesn't work at current Jackson impl unless used in a MixIn. Added a new Mixin for VmPayload Removed @JsonIgnore from VMPayload class Bug-Url: https://bugzilla.redhat.com/985008 Change-Id: I33a6e38a83a715aa359497e0089c16b610d1234a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmPayloadMixIn.java 3 files changed, 18 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33a6e38a83a715aa359497e0089c16b610d1234a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: compare to Boolean with equals
by mpastern＠redhat.com 09 Sep '13

09 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: compare to Boolean with equals ...................................................................... restapi: compare to Boolean with equals Fix findbug warning - compare to Boolean with equals instead of ==. Change-Id: If7f0738730552bb8d2b935551bf9fcf938971834 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7f0738730552bb8d2b935551bf9fcf938971834 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0