- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: fix add watchdog
by dfediuck＠redhat.com 25 Aug '13

25 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: fix add watchdog ...................................................................... engine: fix add watchdog Fixes the watchdog add in restapi. - added validation for adding and updating entities - removed WatchdogsResource as it was not needed Change-Id: I95362fda69b8ec7c02893ba30cdf19be7eee5eac Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogAction.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogModel.java 8 files changed, 29 insertions(+), 20 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95362fda69b8ec7c02893ba30cdf19be7eee5eac Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fixing restore.sh
by emesika＠redhat.com 25 Aug '13

25 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: Fixing restore.sh ...................................................................... Fixing restore.sh * Fixed return values logic * Changed if statements to modern bash style * Added quotes on all variables * Using tab for indentation * Using mktemp to create a tpm directory instead of hardcoded name Change-Id: I5df0eaf0c18d5d009b1e11c86b35beafecb1b6f0 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M packaging/dbscripts/restore.sh 1 file changed, 98 insertions(+), 96 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5df0eaf0c18d5d009b1e11c86b35beafecb1b6f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unused variable declaration
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Removed unused variable declaration ...................................................................... engine: Removed unused variable declaration Change-Id: I2d048479f4cd566fc198f0496e2222b26f2575c4 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d048479f4cd566fc198f0496e2222b26f2575c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: Add search by id to VMs object
by shavivi＠redhat.com 25 Aug '13

25 Aug '13

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Add search by id to VMs object ...................................................................... Engine: Add search by id to VMs object Change-Id: I5a59a199846d4991130737c795eb871eb02fa29f bug-url: https://bugzilla.redhat.com/982050 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a59a199846d4991130737c795eb871eb02fa29f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: unlock_entity script should validate...
by emesika＠redhat.com 25 Aug '13

25 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: unlock_entity script should validate... ...................................................................... core: unlock_entity script should validate... unlock_entity script should validate command line before asking confirmation Change-Id: I1c7011b97e6796e096a8985180138d6ae7447270 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974924 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/unlock_entity.sh 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c7011b97e6796e096a8985180138d6ae7447270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Add support for multiple IDs in unlock_entity.sh
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Add support for multiple IDs in unlock_entity.sh ...................................................................... engine: Add support for multiple IDs in unlock_entity.sh Adds support to enter multiple IDs of same type as parameters of unlock_entity.sh script. This patch make '-i' parameter obsolete and entity IDs has to be entered as last parameter of the script. Example: unlock_entity.sh -t vm 1 2 3 Change-Id: Ic1f9807eef92b9d4cf6f0c020e059ffe549badf2 Bug-Url: https://bugzilla.redhat.com/960448 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/unlock_entity.sh 2 files changed, 12 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f9807eef92b9d4cf6f0c020e059ffe549badf2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Unable to search on domain for users with some search ...
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Unable to search on domain for users with some search options. ...................................................................... core: Unable to search on domain for users with some search options. Search failed, when try to search user on domain with special keyword. This happens when user search by lastname, department and title. Fix for IPA, OpenLDAP and RHDS Change-Id: I351a8c0e3341a6f975efec210398267aa828c3e0 Bug-Url: https://bugzilla.redhat.com/975380 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I351a8c0e3341a6f975efec210398267aa828c3e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: tools : engine-config should return the list of possible VNC...
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : engine-config should return the list of possible VNC keyboard layouts ...................................................................... tools : engine-config should return the list of possible VNC keyboard layouts Changing the default VNC keyboard layout is possible via engine-config. There should be an indication to what are the possible values. The information on the possible layouts is stored at vdc_options table (VncKeyboardLayoutValidValues option name) Change-Id: I33c37b22501c64cad694e28941bd5df181bbbe6f Bug-Url: https://bugzilla.redhat.com/987952 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33c37b22501c64cad694e28941bd5df181bbbe6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Error when changing email address for user event n...
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Error when changing email address for user event notification ...................................................................... webadmin: Error when changing email address for user event notification When changing user event notification email, the web admin portal complains that the user is already subscribed to the events. This happens because we are executing 2 AsyncCalls from GWT to backend RemoveEventSubscription and AddEventSubscription. If all RemoveEventSubscription calls do not complete before AddEventSubscription action is called the exception is thrown. Change-Id: If30c1e935cad06b293589c80922f56ee377375cb Bug-Url: https://bugzilla.redhat.com/985635 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java 1 file changed, 30 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If30c1e935cad06b293589c80922f56ee377375cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine : Updating host's cluster leads to cloning the host
by yzaslavs＠redhat.com 25 Aug '13

25 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : Updating host's cluster leads to cloning the host ...................................................................... engine : Updating host's cluster leads to cloning the host When trying to move host from one gluster cluster to another, under certain conditions the operation fails with an internal server error and the host appears in both clusters. This happens only when the host in the target or source cluster was up during canDoAction and is down during execution of glusterHostRemove or glusterHostAdd restulting in NPE. Change-Id: I1bda0efedd62bf70ae8670861dc3a2ee70ff77dc Bug-Url: https://bugzilla.redhat.com/988033 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 24 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bda0efedd62bf70ae8670861dc3a2ee70ff77dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0