- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use runVdsCommand method
by amureini＠redhat.com 06 Aug '13

06 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: use runVdsCommand method ...................................................................... core: use runVdsCommand method Use the inherited runVdsCommand method (from CommandBase) for a shorter and more readable code in ConnectStorageToVdsCommand. Change-Id: Ib35bcfca36fa9d51c7de37a209bccd8e8e5303bb Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib35bcfca36fa9d51c7de37a209bccd8e8e5303bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Fixes device type for spicevmc and smartcard devices
by yzaslavs＠redhat.com 06 Aug '13

06 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixes device type for spicevmc and smartcard devices ...................................................................... core: Fixes device type for spicevmc and smartcard devices Adds general device type REDIR. Reverts device type for spicevmc device from CHANNEL back to REDIR. Fixes SMARTCARD device type and name to send when creating new VM. Change-Id: I10776d96f9e43676efd5660ec888022d1786957a Bug-Url: https://bugzilla.redhat.com/984586 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 6 files changed, 27 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10776d96f9e43676efd5660ec888022d1786957a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixes device type for spicevmc and smartcard devices
by yzaslavs＠redhat.com 06 Aug '13

06 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixes device type for spicevmc and smartcard devices ...................................................................... core: Fixes device type for spicevmc and smartcard devices Adds general device type REDIR. Reverts device type for spicevmc device from CHANNEL back to REDIR. Fixes SMARTCARD device type and name to send when creating new VM. Change-Id: Ib68926ef6c7a09dac7a1a98fa13c30e18f1c72e4 Bug-Url: https://bugzilla.redhat.com/984586 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 6 files changed, 26 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib68926ef6c7a09dac7a1a98fa13c30e18f1c72e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: root: branding: integrate properly with apache proxy
by ecohen＠redhat.com 06 Aug '13

06 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: root: branding: integrate properly with apache proxy ...................................................................... root: branding: integrate properly with apache proxy Change-Id: I6b2f6bf069b14b47d8128d2739e965b33888c1c0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M packaging/branding/ovirt.brand/welcome_page.template M packaging/conf/ovirt-engine-proxy.conf.v2.in 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b2f6bf069b14b47d8128d2739e965b33888c1c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: userportal, webadmin: version in welcome page
by ecohen＠redhat.com 06 Aug '13

06 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: version in welcome page ...................................................................... userportal,webadmin: version in welcome page - Fixed issue that caused myVersion to be displayed instead of the actual version. - Removed unused engineVersion.js file. Change-Id: I4a0e28386e00b15e3f222e353965104be50d3938 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp D backend/manager/modules/root/src/main/webapp/engineVersion.js M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 5 files changed, 2 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a0e28386e00b15e3f222e353965104be50d3938 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Take into account command transactivity scope when...
by yzaslavs＠redhat.com 06 Aug '13

06 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Take into account command transactivity scope when... ...................................................................... core: Take into account command transactivity scope when... Take into account command transactivity scope when creating new task duing persistence of place holder. If the command is transactive - create the place holder in a new transaction, so the record will be recognized when there will be association between VDSM task ID and db task ID. This will solve the bug in which removal of template causes some records with empty VDSM task ID to be left after command ends. Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Bug-Url: https://bugzilla.redhat.com/990543 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: pep8 fixup
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: pep8 fixup ...................................................................... packaging: setup: pep8 fixup Change-Id: I7084c4e126c38db76904d8c42bac7ddd566e41a6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7084c4e126c38db76904d8c42bac7ddd566e41a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: Add host rename script
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Add host rename script ...................................................................... packaging: setup: Add host rename script Provide a script that does some of the work involved in changing an engine's hostname. More details in: http://www.ovirt.org/Changing_Engine_Hostname Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/setup/bin/ovirt-engine-rename M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/core/protocols.py A packaging/setup/plugins/ovirt-engine-rename/core/__init__.py A packaging/setup/plugins/ovirt-engine-rename/core/database.py A packaging/setup/plugins/ovirt-engine-rename/core/engine.py A packaging/setup/plugins/ovirt-engine-rename/core/misc.py A packaging/setup/plugins/ovirt-engine-rename/core/pki.py A packaging/setup/plugins/ovirt-engine-rename/core/postinstall.py A packaging/setup/plugins/ovirt-engine-rename/core/protocols.py A packaging/setup/plugins/ovirt-engine-rename/core/tools.py A packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py 14 files changed, 1,408 insertions(+), 80 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add UI for synch mom policy
by gchaplik＠redhat.com 06 Aug '13

06 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add UI for synch mom policy ...................................................................... webadmin: Add UI for synch mom policy Add UI for update/synch Mom policy on host. Action added to sub tab host under main tab cluster. Change-Id: I4cc12a69edd6f92e1aff8d90769a8cb99256c77d Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterHostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java 3 files changed, 96 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cc12a69edd6f92e1aff8d90769a8cb99256c77d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add support for multiple IDs in unlock_entity.sh
by yzaslavs＠redhat.com 06 Aug '13

06 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Add support for multiple IDs in unlock_entity.sh ...................................................................... engine: Add support for multiple IDs in unlock_entity.sh Adds support to enter multiple IDs of same type as parameters of unlock_entity.sh script. This patch make '-i' parameter obsolete and entity IDs has to be entered as last parameter of the script. Example: unlock_entity.sh -t vm 1 2 3 Change-Id: Ic1f9807eef92b9d4cf6f0c020e059ffe549badf2 Bug-Url: https://bugzilla.redhat.com/960448 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/unlock_entity.sh 2 files changed, 12 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f9807eef92b9d4cf6f0c020e059ffe549badf2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0