- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Move dwh-plugins from engine to dwh
by Code Review 20 Mar '17

20 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Move dwh-plugins from engine to dwh ...................................................................... packaging: setup: Move dwh-plugins from engine to dwh Change-Id: Ib6a8680938af26ff2a0db9b05c4aa3cb3ffa06a5 Bug-Url: https://bugzilla.redhat.com/1263785 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M ovirt-engine.spec.in D packaging/setup/ovirt_engine_setup/engine_common/dwh_shared_constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 6 files changed, 1 insertion(+), 459 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6a8680938af26ff2a0db9b05c4aa3cb3ffa06a5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: spec: move to headless java
by Code Review 20 Mar '17

20 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: move to headless java ...................................................................... packaging: spec: move to headless java ovirt-host-deploy doesn't really need full java. Moving from java to java-headless. Change-Id: I12f07ec5eecdca2d13be0baf94b5d5893be9477d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12f07ec5eecdca2d13be0baf94b5d5893be9477d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Added comment about persist_memorystate, with implications, ...
by Code Review 20 Mar '17

20 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Added comment about persist_memorystate, with implications, so that one can change it if desired ...................................................................... Added comment about persist_memorystate, with implications, so that one can change it if desired Change-Id: Ib93f64d2183f04ae1380ffa93e27b1bb140cfef0 Signed-off-by: Gianluca Cecchi <gianluca.cecchi(a)gmail.com> (cherry picked from commit e4ef67041a639cddbae82b172572ac5c45217341) --- M sdk/examples/vm_backup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93f64d2183f04ae1380ffa93e27b1bb140cfef0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Added comment about persist_memorystate, with implications, ...
by Code Review 20 Mar '17

20 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Added comment about persist_memorystate, with implications, so that one can change it if desired ...................................................................... Added comment about persist_memorystate, with implications, so that one can change it if desired Change-Id: Ib93f64d2183f04ae1380ffa93e27b1bb140cfef0 Signed-off-by: Gianluca Cecchi <gianluca.cecchi(a)gmail.com> --- M sdk/examples/vm_backup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Yaniv Kaul: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93f64d2183f04ae1380ffa93e27b1bb140cfef0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Gianluca Cecchi <gianluca.cecchi(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add exclusive locks to AddVmTemplateCommand
by Code Review 19 Mar '17

19 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Add exclusive locks to AddVmTemplateCommand ...................................................................... core: Add exclusive locks to AddVmTemplateCommand Add exclusive locks to exclude possible race conditions while creating a VM template and sealing it: * Lock name of the template (except the case when version of an existing template is being created); * Lock the template; * Lock all disks of the template. The added locks are kept till the end of the command. Change-Id: I55a78a2c416b3d06ebf8f17c32c81690ca436201 Bug-Url: https://bugzilla.redhat.com/1335642 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 59 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a78a2c416b3d06ebf8f17c32c81690ca436201 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ValidateSupportsTransaction doc
by Code Review 19 Mar '17

19 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: ValidateSupportsTransaction doc ...................................................................... core: ValidateSupportsTransaction doc Change-Id: I54fa03e402e4367ee5b2a0f44beb15b62b9a7efc Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidateSupportsTransaction.java 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fa03e402e4367ee5b2a0f44beb15b62b9a7efc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: SnapshotVmConfHelper unneeded DAO getters
by Code Review 19 Mar '17

19 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: SnapshotVmConfHelper unneeded DAO getters ...................................................................... engine: SnapshotVmConfHelper unneeded DAO getters In SnapshotVmConfigurationHelper, since the DAOs and the SnapshotsManager are being injected there is no need of the getters methods. Change-Id: I8206705557acdbc0b85835e412ac6ef8d5d4348b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java 1 file changed, 7 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/74269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8206705557acdbc0b85835e412ac6ef8d5d4348b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine:SnapshotsManager remove unneeded DAO getter
by Code Review 19 Mar '17

19 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine:SnapshotsManager remove unneeded DAO getter ...................................................................... engine:SnapshotsManager remove unneeded DAO getter The DAOs in SnapshotsManager are being injected, therefore there is no need of the getters. Change-Id: I040c93599f6fb3b0ce54fd9f428059f319434310 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 29 insertions(+), 77 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/74268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I040c93599f6fb3b0ce54fd9f428059f319434310 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Support QCOW compat update for disk update
by Code Review 19 Mar '17

19 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Support QCOW compat update for disk update ...................................................................... core: Support QCOW compat update for disk update Updating QCOW compat version for QCOW disk was only supported through the API of disks and storage domains. This patch adds the ability to also update the QCOW compat through the diskattachments API update by adding logic to UpdateVmDiskCommand. Change-Id: I5d038b84089d2775e79c656f6f4647bcbf5d61f2 Bug-Url: https://bugzilla.redhat.com/1429437 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 146 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d038b84089d2775e79c656f6f4647bcbf5d61f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix a regression on import image as template
by Code Review 19 Mar '17

19 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: fix a regression on import image as template ...................................................................... core: fix a regression on import image as template Recent changes in the add-template flow, to support sealing of the template, caused a regression in the flow of importing an image from glance as a template. Previously, the AddVmTemplate command was not async in this flow (as the images already exist in the storage domain). Now, we create a callback anyway which exposes a bug in the detection of whether the VM that the template is based on exists in the database or not. This patch provides a fix for this. Change-Id: I3c61c28be70c1b394b94fac985ce840777035962 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/74276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c61c28be70c1b394b94fac985ce840777035962 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0