- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: LiveMigrateDiskCommand - audit log on failure
by derez＠redhat.com 25 Jul '13

25 Jul '13

Daniel Erez has submitted this change and it was merged. Change subject: core: LiveMigrateDiskCommand - audit log on failure ...................................................................... core: LiveMigrateDiskCommand - audit log on failure Since LiveMigrateDiskCommand is an internal command, canDoAction error messages aren't displayed to the user. Hence, invoke an AuditLog message on canDoAction failure. Change-Id: Ie326395fe9d610f578829c9c5b8847097dfc7b27 Bug-Url: https://bugzilla.redhat.com/968203 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie326395fe9d610f578829c9c5b8847097dfc7b27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Underscores in tag names break tags
by emesika＠redhat.com 25 Jul '13

25 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Underscores in tag names break tags ...................................................................... core: Underscores in tag names break tags Problem were in the usage of the deprecated RefObject objects to pass strings in *AutoCompleter* classes . This was replaced with a native String usage The signature and calls to formatValue had changed to get a Pair<String,String> instead of two Strings encapsulated by a RefObject. Change-Id: I8c0d48aa8ab693149fd1dcc080eddd6d2f9ba4ed Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=949484 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleterTest.java 6 files changed, 82 insertions(+), 93 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c0d48aa8ab693149fd1dcc080eddd6d2f9ba4ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend+ui: search filter not working on Foreman Provider
by oourfali＠redhat.com 24 Jul '13

24 Jul '13

Oved Ourfali has submitted this change and it was merged. Change subject: backend+ui: search filter not working on Foreman Provider ...................................................................... backend+ui: search filter not working on Foreman Provider Added empty constructor to the parameters, setting them using setters, to solve some weird serialization issue with the parameters class. Change-Id: I54110b5bda9a96b0b4a77256f6dbe2e07b1cb80b Bug-Url: https://bugzilla.redhat.com/988012 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostListFromExternalProviderParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54110b5bda9a96b0b4a77256f6dbe2e07b1cb80b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: set ParentToCollectionMap for CdRom
by dfediuck＠redhat.com 24 Jul '13

24 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: set ParentToCollectionMap for CdRom ...................................................................... engine: set ParentToCollectionMap for CdRom The second put with the CdRom.class key was overriding the previous one. Change-Id: I40e83d18016a33178df22f7e3d948d3406566671 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40e83d18016a33178df22f7e3d948d3406566671 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add audit log if snapshot is created without memory
by ofrenkel＠redhat.com 24 Jul '13

24 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add audit log if snapshot is created without memory ...................................................................... core: add audit log if snapshot is created without memory It is possible that the user invokes snapshot with memory creation and the result will be snapshot without memory, if the VM went down after the command started. So this patch adds an audit log in order to present to the user a message that in this case the resulted snapshot doesn't contain memory as requested. Change-Id: Id66a5c8d394e1b961d7869538603adb7e6fbaeca Bug-Url: https://bugzilla.redhat.com/985739 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 15 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id66a5c8d394e1b961d7869538603adb7e6fbaeca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clear memory state if the snapshot is not live
by ofrenkel＠redhat.com 24 Jul '13

24 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: clear memory state if the snapshot is not live ...................................................................... core: clear memory state if the snapshot is not live This patch solves a bug that was caused by not clearing the memory state which is stored a snapshot, when the live part of the create snapshot command is not executed. Change-Id: Ie34a0c7121f5c407648dcee5d6b9d719ede1306b Bug-Url: https://bugzilla.redhat.com/985739 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M packaging/dbscripts/snapshots_sp.sql 4 files changed, 47 insertions(+), 22 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie34a0c7121f5c407648dcee5d6b9d719ede1306b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: small changes & cleanup in console invocation
by tjelinek＠redhat.com 24 Jul '13

24 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: small changes & cleanup in console invocation ...................................................................... frontend: small changes & cleanup in console invocation This patch contains some changes in consoles: 1. It brings to life spice-html5 radio button. 2. It adds a newline character to generated RDP descriptor. 3. Biggest change: modification of 'Console Options' dialog availability condition - now user can open this dialog for VM if it's running. 4. Getting rid of common code in NoVncImpl and SpiceHtml5Impl 5. Waiting until novnc (or spice-html5) window is loaded, then postMessage 6. Internet Explorer version detection for novnc and spice-html5 Change-Id: I7d8b2d781f2bec3102e3efd0e1a6027372e2af46 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/AbstractConsoleButtonCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleEditButtonCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 14 files changed, 236 insertions(+), 241 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/17065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b2d781f2bec3102e3efd0e1a6027372e2af46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: always run autoreconf
by mburns＠redhat.com 24 Jul '13

24 Jul '13

Michael Burns has submitted this change and it was merged. Change subject: always run autoreconf ...................................................................... always run autoreconf Otherwise building from F18 tarball on EL6 will produce incorrect rpms. Change-Id: I358fe24b0fec95a1e79987e581a308c229c50ab5 Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I358fe24b0fec95a1e79987e581a308c229c50ab5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: set vdsm related booleans correctly
by mburns＠redhat.com 24 Jul '13

24 Jul '13

Michael Burns has submitted this change and it was merged. Change subject: set vdsm related booleans correctly ...................................................................... set vdsm related booleans correctly Change-Id: I1e6a2c3e3f6a6ae51d114d301f8865079f0dc4ba Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6a2c3e3f6a6ae51d114d301f8865079f0dc4ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: bump release to 2
by mburns＠redhat.com 24 Jul '13

24 Jul '13

Michael Burns has submitted this change and it was merged. Change subject: bump release to 2 ...................................................................... bump release to 2 Change-Id: I7379b320405c9c0a10a0e0f8b29680af5329113b Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7379b320405c9c0a10a0e0f8b29680af5329113b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0