- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_4.1]: Add installation instructions
by Code Review 13 Mar '17

13 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add installation instructions ...................................................................... Add installation instructions This patch adds installation instructions to the README.adoc file of the SDK, including information about the dependencies required to install with `pip`. Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit dfb14e444ff9fc0cd40d4dd9f9861cc50c4de1bf) --- M sdk/README.adoc 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add installation instructions
by Code Review 13 Mar '17

13 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add installation instructions ...................................................................... Add installation instructions This patch adds installation instructions to the README.adoc file of the SDK, including information about the dependencies required to install with `pip`. Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Nathanaël Blanchet <digitall.finger(a)gmail.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add clone VM from snapshot example
by Code Review 13 Mar '17

13 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add clone VM from snapshot example ...................................................................... Add clone VM from snapshot example This patch adds an example that shows how to create a new virtual machine cloning it from an snapshot. Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9a9ccbf8e18ea78f9d81cccb9503774fc129dcec) --- A sdk/examples/clone_vm_from_snapshot.rb 1 file changed, 76 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Autoadjusting max memory when VM created
by Code Review 13 Mar '17

13 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Autoadjusting max memory when VM created ...................................................................... restapi: Autoadjusting max memory when VM created Problem: Since engine 4.1 VM-like entities have new property - max memory. If one tried to create a new VM using script created for engine 4.0 specifying custom memory size larger template max memory and didn't specifying max memory explicitly then creation of VM failed. Max memory copied from template was smaller than memory. Solution: If max memory is not specified and memory is specified, then max memory is automatically set to value VmCommonUtils#getMaxMemorySizeDefault(int memory) (currently 4*memory). UI uses same method. Change-Id: I6e1d0847c68a774f6028824e4533df772c19dfea Bug-Url: https://bugzilla.redhat.com/1430795 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1d0847c68a774f6028824e4533df772c19dfea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add clone VM from snapshot example
by Code Review 13 Mar '17

13 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add clone VM from snapshot example ...................................................................... Add clone VM from snapshot example This patch adds an example that shows how to create a new virtual machine cloning it from an snapshot. Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/clone_vm_from_snapshot.rb 1 file changed, 76 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add console ticket example
by Code Review 13 Mar '17

13 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add console ticket example ...................................................................... Add console ticket example This patch adds an example that shows how to find a graphics console for a given access protocol (VNC or SPICE) and how to get a ticket. Change-Id: Iff02457a7b9026c0c3d3532d8e131ec1e110d69b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/get_display_ticket.rb 1 file changed, 68 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff02457a7b9026c0c3d3532d8e131ec1e110d69b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel ...................................................................... webadmin: Pass Discard is irrelevant for AttachDiskModel AttachDiskModel is a sub class of AbstractDiskModel, and thus when events like storageDomain_SelectedItemChanged are raised in AttachDiskModel, updatePassDiscardAvailability and updatePassDiscardChangeability are called although Pass Discard is irrelevant for AttachDiskModel. This patch adds an empty override of these methods to AttachDiskModel to solve this problem. Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Bug-Url: https://bugzilla.redhat.com/1430754 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel ...................................................................... webadmin: Pass Discard is irrelevant for AttachDiskModel AttachDiskModel is a sub class of AbstractDiskModel, and thus when events like storageDomain_SelectedItemChanged are raised in AttachDiskModel, updatePassDiscardAvailability and updatePassDiscardChangeability are called although Pass Discard is irrelevant for AttachDiskModel. This patch adds an empty override of these methods to AttachDiskModel to solve this problem. Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Bug-Url: https://bugzilla.redhat.com/1430754 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review 12 Mar '17

12 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel ...................................................................... webadmin: Pass Discard is irrelevant for AttachDiskModel AttachDiskModel is a sub class of AbstractDiskModel, and thus when events like storageDomain_SelectedItemChanged are raised in AttachDiskModel, updatePassDiscardAvailability and updatePassDiscardChangeability are called although Pass Discard is irrelevant for AttachDiskModel. This patch adds an empty override of these methods to AttachDiskModel to solve this problem. Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Bug-Url: https://bugzilla.redhat.com/1430754 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/73924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: eliminate redundant query on clone vm
by Code Review 12 Mar '17

12 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: eliminate redundant query on clone vm ...................................................................... core: eliminate redundant query on clone vm This is a minor cleanup for some not-that-nice code that got in as part of Ic8fbae and introduced a redundant query from the DB. Change-Id: If2cc716606b89a22ead7babc10b887f71f7b1c9a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/73913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2cc716606b89a22ead7babc10b887f71f7b1c9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0