- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improving GetAsyncTasksByStoragePoolId query
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving GetAsyncTasksByStoragePoolId query ...................................................................... engine: Improving GetAsyncTasksByStoragePoolId query The following patch will simplify a query, we don't need to make any join, access to async_tasks table is enough Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: provide activation.jar
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: provide activation.jar ...................................................................... packaging: provide activation.jar activation.jar is required by hibernate-validator, which causes maven to bring it as a transient dependency, even though it is part of the JDK. Explicitly adding it to the root pom.xml and marking it as provided (in a similar fashion to javax.transaction) makes sure it is not brought twice. Change-Id: If6bbed19bee01bcd76b15e709f50810b88aaa973 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bbed19bee01bcd76b15e709f50810b88aaa973 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix NPE when trying to export not existing template
by ofrenkel＠redhat.com 07 Apr '13

07 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: fix NPE when trying to export not existing template ...................................................................... engine: fix NPE when trying to export not existing template The fix is all about checking whether the template exists before trying to get its storage pool id. This patch contains two other changes: 1. the description of the command moved from #canDoAction to the constructor which is a more appropriate place to initialize things. 2. add a check that the template exists as the first thing that is checked in #canDoAction(). this check is already made at MoveOrCopyTemplateCommand#canDoAction but it is taking place too late - we should address this issue but in a different patch in order to keep this one simple fix. Change-Id: I757672ec2f989f4dc1bc5403878c5cbee69f9cf0 Bug-Url: https://bugzilla.redhat.com/928365 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I757672ec2f989f4dc1bc5403878c5cbee69f9cf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: searchbackend - sort VMs by host name
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: searchbackend - sort VMs by host name ...................................................................... core: searchbackend - sort VMs by host name Adding support for sorting VMs by host name (using search - 'Vms: sortby host'. Change-Id: If556479a2a00868f803ef4639eef9dc9453592ff Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If556479a2a00868f803ef4639eef9dc9453592ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: make storage type field non editable
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: make storage type field non editable ...................................................................... webadmin: make storage type field non editable In edit dialog of storage domain make the "Domain Function / Storage Type" field not editable. It remains editable when adding a new storage domain. Change-Id: I7c6c3db97ca8a2d07ec7ec50b0765828b902e5a8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6c3db97ca8a2d07ec7ec50b0765828b902e5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddVmFromSnapshot - avoid early end method run
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmFromSnapshot - avoid early end method run ...................................................................... core: AddVmFromSnapshot - avoid early end method run When adding vm as a clone of snapshot, the vm id should be set as the entity id for the child commands parameters - this prevent a situation in which the end method is called too early. NOTE: seems like the MoveOrCopyImageGroupParameters class might be re-factored so that in a case of given ContainerId, it will be set as the entity id - but that's not in the scope of this change. Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Events tab - Details dialog
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Events tab - Details dialog ...................................................................... webadmin: Events tab - Details dialog Events tab: * Created a new dialog for showing event's details (ID, Time, Message). Event message is displayed in a text-area for easy copy-paste. * Added context menu 'Details' button (invoked on double-click) Change-Id: If9bccd2e8a692dd7f9745ed240de3ebd1b7ff376 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/EventModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/event/EventPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/event/EventPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/event/EventPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 13 files changed, 294 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9bccd2e8a692dd7f9745ed240de3ebd1b7ff376 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: i18n refresh 'sec'
by derez＠redhat.com 05 Apr '13

05 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal, webadmin: i18n refresh 'sec' ...................................................................... userportal, webadmin: i18n refresh 'sec' - Fixed 'sec' not being i18ned on the refresh panel drop down. - Renamed MilisecondRenderer to MillisecondRenderer Change-Id: I0eadb1085e6b59239d1091d894de52ca3fc3e88a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871354 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/MilisecondRenderer.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/MillisecondRenderer.java 4 files changed, 43 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eadb1085e6b59239d1091d894de52ca3fc3e88a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: provided cleared frontend logging
by ecohen＠redhat.com 05 Apr '13

05 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: core: provided cleared frontend logging ...................................................................... core: provided cleared frontend logging - Added code to display better debug messages for -- RunQuery -- RunPublicQuery -- RunMultipleQueries -- RunAction -- RunMultipleActions Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903312 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 5 files changed, 80 insertions(+), 3 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move scheduler to modules
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Move scheduler to modules ...................................................................... core: Move scheduler to modules The scheduler component used to be into a "beans" folder, but it is not different from other components, like "dal" or "bll", so it makes more sense to have it in the same folder. Change-Id: I291a87742ddb2d536bd0d11f54515ac531b69659 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/beans/pom.xml M backend/manager/modules/pom.xml R backend/manager/modules/scheduler/pom.xml R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/OnTimerMethodAnnotation.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java R backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 9 files changed, 2 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I291a87742ddb2d536bd0d11f54515ac531b69659 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0