- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Read correctly attributes with enum values
by Code Review 03 Mar '17

03 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Read correctly attributes with enum values ...................................................................... Read correctly attributes with enum values A recent patch introduced a mechanism to ignore incorrect values of enum types. That patch also introduced a regresion for attributes of enum types that have a name different to their type name. For example, the 'vm.migration.auto_converge' attribute is of type 'InheritableBoolean', not of type 'AutoConverge' as assumed by the code generator. This patch fixes that issue. Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd Bug-Url: https://bugzilla.redhat.com/1428642 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2d67acfe71e6beb7641be052b62427b543923e97) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/vm_reader_spec.rb 3 files changed, 63 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Don't avoid reserved words in enum values text
by Code Review 03 Mar '17

03 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Don't avoid reserved words in enum values text ...................................................................... Don't avoid reserved words in enum values text The SDK appends an underscore to generated names that conflict with Ruby reserved words. But it also does so for the text of enum values. This is wrong, in particular it is wrong for the 'InheritableBoolean' enum which has the following values currently: FALSE = 'false_'.freeze TRUE = 'true_'.freeze ... The 'false_' and 'true_' values are incorrect, as that isn't what the server generates or expects, they should be 'false' and 'true', without the underscore. This patch fixes that issue. Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4d3cb860592548e2805f530f8e9cb8343284ab4c) --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java A sdk/spec/inheritable_boolean_spec.rb 2 files changed, 31 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Read correctly attributes with enum values
by Code Review 03 Mar '17

03 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Read correctly attributes with enum values ...................................................................... Read correctly attributes with enum values A recent patch introduced a mechanism to ignore incorrect values of enum types. That patch also introduced a regresion for attributes of enum types that have a name different to their type name. For example, the 'vm.migration.auto_converge' attribute is of type 'InheritableBoolean', not of type 'AutoConverge' as assumed by the code generator. This patch fixes that issue. Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd Bug-Url: https://bugzilla.redhat.com/1428642 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/vm_reader_spec.rb 3 files changed, 63 insertions(+), 16 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e67fd4ecf6e38b9e23c6b6cd929db1836adafd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Don't avoid reserved words in enum values text
by Code Review 03 Mar '17

03 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Don't avoid reserved words in enum values text ...................................................................... Don't avoid reserved words in enum values text The SDK appends an underscore to generated names that conflict with Ruby reserved words. But it also does so for the text of enum values. This is wrong, in particular it is wrong for the 'InheritableBoolean' enum which has the following values currently: FALSE = 'false_'.freeze TRUE = 'true_'.freeze ... The 'false_' and 'true_' values are incorrect, as that isn't what the server generates or expects, they should be 'false' and 'true', without the underscore. This patch fixes that issue. Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java A sdk/spec/inheritable_boolean_spec.rb 2 files changed, 31 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: kickstart: use 7 instead of $releasever
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: kickstart: use 7 instead of $releasever ...................................................................... kickstart: use 7 instead of $releasever for some reason relasever is now 7.3 and causes repository error. Change-Id: Ic35e56aa9a62f215593027e10dbd853441b4f520 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35e56aa9a62f215593027e10dbd853441b4f520 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: oVirt Live 4.1.1 rc1
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 4.1.1 rc1 ...................................................................... build: oVirt Live 4.1.1 rc1 Use SIGs release repositories with signed packages. Change-Id: I81cb85697e0d5ab27f8b74427da5a14f03bdd536 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81cb85697e0d5ab27f8b74427da5a14f03bdd536 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: centos7: Fix collectd package conflict issue
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: centos7: Fix collectd package conflict issue ...................................................................... centos7: Fix collectd package conflict issue Change-Id: I14011ef26c189d404a533385b2d66540ca7f736d Signed-off-by: Lev Veyde <lveyde(a)redhat.com> (cherry picked from commit b363892c1e048081881a8f44cd4045d791900ba0) --- M centos-7/kickstart/centos-7-livecd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14011ef26c189d404a533385b2d66540ca7f736d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: build: ovirt-release41-4.1.1_rc1
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release41-4.1.1_rc1 ...................................................................... build: ovirt-release41-4.1.1_rc1 - First 4.1.1 release candidate - Move to SIGs released repos Change-Id: Ia0f4498ad44cfab68c5d7490190707f879d8b7cb --- M configure.ac M ovirt-el7-ppc64le-deps.repo.in M ovirt-el7-x86_64-deps.repo.in M ovirt-release41.spec.in 4 files changed, 22 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/73499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f4498ad44cfab68c5d7490190707f879d8b7cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-js-dependencies: drop fc24 on master
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-js-dependencies: drop fc24 on master ...................................................................... ovirt-js-dependencies: drop fc24 on master Also removed 4.0 from excludes section -- there are no 4.0 jobs configured. Change-Id: I23be3a5aa5697c7d50f43cf0d13ebcdc54b94c6b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M jobs/confs/projects/ovirt-js-dependencies/ovirt-js-dependencies_standard.yaml 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23be3a5aa5697c7d50f43cf0d13ebcdc54b94c6b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-dashboard: drop fc24 on master
by Code Review 03 Mar '17

03 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-dashboard: drop fc24 on master ...................................................................... ovirt-engine-dashboard: drop fc24 on master Change-Id: Ic5a0ce2a23a1b85434b9ba7bc6b35b75d59ff61d Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_standard.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5a0ce2a23a1b85434b9ba7bc6b35b75d59ff61d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0