- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Introducing UpdateVolumeCommand
by Code Review 01 Mar '17

01 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Introducing UpdateVolumeCommand ...................................................................... core: Introducing UpdateVolumeCommand Added UpdateVolumeCommand that allows to change volume metadata. The supported metadata that can be changed: - description of the volume - volume type (allows to make a leaf volume shared) - legality (legal/illegal) - generation Added UpdateAllTemplateDisksCommand that runs UpdateVolumeCommand on all disks of a template. This command is designed to be called from AddVmTemplateCommand and it works only on non-shared volumes of a template. Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateAllTemplateDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UpdateVolumeCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateAllTemplateDisksParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVolumeCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 287 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Make BaseDisk implement Nameable
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Make BaseDisk implement Nameable ...................................................................... core: Make BaseDisk implement Nameable BaseDisk entity and all it's subclasses are now nameable to allow running actions that require naming on them, the name will refer to the disk alias Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Related-To: https://bugzilla.redhat.com/1317490 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Sort disk order in Libvirt XML by the alias lexonumeri...
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Sort disk order in Libvirt XML by the alias lexonumerically ...................................................................... core: Sort disk order in Libvirt XML by the alias lexonumerically The disk order sent in the Libvirt XML should be ordered lexonumerically to avoid situations where "Disk10" will come before "Disk2" Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433 Bug-Url: https://bugzilla.redhat.com/1317490 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Make BaseDisk implement Nameable
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Make BaseDisk implement Nameable ...................................................................... core: Make BaseDisk implement Nameable BaseDisk entity and all it's subclasses are now nameable to allow running actions that require naming on them, the name will refer to the disk alias Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Related-To: https://bugzilla.redhat.com/1317490 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Sort disk order in Libvirt XML by the alias lexonumeri...
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Sort disk order in Libvirt XML by the alias lexonumerically ...................................................................... core: Sort disk order in Libvirt XML by the alias lexonumerically The disk order sent in the Libvirt XML should be ordered lexonumerically to avoid situations where "Disk10" will come before "Disk2" Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433 Bug-Url: https://bugzilla.redhat.com/1317490 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9522b4e893d42e0a44aa26557ff1d19a5ff10433 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make BaseDisk implement Nameable
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Make BaseDisk implement Nameable ...................................................................... core: Make BaseDisk implement Nameable BaseDisk entity and all it's subclasses are now nameable to allow running actions that require naming on them, the name will refer to the disk alias Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Related-To: https://bugzilla.redhat.com/1317490 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57e208e6763a06fc11669a7fb8a49b3f7b349386 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Enable overflow setting in DisksAllocationView ...................................................................... webadmin: Enable overflow setting in DisksAllocationView Enable setting the overflow in the disks table inside DisksAllocationView and set it to auto in DisksAllocationPopupView which is used for move VM disks dialog, this will avoid the disks list running over the dialog buttons in case we are moving more than 8 disks Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Bug-Url: https://bugzilla.redhat.com/1419352 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Enable overflow setting in DisksAllocationView ...................................................................... webadmin: Enable overflow setting in DisksAllocationView Enable setting the overflow in the disks table inside DisksAllocationView and set it to auto in DisksAllocationPopupView which is used for move VM disks dialog, this will avoid the disks list running over the dialog buttons in case we are moving more than 8 disks Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Bug-Url: https://bugzilla.redhat.com/1419352 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/73373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Enable overflow setting in DisksAllocationView
by Code Review 01 Mar '17

01 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Enable overflow setting in DisksAllocationView ...................................................................... webadmin: Enable overflow setting in DisksAllocationView Enable setting the overflow in the disks table inside DisksAllocationView and set it to auto in DisksAllocationPopupView which is used for move VM disks dialog, this will avoid the disks list running over the dialog buttons in case we are moving more than 8 disks Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Bug-Url: https://bugzilla.redhat.com/1419352 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5425ab4b156972a5db345f0754ef4758b9eaeb0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add ovirt-engine-metrics jobs/conf
by Code Review 01 Mar '17

01 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Add ovirt-engine-metrics jobs/conf ...................................................................... Add ovirt-engine-metrics jobs/conf Change-Id: Idf0775e38b6cffb71220b11a074677786213dfa7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A jobs/confs/projects/ovirt-engine-metrics/ovirt-engine-metrics_build-artifacts.yaml A jobs/confs/yaml/scms/ovirt-engine-metrics.yaml 2 files changed, 62 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0775e38b6cffb71220b11a074677786213dfa7 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0