- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: utils: tests: tar: cleanup main() entry point
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tests: tar: cleanup main() entry point ...................................................................... utils: tests: tar: cleanup main() entry point People found that this unused testing only code needs to not leak. Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: don't add ssh command to exception
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: don't add ssh command to exception ...................................................................... utils: ssh: don't add ssh command to exception It results in a long unclear message to the user. Change-Id: If4e221b423a46dcaf01ca540a4671caeedb90dce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e221b423a46dcaf01ca540a4671caeedb90dce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: host add: differentiate between authentication error and other errors ...................................................................... bootstrap: host add: differentiate between authentication error and other errors New SSHClient implementation allows differentiating between these cases as requested. Change-Id: I0d87fdd0c8942ec39632bd4562694bd5d027cbd7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 22 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d87fdd0c8942ec39632bd4562694bd5d027cbd7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: handle bootstrap messages using string member
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: handle bootstrap messages using string member ...................................................................... bootstrap: handle bootstrap messages using string member Current implementation holds the VdsInstaller object in context of InstallVdsCommand only to extract the error message out of it. VdsInstaller is going to be retired so we move the reference to local scope and store the error message in string at state scope. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I928db05fa3ca7cd5941f30af8036d598847ea7d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 2 files changed, 15 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I928db05fa3ca7cd5941f30af8036d598847ea7d2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: allow distinguish error from non error messages
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: allow distinguish error from non error messages ...................................................................... bootstrap: allow distinguish error from non error messages The old bootstrap xml like protocol will remain for a while until the node upgrade script rewritten. Till then we need to know if there was an error message to fail the command without relaying on constants within messages as VdsInstaller had done so far. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: split the logic of ovirt-node upgrade out ...................................................................... bootstrap: split the logic of ovirt-node upgrade out Currently we have 4 separate bootstrap methods: 1. Host. 2. Node registration. 3. Node installation. 4. Node upgrade. While there is something common between (1-3), node upgrade is totally different sequence: 1. Unlike bootstrap it is executing foreign code (not originated at engine machine. 2. Unlike bootstrap it is non-customizable. This change split the logic of the node upgrade out, to ease future VdsInstaller retirement. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 1 file changed, 48 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: cleanup: rename server with host
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: cleanup: rename server with host ...................................................................... utils: ssh: cleanup: rename server with host 'Host' is more compatible with the other API. Change-Id: I4b342fa033713608baa977c8e0592be2f5c35927 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java 4 files changed, 15 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b342fa033713608baa977c8e0592be2f5c35927 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Event log - a method to bypass flow
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Event log - a method to bypass flow ...................................................................... core: Event log - a method to bypass flow Event log - a method to bypass flood filtering Adding a customId field to AuditLogableBase in order to enable distinguishing between events that have same instance references (dc, cluster, vm etc) but still should be treated as separate events such that the anti-flood event mechanism will not mask those events and display just one per the defined period. It is the responsibility of the AuditLogableBase instance creator to call setCustomId with a different id per log message instance in order to treat those messages as different messages. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875375 Change-Id: Iff160c4241618a2d0c475e13ea13ddefe8220f06 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff160c4241618a2d0c475e13ea13ddefe8220f06 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: packaging: Updated allinone plugin for new security mode
by juan.hernandez＠redhat.com 19 Nov '12

19 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated allinone plugin for new security mode ...................................................................... packaging: Updated allinone plugin for new security mode Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Signed-off-by: Alex Lourie <alourie(a)redhat.com> (cherry picked from commit c833bba55a19b2e2383d532b87c363a7895a8927) --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Moran Goldboim: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: ofer.schre(a)gmail.com

1 0

Change in ovirt-engine[master]: webadmin: Setup Network- default boot protocol wasn't none.
by alkaplan＠redhat.com 19 Nov '12

19 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setup Network- default boot protocol wasn't none. ...................................................................... webadmin: Setup Network- default boot protocol wasn't none. When doing the following- 1. Opening the Setup Network Dialog. 1. Dragging "unattached", "non vlan" Network on a Nic. 2. Detaching the Network. 3. Attaching another "unattached", "non vlan" Network to the Nic. Result- The default boot protocol of the network is empty- there is no selected radio button. Bug-Url:https://bugzilla.redhat.com/875724 Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 31 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0