- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: webadmin: Network main tab is not visible in some tree selections. ...................................................................... webadmin: Network main tab is not visible in some tree selections. Network Main Tab should be visible also when selecting in the tree- - Data Center - Cluster - Host Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Alona Kaplan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Network Search for Host Name
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Host Name ...................................................................... engine: Add Network Search for Host Name This patch adds the network_vds_view, to be used by the tree search for Networks by Host name. It also joins the network table with this new view. Change-Id: I4567828abdba27f50f40e75a7989da965f475417 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkCrossRefAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkHostConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml 6 files changed, 59 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4567828abdba27f50f40e75a7989da965f475417 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Vds Port Validation 65535 (#871328)
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Vds Port Validation 65535 (#871328) ...................................................................... engine: Add Vds Port Validation 65535 (#871328) This patch changes the maximum port number to 65535 using a validation in VdsStatic. Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Bug-Url: https://bugzilla.redhat.com/871328 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties 17 files changed, 25 insertions(+), 25 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Network Search for Cluster Name
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Cluster Name ...................................................................... engine: Add Network Search for Cluster Name This patch adds the cluster name column to network_cluster_view. It also joins the network and network_cluster tables. Change-Id: I77bc293ac47b7cc94a1d4355da2fec11649c4b47 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkClusterConditionFieldAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkCrossRefAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 4 files changed, 25 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77bc293ac47b7cc94a1d4355da2fec11649c4b47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improve of IrsBrokerCommand
by mkublin＠redhat.com 15 Nov '12

15 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Improve of IrsBrokerCommand ...................................................................... core: Improve of IrsBrokerCommand The following patch is removing getIsValidWithoutSpmStart() method and performs some clean up. The method is removed because of it can trigger spm election, also were unify additional places for nullify of all internal proxies of IrsBrokerCommand Change-Id: I822acd7afdc128195637efbd467548877488c1f5 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 10 insertions(+), 18 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I822acd7afdc128195637efbd467548877488c1f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Aligning buttons in AddBricks dialog
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Aligning buttons in AddBricks dialog ...................................................................... webadmin: Aligning buttons in AddBricks dialog Add button is moved down and placed along side brick directory. Clear button is removed as there is only one field which needs to be cleared. Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml 3 files changed, 3 insertions(+), 35 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix System Tree rendering in GlusterOnly mode
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix System Tree rendering in GlusterOnly mode ...................................................................... webadmin: Fix System Tree rendering in GlusterOnly mode System Tree was not visible while running oVirt in GlusterOnly mode. Modified the code to call Execute() method of outer class instead self(leads to recursive execution). Change-Id: I6ef526960ad67038168f9cc9830cfe6df23ea6bc Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef526960ad67038168f9cc9830cfe6df23ea6bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide Networks tab in GlusterOnly mode
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Hide Networks tab in GlusterOnly mode ...................................................................... webadmin: Hide Networks tab in GlusterOnly mode Networks main tab will not be shown while running oVirt in GlusterOnly mode. Change-Id: I6fc54746365c4b0c94a8c82b6cc0fe3ba697e3c5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc54746365c4b0c94a8c82b6cc0fe3ba697e3c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix Volume virt option configuration version
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix Volume virt option configuration version ...................................................................... webadmin: Fix Volume virt option configuration version Passing 'general' as the version while retrieving the Virt related volume options from configuration. Change-Id: I03679ae1237607ea6273e1d55f31ffbc02893b21 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03679ae1237607ea6273e1d55f31ffbc02893b21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "Revert "core: errors during preview of diskless snap...
by yzaslavs＠redhat.com 14 Nov '12

14 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "Revert "core: errors during preview of diskless snapshots"" ...................................................................... Revert "Revert "core: errors during preview of diskless snapshots"" This reverts commit a5b2196fdf9299ac774588aaaa68415e51ee509b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 16 insertions(+), 12 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c9fd926e61e860f4af9ff460c6657cf81b1fc85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0