- Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: fixed localized charts text appear as squares (#870...
by ydary＠redhat.com 01 Nov '12

01 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed localized charts text appear as squares (#870736) ...................................................................... reports: fixed localized charts text appear as squares (#870736) This was due to font used that did not support non western characters. We replaced it to SansSerif font family that default to the old font, but also allow replacement in case of missing font. bug-url: https://bugzilla.redhat.com/870736 Change-Id: I31b47023ff395909466223bef0cfbfb096014bb6 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/full details.jrxml.data M reports/repository_files/resources/Reports/Executive/cluster_capacity_vs_usage_br19_files/cluster_capacity_vs_usage_br19_jrxml.data M reports/repository_files/resources/Reports/Executive/cluster_capacity_vs_usage_br19_files/full details br19.jrxml.data M reports/repository_files/resources/Reports/Executive/host_os_break_down_BR22_files/full details.jrxml.data M reports/repository_files/resources/Reports/Executive/host_os_break_down_BR22_files/host_os_break_down_BR22_jrxml.data M reports/repository_files/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/full details.jrxml.data M reports/repository_files/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/Storage_Domain_Report_BR21_jrxml.data M reports/repository_files/resources/Reports/Inventory/Storage_Domain_Report_BR21_files/full details br21.jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/full details.jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full details br13.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/cluster_uptime_br7_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/br8 full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/single_host_uptime_br8_files/single_host_uptime_br8_jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/report5.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/cluster_quality_of_service_vms_br13_jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/header cluster name.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14 full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14_table.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/virtual_servers_uptime_br14_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/br3 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/br2 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/br2 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/br2 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/five_least_utilized_vms_Over_Time_BR12_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/multiple_vms_resource_usage_over_time_br16_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/report3.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/br2 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_days_week_BR10B_files/single_vm_resources_days_week_BR10B_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/br10 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_hour_of_day_BR10c_files/single_vm_resources_hour_of_day_BR10c_jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/br10 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/Host_OS_Break_Down_BR22B_for_inventory_files/Host_OS_Break_Down_BR22B_for_inventory_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/storage_domain_by_Datacenter_BR23_files/storage_domain_by_Datacenter_BR23_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/datacenter_quality_of_service_hosts_br6b_files/datacenter_quality_of_service_hosts_br6b_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/System_Overview_Dashboard/summary_of_host_usage_resources_br17_files/summary_of_host_usage_resources_br17_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/Five_most_utilized_hosts_over_time_files/Five_most_utilized_hosts_over_time_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Trends_Dashboard/five_most_utilized_vms_over_time_br11_files/five_most_utilized_vms_over_time_br11_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/cluster_uptime_by_datacenter_br7a_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/cluster_uptime_by_datacenter_br7a_files/report5.jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/report5.jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/Uptime_Dashboard/virtual_servers_uptime_by_cluster_br14a_files/virtual_servers_uptime_by_cluster_br14a_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_entities_counts_list_dr3_files/cluster_entities_counts_list_dr3_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_ha_vm_uptime_status_dr13_files/cluster_ha_vm_uptime_status_dr13_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_resources_status_dr12_files/cluster_host_resources_status_dr12_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_uptime_status_dr6_files/cluster_host_uptime_status_dr6_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_top_five_busiest_hosts_dr23_files/cluster_top_five_busiest_hosts_dr23_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_vm_over_commit_status_dr14_files/cluster_vm_over_commit_status_dr14_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/cluster_capacity_vs_usage_cores_dr29_files/cluster_capacity_vs_usage_cores_dr29_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/cluster_capacity_vs_usage_mem_dr30_files/cluster_capacity_vs_usage_mem_dr30_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/cluster_top_five_least_busy_hosts_dr24_files/cluster_top_five_least_busy_hosts_dr24_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_ha_virtual_servers_uptime_dr19_files/top_five_ha_virtual_servers_uptime_dr19_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_hosts_uptime_dr17_files/top_five_hosts_uptime_dr17_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_hosts_downtime_dr18_files/top_five_hosts_downtime_dr18_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/datacenter_top_five_busiest_clusters_dr21_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_entities_counts_list_dr2_files/dc_entities_counts_list_dr2_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_resources_status_dr11_files/dc_host_resources_status_dr11_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_uptime_status_dr5_files/dc_host_uptime_status_dr5_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_storage_space_status_dr8_files/dc_storage_space_status_dr8_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_top_five_used_storage_domain_dr26_files/dc_top_five_used_storage_domain_dr26_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/dc_vm_over_commit_dr25_files/dc_vm_over_commit_dr25_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/top_five_clusters_host_uptime_dr15_files/top_five_clusters_host_uptime_dr15_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/top_five_clusters_host_downtime_dr16_files/top_five_clusters_host_downtime_dr16_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_entities_counts_list_dr1_files/system_entities_counts_list_dr1_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_resources_status_dr10_files/system_host_resources_status_dr10_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_uptime_status_dr4_files/system_host_uptime_status_dr4_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_storage_space_status_dr7_files/system_storage_space_status_dr7_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_entities_counts_list_dr3_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_ha_vm_uptime_status_dr13_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_host_resources_status_dr12_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_host_uptime_status_dr6_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_top_five_busiest_hosts_dr23_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_vm_over_commit_status_dr14_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_hosts_downtime_dr18_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_entities_counts_list_dr2_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_host_resources_status_dr11_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_host_uptime_status_dr5_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_storage_space_status_dr8_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_top_five_used_storage_domain_dr26_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/top_five_clusters_host_downtime_dr16_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_entities_counts_list_dr1_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_host_resources_status_dr10_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_host_uptime_status_dr4_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_storage_space_status_dr7_jrxml.data 115 files changed, 1,102 insertions(+), 1,102 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31b47023ff395909466223bef0cfbfb096014bb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Integer should be compare with ==
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Integer should be compare with == ...................................................................... webadmin: Integer should be compare with == Integer should be compate with equals and not == Change-Id: I6931034b5dbeb2fcb6b1791e5f3e6c37a86ba640 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6931034b5dbeb2fcb6b1791e5f3e6c37a86ba640 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: better log when LUN in problem state
by mlipchuk＠redhat.com 31 Oct '12

31 Oct '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: better log when LUN in problem state ...................................................................... core: better log when LUN in problem state Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8 Bug-Url: https://bugzilla.redhat.com/854214 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout - Custom Properties select-box not fit for ...
by shavivi＠redhat.com 31 Oct '12

31 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Layout - Custom Properties select-box not fit for JP Locale ...................................................................... webadmin: Layout - Custom Properties select-box not fit for JP Locale Change-Id: I320efe16f71a3b2d2e577b5ff7692f1afa495730 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=870253 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I320efe16f71a3b2d2e577b5ff7692f1afa495730 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix LoadBalancing messeges
by dfediuck＠redhat.com 31 Oct '12

31 Oct '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix LoadBalancing messeges ...................................................................... core: Fix LoadBalancing messeges When VM migration was triggered by a Load Balancing algorithm only the "migration finished" message appeared and not the "migration started" message. VdsLoadBalancingAlgorithm was calling setShouldBeLogged(false). Line was removed. Change-Id: I90707ee0f97544f128592c408fcce2a2aae65ff7 Bug-Url: https://bugzilla.redhat.com/744813 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancingAlgorithm.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90707ee0f97544f128592c408fcce2a2aae65ff7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 6) ...................................................................... webadmin: Network as Main Tab- (Phase 6) - Cluster sub tab uses new query - GetVdsGroupsAndNetworksByNetworkIdQuery - Host sub tab- using new queries. Adding columns. Setup Networks action. - Update networks/networks tree icons. - Vm sub tab- using new queries. - Template sub tab- using new queries. Change-Id: Ibe5a15afaf4a3c5edb9fce432c8b490e7a15eb76 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SaveNetworkConfigAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostFilter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkClusterPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkHostPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkTemplatePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkVmPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceStatusImage.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkClusterStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_tree_network.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_tree_networks.png 30 files changed, 744 insertions(+), 282 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe5a15afaf4a3c5edb9fce432c8b490e7a15eb76 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 5)
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 5) ...................................................................... webadmin: Network as Main Tab- (Phase 5) - Main tab - Role- adding custom tooltip. - Cluster sub tab- adding columns and assign/unassign action (using the same models and views and assign/unassign in Cluster->Logical Network) Change-Id: I094f20c080b155da728019098376f4b8f75af1e8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterManageNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkClusterPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CheckboxColumn.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkClusterStatusColumn.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkRoleColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkStatusColumn.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/empty.png 27 files changed, 685 insertions(+), 358 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I094f20c080b155da728019098376f4b8f75af1e8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 4)
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 4) ...................................................................... webadmin: Network as Main Tab- (Phase 4) - Update the search syntax in CommonModel. - Change the main tab search to use NetworkView. - Update the columns of the main tab. - Update the General sub tab. - Update the main tab remove action. - Get ENGINE_NETWROK name synchronously. - Change the tabs order- network tab between Host and Storage tab. - Main tab search order- primary dc_name secondary- network name. Change-Id: I644e9c8f0c5b2d332e1cbccf30545fe152754fee Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/GuidLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/GuidRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabNetworkPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabPoolPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabQuotaPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabStoragePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabTemplatePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVirtualMachinePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVolumePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkClusterPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkHostPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkPermissionPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkTemplatePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkVmPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkPermissionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/NullableNumberRenderer.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkRoleColumn.java 41 files changed, 337 insertions(+), 189 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I644e9c8f0c5b2d332e1cbccf30545fe152754fee Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 3)
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 3) ...................................................................... webadmin: Network as Main Tab- (Phase 3) Add to Network->Host subtab radio button that will show either- 1.All the hosts that this network is attached to. 2.All the hosts where this network attached to the cluster but not to the host. Change-Id: I538a4269315d4c3e005d6e4c0847d9d96d0f469e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ViewRadioGroup.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ViewFilter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostFilter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 10 files changed, 473 insertions(+), 43 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I538a4269315d4c3e005d6e4c0847d9d96d0f469e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 2)
by alkaplan＠redhat.com 31 Oct '12

31 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 2) ...................................................................... webadmin: Network as Main Tab- (Phase 2) Add, edit, remove network commandd for dc, cluster and network tab have very common code. This patch moves the common code to one place- NetworkModel, RemoveNetworkModel. Change-Id: I7a43ad89af5213a9f10aab52111a86e160570ee5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/ClusterNewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/NewClusterNetworkPopupPresenterWidget.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/EditDataCenterNetworkPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/EditNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/NewDataCenterNetworkPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/NewNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterNetworkPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/NewClusterNetworkPopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditDataCenterNetworkPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/NewDataCenterNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java 32 files changed, 1,344 insertions(+), 1,251 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a43ad89af5213a9f10aab52111a86e160570ee5 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0