- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: adding unlock_entity.sh script(#868638)
by yzaslavs＠redhat.com 28 Oct '12

28 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: adding unlock_entity.sh script(#868638) ...................................................................... core: adding unlock_entity.sh script(#868638) This patch adds a script to unlock disk objects in the db. The script has 2 modes 1. unlock a VM/Template 2. unlock a VM/Template and all its associated disks (using the -r flag) 3. unlock a specific disk Only plugged disks are considered as candidates of this command. The new script can be invoked basically by unlock_entity.sh -t TYPE -i ID where TYPE is either "vm" or "template" or "disk" ID is the entity name in case of VM/Tempalte, UUID is case of a disk. In order to display locked entities use: unlock_entity.sh -t TYPE -q The script supports all regular DB parameters as USER DATABASE etc. including the option to run the script remotely. The user is prompted to confirm that this is a dangerous operation and he should contact GSS prior to this operation. The operation is logged as an Alert in the audit_log with all relevant details. Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/868638 --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/unlock_entity.sh M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 4 files changed, 215 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Vms By Network Query
by msalem＠redhat.com 28 Oct '12

28 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: Vms By Network Query ...................................................................... core: Vms By Network Query This patch adds the GetVmsAndNetworkInterfacesByNetworkId query as part of the Network Main Tab feature. Change-Id: I8964c98e0cb90852e99ea40398ca1a28783cd4bd Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java 11 files changed, 212 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8964c98e0cb90852e99ea40398ca1a28783cd4bd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Query GetVdsWithoutNetwork
by msalem＠redhat.com 28 Oct '12

28 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: Query GetVdsWithoutNetwork ...................................................................... core: Query GetVdsWithoutNetwork The query above fetches all the Hosts that the given Network is not attached to, while the Network is assigned to their Cluster. Change-Id: If458c00ddfe6ef3c0616683ceb4d397914de8456 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsWithoutNetworkQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsWithoutNetworkQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 7 files changed, 119 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If458c00ddfe6ef3c0616683ceb4d397914de8456 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PairQueryable for Queries
by msalem＠redhat.com 28 Oct '12

28 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: PairQueryable for Queries ...................................................................... core: PairQueryable for Queries This patch adds the PairQueryable class to Common.gwt.xml, and adds the implementation of getQueryableId, to have a unique Id for each PairQueryable according to its members. It also changes network_cluster to extend IVdcQueryable so it could be returned in queries. Change-Id: Ib6fce607b90c818286428cdcc537f7c030155036 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network_cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Alona Kaplan: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6fce607b90c818286428cdcc537f7c030155036 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:auto-recovery mode is disabled ...(#869972)
by emesika＠redhat.com 28 Oct '12

28 Oct '12

Eli Mesika has submitted this change and it was merged. Change subject: core:auto-recovery mode is disabled ...(#869972) ...................................................................... core:auto-recovery mode is disabled ...(#869972) auto-recovery mode is disabled on data-base(#869972) Change AutoRecoveryAllowedTypes config value to have auto recovery for hosts flag set to true. Change-Id: I46166548dc6f0b56a7d32746a79d8ab6c781549d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46166548dc6f0b56a7d32746a79d8ab6c781549d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding EngineMode to engine-config
by yzaslavs＠redhat.com 28 Oct '12

28 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding EngineMode to engine-config ...................................................................... core: Adding EngineMode to engine-config This patch adds the ability to configure Engine working mode via engine-config Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912d11 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/868639 --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912d11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPE while adding lun disks (#869596)
by derez＠redhat.com 28 Oct '12

28 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: NPE while adding lun disks (#869596) ...................................................................... core: NPE while adding lun disks (#869596) fixing regression that was introduced in patch with change id I8cb77b017282733d72ff66af499b576674674e01 while adding a disk there is an attempt to check the storage domain of the disk in order to verify whether the added disk storage needs to be wiped after it's deletion, lun disks don't have storage domain and can't be wiped which caused to NPE. Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637 Bug-Url: https://bugzilla.redhat.com/869596 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/8821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix use of IsExecutableAllowed and ExecutionProhib...
by achub＠redhat.com 28 Oct '12

28 Oct '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Fix use of IsExecutableAllowed and ExecutionProhibitionReasons in UICommand model. ...................................................................... webadmin: Fix use of IsExecutableAllowed and ExecutionProhibitionReasons in UICommand model. Change-Id: Idd623481d0eb77bfbaa1e8b3eec8b445020711c8 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java 8 files changed, 62 insertions(+), 47 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd623481d0eb77bfbaa1e8b3eec8b445020711c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: create_db.sh use template1 instead ...(#870056)
by emesika＠redhat.com 28 Oct '12

28 Oct '12

Eli Mesika has submitted this change and it was merged. Change subject: core: create_db.sh use template1 instead ...(#870056) ...................................................................... core: create_db.sh use template1 instead ...(#870056) create_db.sh use template1 instead of template0(#870056) Database creation scripts are using template1 database, this may result in a locale conflict when we are using UTF8 and the template 1 is configured with ASCII. Change-Id: I1ea6938f091776002c3e46f68f96993efd1c2d6b Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=870056 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_db.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea6938f091776002c3e46f68f96993efd1c2d6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PairQueryable Class
by msalem＠redhat.com 28 Oct '12

28 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: PairQueryable Class ...................................................................... core: PairQueryable Class This patch adds the PairQueryable class, to enable returning a Pair as the return value of a Query. Change-Id: Ic26f8c18245eb187a6ee20dcb2b9b9c03c3992bf Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java 5 files changed, 88 insertions(+), 12 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic26f8c18245eb187a6ee20dcb2b9b9c03c3992bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0