- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: revert the remove of a check in VdsSelector
by rgolan＠redhat.com 22 Oct '12

22 Oct '12

Roy Golan has submitted this change and it was merged. Change subject: core: revert the remove of a check in VdsSelector ...................................................................... core: revert the remove of a check in VdsSelector Accidentally removed a check in VdsSelector due to refactoring Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: report 0 on negative values in maxSchedulingMemory
by rgolan＠redhat.com 22 Oct '12

22 Oct '12

Roy Golan has submitted this change and it was merged. Change subject: core: report 0 on negative values in maxSchedulingMemory ...................................................................... core: report 0 on negative values in maxSchedulingMemory Max memory for scheduling VMs should show 0 when the value is negative Change-Id: I1762002d89d1b015fa805084d7de7945c393f345 Bug-Url: https://bugzilla.redhat.com/866186 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1762002d89d1b015fa805084d7de7945c393f345 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing InitVdsOnUp
by mkublin＠redhat.com 22 Oct '12

22 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing InitVdsOnUp ...................................................................... engine: Fixing InitVdsOnUp The following patch will fix a bug with return value of InitVdsOnUp. In case of moving a host to NonOperational Status, InitVdsOnUp should return that it is not successed. Change-Id: I0aab031f67718be8a89dd67dcf3b1277c1e1ae45 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aab031f67718be8a89dd67dcf3b1277c1e1ae45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Lock dbscripts package
by juan.hernandez＠redhat.com 22 Oct '12

22 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Lock dbscripts package ...................................................................... packaging: Lock dbscripts package We lock most of the packages so they are not automatically updated when running "yum update" but we forgot the dbscripts subpackage. Change-Id: Ide1b2dcd00f221c44e0fe88d0135550998f8d2f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/basedefs.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide1b2dcd00f221c44e0fe88d0135550998f8d2f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache
by derez＠redhat.com 21 Oct '12

21 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache ...................................................................... core,webadmin: GetConfigurationValuesQuery for UI cache Added 'GetConfigurationValuesQuery' for fetching and caching all configuration values (ConfigurationValues enum) on UI startup. Apart of the obvious performance improvement, using a single query for retrieval (instead of a query for each value), results in a simpler/cleaner UI code. Core: * GetConfigurationValuesQuery - new query * Version - added 3_2 constant and 'ALL' version list for query's usage. * DBConfigUtils - lowered some logs from 'warn' to 'debug' for preventing redundant warnings on each query's execute. * Removed redundant ConfigurationValues (missing in ConfigValues enum): ExportDefaultPath and IrsClusterStatusRefreshRate. * Added ConfigValuesTest for finding missing enum names (exist in ConfigurationValues but missing in ConfigValues enum). UI: * AsyncDataProvider: ** CacheConfigValues - caching the 'pre-converted (raw)' configuration values returned from 'GetConfigurationValuesQuery'. ** GetConfigValue - getting a raw configuration value from the cache (for future usage - requires value conversion if needed). ** GetConfigFromCache - removed legacy 'GetConfigurationValue' call. * LoginModel/UserPortalLoginModel - caching values after login. * DataCenterNetworkListModel/HostInterfaceListModel - 'GetManagementNetworkName' call has relied on the fact that the query returns asynchronously - caused a NPE on startup. * DataProvider - removed redundant ConfigurationValues getter. Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 12 files changed, 214 insertions(+), 68 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Prevent regular user from viewing payload
by shavivi＠redhat.com 21 Oct '12

21 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Prevent regular user from viewing payload ...................................................................... engine: Prevent regular user from viewing payload Change-Id: I19eef08ac4d0091e5cc7b41d80e4076dd58ff84e Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/855667 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19eef08ac4d0091e5cc7b41d80e4076dd58ff84e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding NetworkIdParameters
by msalem＠redhat.com 21 Oct '12

21 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: Adding NetworkIdParameters ...................................................................... core: Adding NetworkIdParameters This patch adds the Parameters class for queries that use only Network Id. Change-Id: I6d5e3d2cfc44d80710e28e10db91f07bb1a65428 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkIdParameters.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5e3d2cfc44d80710e28e10db91f07bb1a65428 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix err msg-add disk to locked VM (#865551)
by derez＠redhat.com 21 Oct '12

21 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: fix err msg-add disk to locked VM (#865551) ...................................................................... core: fix err msg-add disk to locked VM (#865551) When adding a disk to a locked VM the error message stated locked disks (ACTION_TYPE_FAILED_DISKS_ARE_LOCKED) without mentioning the actual disks aliases. It's now changed to ACTION_TYPE_FAILED_VM_IS_LOCKED. Bug-Url: https://bugzilla.redhat.com/865551 Change-Id: Ib7a82d91b0ee51ebd1a612dbf210e0ea4533e746 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 2 files changed, 20 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/8666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a82d91b0ee51ebd1a612dbf210e0ea4533e746 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: report VDS if lun does not connect
by derez＠redhat.com 21 Oct '12

21 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: report VDS if lun does not connect ...................................................................... core: report VDS if lun does not connect - if the selected lun is not available, the host should be still reported Change-Id: I30a87e57b0121bfb2a4da9b38c3032604b245bc9 Bug-Url: https://bugzilla.redhat.com/846771 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30a87e57b0121bfb2a4da9b38c3032604b245bc9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Vitaly removed
by mkublin＠redhat.com 21 Oct '12

21 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Vitaly removed ...................................................................... engine: Vitaly removed Removed waiting Vitaly Change-Id: I961bbf8aa1aa99e17059ba645ff94d956b42aaf3 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961bbf8aa1aa99e17059ba645ff94d956b42aaf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0